https://bugzilla.redhat.com/show_bug.cgi?id=1694498
Bug ID: 1694498 Summary: Review Request: python-typing-extensions - Python Typing Extensions Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: hegjon@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: http://jonny.fedorapeople.org//python-typing-extensions.spec SRPM URL: http://jonny.fedorapeople.org//python-typing-extensions-3.7.2-1.fc29.src.rpm
Description: Typing Extensions - Backported and Experimental Type Hints for Python
The typing module was added to the standard library in Python 3.5 on a provisional basis and will no longer be provisional in Python 3.7. However, this means users of Python 3.5 - 3.6 who are unable to upgrade will not be able to take advantage of new types added to the typing module, such as typing.Text or typing.Coroutine.
The typing_extensions module contains both backports of these changes as well as experimental types that will eventually be added to the typing module, such as Protocol.
Users of other Python versions should continue to install and use the typing module from PyPi instead of using this one unless specifically writing code that must be compatible with multiple Python versions or requires experimental types.
https://bugzilla.redhat.com/show_bug.cgi?id=1694498
--- Comment #1 from Jonny Heggheim hegjon@gmail.com --- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=33857636
https://bugzilla.redhat.com/show_bug.cgi?id=1694498
Jonny Heggheim hegjon@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1688695
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1688695 [Bug 1688695] Unable to update Electron-Cash due to dependency
https://bugzilla.redhat.com/show_bug.cgi?id=1694498
Jonny Heggheim hegjon@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1683665
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1683665 [Bug 1683665] python-trezor-0.11.2 is available
https://bugzilla.redhat.com/show_bug.cgi?id=1694498
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zebob.m@gmail.com Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review?
--- Comment #2 from Robert-André Mauchin zebob.m@gmail.com --- BUILDSTDERR: ---------------------------------------------------------------------- BUILDSTDERR: Ran 0 tests in 0.000s BUILDSTDERR: OK
Tests aren't properly running. Please fix this.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* GNU General Public License", "Unknown or generated", "*No copyright* Python Software Foundation License". 10 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/python-typing-extensions/review-python- typing-extensions/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: python3-typing-extensions-3.7.2-1.fc31.noarch.rpm python-typing-extensions-3.7.2-1.fc31.src.rpm python3-typing-extensions.noarch: W: spelling-error %description -l en_US Coroutine -> Co routine, Co-routine, Routine python3-typing-extensions.noarch: W: spelling-error %description -l en_US backports -> back ports, back-ports, crackpots python-typing-extensions.src: W: spelling-error %description -l en_US Coroutine -> Co routine, Co-routine, Routine python-typing-extensions.src: W: spelling-error %description -l en_US backports -> back ports, back-ports, crackpots 2 packages and 0 specfiles checked; 0 errors, 4 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1694498
--- Comment #3 from Robert-André Mauchin zebob.m@gmail.com --- For the tests, you need:
Patch0: https://github.com/python/typing/commit/1f49677868a60ed697b0eafb2fb56471233b...
[…]
%package -n python3-typing-extensions Summary: %{summary} BuildRequires: python3-devel BuildRequires: python3-test
[…]
%prep %autosetup -n %{srcname}-%{version} -p2
[…]
%check %{__python3} src_py3/test_typing_extensions.py
https://bugzilla.redhat.com/show_bug.cgi?id=1694498
--- Comment #4 from Jonny Heggheim hegjon@gmail.com --- (In reply to Robert-André Mauchin from comment #2)
BUILDSTDERR:
BUILDSTDERR: Ran 0 tests in 0.000s BUILDSTDERR: OK
Tests aren't properly running. Please fix this.
Good catch, I have uploaded fixes, same URLs.
Spec URL: http://jonny.fedorapeople.org//python-typing-extensions.spec SRPM URL: http://jonny.fedorapeople.org//python-typing-extensions-3.7.2-1.fc29.src.rpm
New koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=33876657
https://bugzilla.redhat.com/show_bug.cgi?id=1694498
--- Comment #5 from Jonny Heggheim hegjon@gmail.com --- (In reply to Robert-André Mauchin from comment #3)
Looks like we fixed it at the same time, I used the patch from Debian: https://salsa.debian.org/med-team/python-typing-extensions/tree/master/debia.... Please let me know what you prefer.
https://bugzilla.redhat.com/show_bug.cgi?id=1694498
--- Comment #6 from Jonny Heggheim hegjon@gmail.com --- (In reply to Jonny Heggheim from comment #5)
(In reply to Robert-André Mauchin from comment #3)
Looks like we fixed it at the same time, I used the patch from Debian: https://salsa.debian.org/med-team/python-typing-extensions/tree/master/ debian/patches. Please let me know what you prefer.
I updated again with your patches and %check without cd, same URLs.
https://bugzilla.redhat.com/show_bug.cgi?id=1694498
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #7 from Robert-André Mauchin zebob.m@gmail.com --- LGTM, package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1694498
--- Comment #8 from Jonny Heggheim hegjon@gmail.com --- (In reply to Robert-André Mauchin from comment #7)
LGTM, package approved.
Thanks for the review
https://bugzilla.redhat.com/show_bug.cgi?id=1694498
--- Comment #9 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-typing-extensions
https://bugzilla.redhat.com/show_bug.cgi?id=1694498
Jonny Heggheim hegjon@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |CURRENTRELEASE Last Closed| |2019-04-02 17:38:49
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com