[Bug 1725373] New: Review Request: perl-Net-AMQP - Advanced Message Queue Protocol (de)serialization and representation
https://bugzilla.redhat.com/show_bug.cgi?id=1725373
Bug ID: 1725373 Summary: Review Request: perl-Net-AMQP - Advanced Message Queue Protocol (de)serialization and representation Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: emmanuel@seyman.fr QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: http://people.parinux.org/~seyman/fedora/perl-Net-AMQP/perl-Net-AMQP.spec SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Net-AMQP/perl-Net-AMQP-0.06-1.... Description: This module implements the frame (de)serialization and representation of the Advanced Message Queue Protocol (http://www.amqp.org/). It is to be used in conjunction with client or server software that does the actual TCP/IP communication.
Fedora Account System Username: eseyman Rpmlint Output: perl-Net-AMQP.src: W: spelling-error Summary(en_US) de -> DE, ed, d perl-Net-AMQP.src: W: spelling-error %description -l en_US de -> DE, ed, d 1 packages and 1 specfiles checked; 0 errors, 2 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1725373
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jplesnik@redhat.com Assignee|nobody@fedoraproject.org |jplesnik@redhat.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1725373
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #1 from Jitka Plesnikova jplesnik@redhat.com --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed BuildRequires are ok
$ rpm -qp --requires perl-Net-AMQP-0.06-1.fc31.noarch.rpm | sort | uniq -c | grep -v rpmlib 1 perl(base) 1 perl(Carp) 1 perl(Class::Accessor::Fast) 1 perl(Class::Data::Inheritable) 1 perl(constant) 1 perl(Data::Dumper) 1 perl(Exporter) 1 perl(File::Path) 1 perl(File::Spec) 1 perl(:MODULE_COMPAT_5.30.0) 1 perl(Net::AMQP) 1 perl(Net::AMQP::Common) 1 perl(Net::AMQP::Frame) 1 perl(Net::AMQP::Frame::Body) 1 perl(Net::AMQP::Frame::Header) 1 perl(Net::AMQP::Frame::Heartbeat) 1 perl(Net::AMQP::Frame::Method) 1 perl(Net::AMQP::Frame::OOBBody) 1 perl(Net::AMQP::Frame::OOBHeader) 1 perl(Net::AMQP::Frame::OOBMethod) 1 perl(Net::AMQP::Frame::Trace) 1 perl(Net::AMQP::Protocol) 1 perl(Net::AMQP::Protocol::Base) 1 perl(Net::AMQP::Value) 1 perl(overload) 1 perl(Scalar::Util) 1 perl(strict) 1 perl(:VERSION) >= 5.6.0 1 perl(warnings) 1 perl(XML::LibXML) Binary requires are Ok.
$ rpm -qp --provides perl-Net-AMQP-0.06-1.fc31.noarch.rpm | sort | uniq -c 1 perl(Net::AMQP) = 0.06 1 perl-Net-AMQP = 0.06-1.fc31 1 perl(Net::AMQP::Common) 1 perl(Net::AMQP::Frame) 1 perl(Net::AMQP::Frame::Body) 1 perl(Net::AMQP::Frame::Header) 1 perl(Net::AMQP::Frame::Heartbeat) 1 perl(Net::AMQP::Frame::Method) 1 perl(Net::AMQP::Frame::OOBBody) 1 perl(Net::AMQP::Frame::OOBHeader) 1 perl(Net::AMQP::Frame::OOBMethod) 1 perl(Net::AMQP::Frame::Trace) 1 perl(Net::AMQP::Protocol) 1 perl(Net::AMQP::Protocol::Base) 1 perl(Net::AMQP::Protocol::v0_8) 1 perl(Net::AMQP::Value) 1 perl(Net::AMQP::Value::Boolean) 1 perl(Net::AMQP::Value::Integer) 1 perl(Net::AMQP::Value::String) 1 perl(Net::AMQP::Value::Timestamp) Binary provides are Ok.
$ rpmlint ./perl-Net-AMQP* perl-Net-AMQP.noarch: W: spelling-error Summary(en_US) de -> DE, ed, d perl-Net-AMQP.noarch: W: spelling-error %description -l en_US de -> DE, ed, d perl-Net-AMQP.noarch: E: incorrect-fsf-address /usr/share/licenses/perl-Net-AMQP/LICENSE perl-Net-AMQP.src: W: spelling-error Summary(en_US) de -> DE, ed, d perl-Net-AMQP.src: W: spelling-error %description -l en_US de -> DE, ed, d 2 packages and 1 specfiles checked; 1 errors, 4 warnings. TODO: Please report the invalid address to upstream.
Please consider fixing 'TODO' item.
The package looks good. Resolution: Approved
https://bugzilla.redhat.com/show_bug.cgi?id=1725373
--- Comment #2 from Emmanuel Seyman emmanuel@seyman.fr --- (In reply to Jitka Plesnikova from comment #1)
TODO: Please report the invalid address to upstream.
Done in https://rt.cpan.org/Public/Bug/Display.html?id=129959
I've also requested the repo with branches for F31, F30 and F29. Thank you for the review, Jikta.
https://bugzilla.redhat.com/show_bug.cgi?id=1725373
--- Comment #3 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Net-AMQP
https://bugzilla.redhat.com/show_bug.cgi?id=1725373
Emmanuel Seyman emmanuel@seyman.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1726432 | |(perl-Mojo-RabbitMQ-Client)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1726432 [Bug 1726432] Review Request: perl-Mojo-RabbitMQ-Client - Mojo::IOLoop based RabbitMQ client
https://bugzilla.redhat.com/show_bug.cgi?id=1725373
Emmanuel Seyman emmanuel@seyman.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE Last Closed| |2019-08-01 20:20:44
--- Comment #4 from Emmanuel Seyman emmanuel@seyman.fr --- This is in rawhide and updates have been published for F30 and F29.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com