https://bugzilla.redhat.com/show_bug.cgi?id=1723575
Bug ID: 1723575 Summary: Review Request: python-insights-core - data collection and processing framework Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: dylan@theone.ninja QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://copr-be.cloud.fedoraproject.org/results/dstathis/insights-core/fedor... SRPM URL: https://copr-be.cloud.fedoraproject.org/results/dstathis/insights-core/fedor... Description: Insights Core is a data collection and analysis framework that is built for extensibility and rapid development. Included are a set of reusable components for gathering data in myriad ways and providing a reliable object model for commonly useful unstructured and semi-structured data. https://github.com/RedHatInsights/insights-core
ps: This is my first batch of Review requests and I am seeking a packaging sponsor. Fedora Account System Username: dstathis
https://bugzilla.redhat.com/show_bug.cgi?id=1723575
Dylan Stephano-Shachter dylan@theone.ninja changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1723572
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1723572 [Bug 1723572] Review Request: python-cachecontrol - The httplib2 caching algorithms packaged up for use with requests.
https://bugzilla.redhat.com/show_bug.cgi?id=1723575
Dylan Stephano-Shachter dylan@theone.ninja changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On|1723572 |1723570
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1723570 [Bug 1723570] Review Request: python-filecache - Save return values to files https://bugzilla.redhat.com/show_bug.cgi?id=1723572 [Bug 1723572] Review Request: python-cachecontrol - The httplib2 caching algorithms packaged up for use with requests.
https://bugzilla.redhat.com/show_bug.cgi?id=1723575
Dylan Stephano-Shachter dylan@theone.ninja changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1723572
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1723572 [Bug 1723572] Review Request: python-cachecontrol - The httplib2 caching algorithms packaged up for use with requests.
https://bugzilla.redhat.com/show_bug.cgi?id=1723575
Elliott Sales de Andrade quantum.analyst@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |quantum.analyst@gmail.com
--- Comment #1 from Elliott Sales de Andrade quantum.analyst@gmail.com --- New Python packages must receive an exception to contain Python 2 version, or just not bother with it. Please fill out the Summary and Description in the spec to something more substantial than just repeating the name.
https://bugzilla.redhat.com/show_bug.cgi?id=1723575
--- Comment #2 from Dylan Stephano-Shachter dylan@theone.ninja --- I've fixed both of the mentioned issues. How does this look?
Here is the new spec: https://copr-be.cloud.fedoraproject.org/results/dstathis/insights-core/fedor...
Here is the new srpm: https://copr-be.cloud.fedoraproject.org/results/dstathis/insights-core/fedor...
https://bugzilla.redhat.com/show_bug.cgi?id=1723575
--- Comment #3 from Dylan Stephano-Shachter dylan@theone.ninja --- Sorry that one is for cachecontrol. I'll get the ones for insights-core up momentarily.
https://bugzilla.redhat.com/show_bug.cgi?id=1723575
--- Comment #4 from Dylan Stephano-Shachter dylan@theone.ninja --- New spec: https://copr-be.cloud.fedoraproject.org/results/dstathis/insights-core/fedor...
New srpm: https://copr-be.cloud.fedoraproject.org/results/dstathis/insights-core/fedor...
https://bugzilla.redhat.com/show_bug.cgi?id=1723575
Dylan Stephano-Shachter dylan@theone.ninja changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841 (FE-NEEDSPONSOR)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=1723575 Bug 1723575 depends on bug 1723572, which changed state.
Bug 1723572 Summary: Review Request: python-cachecontrol - The httplib2 caching algorithms packaged up for use with requests. https://bugzilla.redhat.com/show_bug.cgi?id=1723572
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |NOTABUG
https://bugzilla.redhat.com/show_bug.cgi?id=1723575
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@gmail.com
--- Comment #5 from Robert-André Mauchin zebob.m@gmail.com --- - Use a bcond_without for this
%if 0%{?rhel} == 7 %bcond_without python2 %endif
And then:
%if %{with python2} blah blah %endif
- Xour descriptions must be wrapped to 80 characters per line
- Name should be:
Name: python-%{pkgname}
- Comments at the end of line are not supported officially by rpm:
%endif # with_python2
This will fail with rpm 4.15
- Install the examples with %doc
%files -n python%{python3_pkgversion}-%{pkgname} %doc examples
- Build the docs with Sphinx and install them with %doc
# generate html docs sphinx-build-3 docs html # remove the sphinx-build leftovers rm -rf html/.{doctrees,buildinfo}
-Install the misc docs markdown files:
%files -n python%{python3_pkgversion}-%{pkgname} %doc examples %doc CHANGELOG.md CONTRIBUTING.md README.rst
- you *must* install the LICENSE file with %license in %files for any subpackage compination:
%files -n python2-%{pkgname} %license LICENSE
%files -n python%{python3_pkgversion}-%{pkgname} %license LICENSE
- You are missing the Python provide macro:
%package -n python2-%{pkgname} Summary: Data collection and processing framework %{?python_provide:%python_provide python2-%{pkgname}}
%package -n python%{python3_pkgversion}-%{pkgname} Summary: Data collection and processing framework %{?python_provide:%python_provide python3-%{pkgname}}
See https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_the_pytho...
- add a space between your name and email in you changelog entry
https://bugzilla.redhat.com/show_bug.cgi?id=1723575
--- Comment #6 from Dylan Stephano-Shachter dylan@theone.ninja --- I am having a bit of difficulty properly building the docs. It could be done easily withing a virtualenv. Would that be an reasonable thing to do inside an rpm build given that it is only used to build the docs?
https://bugzilla.redhat.com/show_bug.cgi?id=1723575
--- Comment #7 from Dylan Stephano-Shachter dylan@theone.ninja --- I realized that building the docs with a virtualenv requires "--enable-networking" which I think is not ideal. I will try to figure out how to get the docs without it.
https://bugzilla.redhat.com/show_bug.cgi?id=1723575
--- Comment #8 from Robert-André Mauchin zebob.m@gmail.com --- Usually it's just something like:
# generate html docs sphinx-build-3 docs html # remove the sphinx-build leftovers rm -rf html/.{doctrees,buildinfo}
What problem are you encountering?
https://bugzilla.redhat.com/show_bug.cgi?id=1723575
--- Comment #9 from Dylan Stephano-Shachter dylan@theone.ninja --- After adding a number of build dependencies and removing the -W from sphinx-build-3 I have gotten it to build the docs. There are, however, two warning messages that concern me.
/usr/lib/python3.7/site-packages/nbsphinx.py:1174: RuntimeWarning: You are using an unsupported version of pandoc (2.2.1). Your version must be at least (1.12.1) but less than (2.0.0). Refer to http://pandoc.org/installing.html. Continuing with doubts... nbconvert.utils.pandoc.check_pandoc_version()
and
WARNING: Pygments lexer name 'ipython2' is not known
Each one is repeated numerous times and the packages required don't seem to exist in the fedora repos. Pandoc is too new and python2-ipython is no longer packaged
Note: There is a further concern that many of the build dependencies don't exist for python 2 on Centos 7 but that is an issue I will deal with when I submit to EPEL
https://bugzilla.redhat.com/show_bug.cgi?id=1723575
--- Comment #10 from Elliott Sales de Andrade quantum.analyst@gmail.com --- There's not much you can do about the first one, except wait for a new nbshinx package. I think for the latter, it's also about nbshinx, so you might have to wait for an update there too.
Product: Fedora Version: rawhide Component: Package Review
Package Review package-review@lists.fedoraproject.org has canceled Package Review package-review@lists.fedoraproject.org's request for Dylan Stephano-Shachter dylan@theone.ninja's needinfo: Bug 1723575: Review Request: python-insights-core - data collection and processing framework https://bugzilla.redhat.com/show_bug.cgi?id=1723575
--- Comment #12 from Package Review package-review@lists.fedoraproject.org --- This is an automatic action taken by review-stats script.
The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it.
package-review@lists.fedoraproject.org