[Bug 508453] New: Review Request: rubygem-test-spec - Behaviour Driven Development interface for Test::Unit

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: rubygem-test-spec - Behaviour Driven Development interface for Test::Unit

https://bugzilla.redhat.com/show_bug.cgi?id=508453

Summary: Review Request: rubygem-test-spec - Behaviour Driven
                    Development interface for Test::Unit
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: low
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora

SPEC: http://v3.sk/~lkundrak/gdc-ruby-stack/SPECS/rubygem-test-spec.spec
SRPM:
http://v3.sk/~lkundrak/gdc-ruby-stack/SRPMS/rubygem-test-spec-0.10.0-1.fc11....

Description:

Test/spec layers an RSpec-inspired interface on top of Test::Unit, so you
can mix TDD and BDD (Behavior-Driven Development).  It is a clean-room
implementation that maps most kinds of Test::Unit assertions to a
should-like syntax.

[Bug 508453] Review Request: rubygem-test-spec - Behaviour Driven Development interface for Test::Unit

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=508453

Michal Ingeli  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
               Flag|                            |fedora-review?

[Bug 508453] Review Request: rubygem-test-spec - Behaviour Driven Development interface for Test::Unit

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=508453

--- Comment #1 from Michal Ingeli   2009-06-28 08:52:47 EDT ---
* naming ok
* spec file clean, american english
* file lists ok, examples in documentation
* builds in mock
* rpmlint silent
* source matches upstream

work to do:
- package is distributed in the same terms as ruby is. So it should have ruby
license or GPLv2. Not GPLv2+.
- Consistent build root reference. In %clean stare it's referred to build root
as %{buildroot} and other stages uses $RPM_BUILD_ROOT.
- add BuildRequires: ruby(abi) = 1.8 (maybe should be checked by rpmlint)

[Bug 508453] Review Request: rubygem-test-spec - Behaviour Driven Development interface for Test::Unit

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=508453

Michal Ingeli  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]

[Bug 508453] Review Request: rubygem-test-spec - Behaviour Driven Development interface for Test::Unit

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=508453

--- Comment #2 from Lubomir Rintel   2009-07-08 13:01:09 EDT ---
(In reply to comment #1)
> work to do:
> package is distributed in the same terms as ruby is. So it should have ruby
>
> license or GPLv2. Not GPLv2+.

Good catch. Fixed.
> Consistent build root reference. In %clean stare it's referred to build root
>
> as %{buildroot} and other stages uses $RPM_BUILD_ROOT.

Fixed.
> add BuildRequires: ruby(abi) = 1.8 (maybe should be checked by rpmlint)

bug #510313

SPEC: http://v3.sk/~lkundrak/gdc-ruby-stack/SPECS/rubygem-test-spec.spec
SRPM:
http://v3.sk/~lkundrak/gdc-ruby-stack/SRPMS/rubygem-test-spec-0.10.0-2.fc11....

[Bug 508453] Review Request: rubygem-test-spec - Behaviour Driven Development interface for Test::Unit

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=508453

--- Comment #3 from Michal Ingeli   2009-07-13 07:54:43 EDT ---
All work done, looks good.

APPROVED

[Bug 508453] Review Request: rubygem-test-spec - Behaviour Driven Development interface for Test::Unit

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=508453

Lubomir Rintel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #4 from Lubomir Rintel   2009-07-13 08:24:08 EDT ---
New Package CVS Request
=======================
Package Name: rubygem-test-spec
Short Description: Behaviour Driven Development interface for Test::Unit
Owners: lkundrak
Branches: F-11 EL-5

[Bug 508453] Review Request: rubygem-test-spec - Behaviour Driven Development interface for Test::Unit

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=508453

Michal Ingeli  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

[Bug 508453] Review Request: rubygem-test-spec - Behaviour Driven Development interface for Test::Unit

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=508453

Kevin Fenzi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

--- Comment #5 from Kevin Fenzi   2009-07-14 00:48:52 EDT ---
cvs done.

[Bug 508453] Review Request: rubygem-test-spec - Behaviour Driven Development interface for Test::Unit

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=508453

Lubomir Rintel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

--- Comment #6 from Lubomir Rintel   2009-07-31 02:11:51 EDT ---
Thanks for the review and CVS. Imported and build.

[Bug 508453] Review Request: rubygem-test-spec - Behaviour Driven Development interface for Test::Unit

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=508453

Michael Stahnke  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from Michael Stahnke  2010-04-16 18:15:24 EDT ---
Is there a reason this was built for EPEL5 but never put in as an update?  If
you would like a co-maintainer in EPEL, I'd be happy to do it.