[Bug 1379393] New: Review Request: pavucontrol-qt - Qt port of volume control pavucontrol
https://bugzilla.redhat.com/show_bug.cgi?id=1379393
Bug ID: 1379393 Summary: Review Request: pavucontrol-qt - Qt port of volume control pavucontrol Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: helio@kde.org QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://heliocastro.fedorapeople.org/pavucontrol-qt/pavucontrol-qt.spec SRPM URL: https://heliocastro.fedorapeople.org/pavucontrol-qt/pavucontrol-qt-0.1.0-1.f... Description: Qt port of volume control pavucontrol Fedora Account System Username: heliocastro
https://bugzilla.redhat.com/show_bug.cgi?id=1379393
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |rdieter@math.unl.edu Blocks| |928937 (qt-reviews) Assignee|nobody@fedoraproject.org |rdieter@math.unl.edu Alias| |pavucontrol-qt Flags| |fedora-review?
--- Comment #1 from Rex Dieter rdieter@math.unl.edu --- I can review today (or tomorrow)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=928937 [Bug 928937] Qt-related package review tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1379393
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #2 from Rex Dieter rdieter@math.unl.edu --- naming: ok
license: ok
1. could/should leave out: BuildRequires: %{?fedora:cmake}%{!?fedora:cmake3} >= 3.0 that dependency should be handled by whatever package that provides the %{cmake_lxqt} macro
macros: ok
2. should consider adjusting pavucontrol-qt.desktop Name/GenericNameComment somehow, it currently appears exactly the same as pavucontrol, so it's hard/impossible to distinguish which is which, contains: Name=PulseAudio Volume Control GenericName=Volume Control Comment=Adjust the volume level (not a blocker, mostly a suggestion for pavucontrol-qt upstream)
scriptlets: ok (n/a)
sources: ok 32217c5ae8a846e92548a55b8d3b9267 pavucontrol-qt-0.1.0.tar.xz
otherwise, package is fairly simple and clean, APPROVED
https://bugzilla.redhat.com/show_bug.cgi?id=1379393
Helio Chissini de Castro helio@kde.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |CURRENTRELEASE Last Closed| |2016-10-07 07:42:17
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla