https://bugzilla.redhat.com/show_bug.cgi?id=1735701
Bug ID: 1735701 Summary: Review Request: golang-github-snapcore-gettext - native Go library for using gettext files Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: maciek.borzecki@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://copr-be.cloud.fedoraproject.org/results/bboozzoo/golang-github-snapc... SRPM URL: https://copr-be.cloud.fedoraproject.org/results/bboozzoo/golang-github-snapc... Description: Native Go library for accessing gettext internationalization files Fedora Account System Username: bboozzoo
Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=36729464
This is my first pacakge. I'm in need of a sponsor.
https://bugzilla.redhat.com/show_bug.cgi?id=1735701
Maciek Borzecki maciek.borzecki@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841 (FE-NEEDSPONSOR)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=1735701
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@gmail.com
--- Comment #1 from Robert-André Mauchin zebob.m@gmail.com --- - If no release has been published upstream, the Release field should start at 0.1
Release: 0.1%{?dist}
- The full Release tag for a dev snapshot is computed automatically by gometa, but you still need to include in in the %changelog:
* Thu Aug 01 2019 Maciek Borzecki maciek.borzecki@gmail.com - 0-0.1.20190801git6598fb2
(the date will need to be the date you import the archive into dist-git)
https://bugzilla.redhat.com/show_bug.cgi?id=1735701
--- Comment #2 from Robert-André Mauchin zebob.m@gmail.com --- Also you should use go2rpm, it will fill the correct info automatically.
https://bugzilla.redhat.com/show_bug.cgi?id=1735701
--- Comment #3 from Maciek Borzecki maciek.borzecki@gmail.com --- (In reply to Robert-André Mauchin from comment #2)
Also you should use go2rpm, it will fill the correct info automatically.
Thank you for the review!
I've switched to gp2rpm and updated the spec accordingly. Kept the description though. The one from upstream is super terse.
SPEC: https://copr-be.cloud.fedoraproject.org/results/bboozzoo/golang-github-snapc... SRPM: https://copr-be.cloud.fedoraproject.org/results/bboozzoo/golang-github-snapc...
Scratch build for rawhide looks fine as well: https://koji.fedoraproject.org/koji/taskinfo?taskID=36738239
https://bugzilla.redhat.com/show_bug.cgi?id=1735701
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review+
--- Comment #4 from Robert-André Mauchin zebob.m@gmail.com ---
19:31:46 mborzecki | hi, quick question about the dist-git import you mentioned if you don't mind, that will happen once the package is actually accepted and i'll
| be importing it with fedpkg right?
Xes, when the package is accepted, the repo requested, you will be able tto import the srpm with fedpkg import . Since we automated the computation of the Release: field with macros, the actual snapshot date used is the one of the upload date.
- License ok - Latest version packaged - Builds in mock - No rpmlint errors - Conforms to Packaging Guidelines
Package approved.
You still need to find a sponsor, I suggest you introduce yourself on the devel mailing list and do informal reviews. See https://fedoraproject.org/wiki/Join_the_package_collection_maintainers?rd=Pa... and https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group
https://bugzilla.redhat.com/show_bug.cgi?id=1735701
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ngompa13@gmail.com Blocks|177841 (FE-NEEDSPONSOR) |
--- Comment #5 from Neal Gompa ngompa13@gmail.com --- I've sponsored Maciek as a packager, this should be clear for import.
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=1735701
--- Comment #6 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-snapcore-gettext
https://bugzilla.redhat.com/show_bug.cgi?id=1735701
Maciek Borzecki maciek.borzecki@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE Last Closed| |2019-08-23 06:46:00
--- Comment #7 from Maciek Borzecki maciek.borzecki@gmail.com --- Build: https://koji.fedoraproject.org/koji/buildinfo?buildID=1363125 Submitted to rawhide: https://bodhi.fedoraproject.org/updates/FEDORA-2019-964569e82f
Thanks you for your help!
https://bugzilla.redhat.com/show_bug.cgi?id=1735701
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2019-8136109724 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-8136109724
https://bugzilla.redhat.com/show_bug.cgi?id=1735701
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- golang-github-snapcore-gettext-0-0.1.20190823gita77afd6.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1735701
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- golang-github-snapcore-gettext-0-0.1.20190823gita77afd6.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org