https://bugzilla.redhat.com/show_bug.cgi?id=1442473
Bug ID: 1442473 Summary: Review Request: php-cache-filesystem-adapter - A PSR-6 cache implementation using filesystem Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: shawn@iwin.ski QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://raw.githubusercontent.com/siwinski/rpms/fc17e66f90ea9573adf80852dec5...
SRPM URL: https://siwinski.fedorapeople.org/SRPMS/php-cache-filesystem-adapter-0.4.0-1...
Description: A PSR-6 cache implementation using filesystem. This implementation supports tags.
Fedora Account System Username: siwinski
https://bugzilla.redhat.com/show_bug.cgi?id=1442473
Shawn Iwinski shawn@iwin.ski changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1386152, 1438295 Depends On| |1442469 | |(php-psr-simple-cache), | |1442472 | |(php-cache-adapter-common), | |1442471 | |(php-cache-integration-test | |s) Alias| |php-cache-filesystem-adapte | |r
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1386152 [Bug 1386152] v2 release https://bugzilla.redhat.com/show_bug.cgi?id=1438295 [Bug 1438295] php-google-apiclient-2.1.3 is available https://bugzilla.redhat.com/show_bug.cgi?id=1442469 [Bug 1442469] Review Request: php-psr-simple-cache - Common interfaces for simple caching (PSR-16) https://bugzilla.redhat.com/show_bug.cgi?id=1442471 [Bug 1442471] Review Request: php-cache-integration-tests - Integration tests for PSR-6 and PSR-16 cache implementations https://bugzilla.redhat.com/show_bug.cgi?id=1442472 [Bug 1442472] Review Request: php-cache-adapter-common - Common classes for PSR-6 adapters
https://bugzilla.redhat.com/show_bug.cgi?id=1442473 Bug 1442473 depends on bug 1442469, which changed state.
Bug 1442469 Summary: Review Request: php-psr-simple-cache - Common interfaces for simple caching (PSR-16) https://bugzilla.redhat.com/show_bug.cgi?id=1442469
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1442473
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@famillecollet.com
--- Comment #1 from Remi Collet fedora@famillecollet.com --- Created attachment 1277902 --> https://bugzilla.redhat.com/attachment.cgi?id=1277902&action=edit phpci.log
phpCompatInfo version 5.0.6 DB version 1.20.0 built Apr 14 2017 16:12:51 CEST static analyze results
https://bugzilla.redhat.com/show_bug.cgi?id=1442473
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |fedora@famillecollet.com
--- Comment #2 from Remi Collet fedora@famillecollet.com --- Created attachment 1277903 --> https://bugzilla.redhat.com/attachment.cgi?id=1277903&action=edit review.txt
Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1442473 -L /dev/shm/extras/RPMS/noarch/ Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, PHP, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Built with local dependencies:
/dev/shm/extras/RPMS/noarch/php-cache-adapter-common-0.4.0-1.fc25.remi.noarch.rpm
/dev/shm/extras/RPMS/noarch/php-cache-integration-tests-0.16.0-1.fc25.remi.noarch.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1442473
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?
--- Comment #3 from Remi Collet fedora@famillecollet.com --- Single blocker, trivial to fix
[!]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/php/Cache/Adapter (php-cache-adapter-common)
https://bugzilla.redhat.com/show_bug.cgi?id=1442473
--- Comment #4 from Shawn Iwinski shawn@iwin.ski --- (In reply to Remi Collet from comment #3)
Single blocker, trivial to fix
[!]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/php/Cache/Adapter (php-cache-adapter-common)
Fixed
Spec URL: https://raw.githubusercontent.com/siwinski/rpms/8f455616178bae05ec7da69cd1a2...
SRPM URL: https://siwinski.fedorapeople.org/SRPMS/php-cache-filesystem-adapter-0.4.0-2...
https://bugzilla.redhat.com/show_bug.cgi?id=1442473
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #5 from Remi Collet fedora@famillecollet.com --- -%dir %{phpdir}/Cache/Adapter - %{phpdir}/Cache/Adapter/Filesystem +%{phpdir}/Cache/Adapter/Filesystem
[x]: Package does not own files or directories owned by other packages.
== APPROVED ==
https://bugzilla.redhat.com/show_bug.cgi?id=1442473
--- Comment #6 from Shawn Iwinski shawn@iwin.ski --- THANKS for the review! Pkg request submitted via pkgdb.
https://bugzilla.redhat.com/show_bug.cgi?id=1442473
--- Comment #7 from Gwyn Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/php-cache-filesystem-adap...
https://bugzilla.redhat.com/show_bug.cgi?id=1442473
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- php-cache-integration-tests-0.16.0-1.fc26 php-cache-adapter-common-0.4.0-1.fc26 php-cache-filesystem-adapter-0.4.0-2.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-67d0fe1bb9
https://bugzilla.redhat.com/show_bug.cgi?id=1442473
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1442473
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- php-cache-integration-tests-0.16.0-1.fc25 php-cache-adapter-common-0.4.0-1.fc25 php-cache-filesystem-adapter-0.4.0-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-1c8e2f9970
https://bugzilla.redhat.com/show_bug.cgi?id=1442473
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- php-cache-adapter-common-0.4.0-1.fc25, php-cache-filesystem-adapter-0.4.0-2.fc25, php-cache-integration-tests-0.16.0-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-1c8e2f9970
https://bugzilla.redhat.com/show_bug.cgi?id=1442473
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- php-cache-adapter-common-0.4.0-1.fc26, php-cache-filesystem-adapter-0.4.0-2.fc26, php-cache-integration-tests-0.16.0-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-67d0fe1bb9
https://bugzilla.redhat.com/show_bug.cgi?id=1442473
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2017-06-13 09:34:43
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- php-cache-adapter-common-0.4.0-1.fc26, php-cache-filesystem-adapter-0.4.0-2.fc26, php-cache-integration-tests-0.16.0-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1442473 Bug 1442473 depends on bug 1442472, which changed state.
Bug 1442472 Summary: Review Request: php-cache-adapter-common - Common classes for PSR-6 adapters https://bugzilla.redhat.com/show_bug.cgi?id=1442472
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1442473 Bug 1442473 depends on bug 1442471, which changed state.
Bug 1442471 Summary: Review Request: php-cache-integration-tests - Integration tests for PSR-6 and PSR-16 cache implementations https://bugzilla.redhat.com/show_bug.cgi?id=1442471
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1442473
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- php-cache-adapter-common-0.4.0-1.fc25, php-cache-filesystem-adapter-0.4.0-2.fc25, php-cache-integration-tests-0.16.0-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org