https://bugzilla.redhat.com/show_bug.cgi?id=2038788
Bug ID: 2038788 Summary: Review Request: nu-json - Fork of serde-hjson Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: michel@michel-slm.name QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://salimma.fedorapeople.org/specs/rust/rust-nu-json.spec SRPM URL: https://salimma.fedorapeople.org/specs/rust/rust-nu-json-0.42.0-1.fc35.src.r... Description: Fork of serde-hjson. Fedora Account System Username: salimma
https://bugzilla.redhat.com/show_bug.cgi?id=2038788
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@gmail.com Summary|Review Request: nu-json - |Review Request: |Fork of serde-hjson |rust-nu-json - Fork of | |serde-hjson
--- Comment #1 from Fabio Valentini decathorpe@gmail.com --- (fixed bug title)
https://bugzilla.redhat.com/show_bug.cgi?id=2038788
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Assignee|nobody@fedoraproject.org |decathorpe@gmail.com Flags| |fedora-review+
--- Comment #2 from Fabio Valentini decathorpe@gmail.com --- "problems with paths" is not a very descriptive comment as to why the tests are disabled.
Maybe use something like "logic for finding test assets in nu_test_support is broken"? Or try to fix the asset finding logic in nu_test_support? :)
Other than that, the package looks good.
===
Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide - test suite is disabled (explanation *why* it is disabled could be better) - latest version of the crate is packaged - license matches upstream specification (MIT) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- add package to rust-sig with "commit" access
- set bugzilla assignee overrides to @rust-sig (optional)
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- track package in koschei for all built branches
https://bugzilla.redhat.com/show_bug.cgi?id=2038788
--- Comment #3 from Michel Alexandre Salim michel@michel-slm.name --- (In reply to Fabio Valentini from comment #2)
"problems with paths" is not a very descriptive comment as to why the tests are disabled.
agreed, I'll make it more descriptive when importing, thanks.
Maybe use something like "logic for finding test assets in nu_test_support is broken"? Or try to fix the asset finding logic in nu_test_support? :)
oh yeah, I'll definitely do that once all this is in :) Thanks!
❯ fedpkg request-repo rust-nu-json 2038788 https://pagure.io/releng/fedora-scm-requests/issue/40741
https://bugzilla.redhat.com/show_bug.cgi?id=2038788
--- Comment #4 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-nu-json
https://bugzilla.redhat.com/show_bug.cgi?id=2038788
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-a7b8406617 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-a7b8406617
https://bugzilla.redhat.com/show_bug.cgi?id=2038788
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-00805ead9b has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2022-00805ead9b
https://bugzilla.redhat.com/show_bug.cgi?id=2038788
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-f12eda9c87 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-f12eda9c87
https://bugzilla.redhat.com/show_bug.cgi?id=2038788
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-f12eda9c87 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-f12eda9c87 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-f12eda9c87
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2038788
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-00805ead9b has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-00805ead9b *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-00805ead9b
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2038788
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-a7b8406617 has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-a7b8406617 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-a7b8406617
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2038788 Bug 2038788 depends on bug 2038637, which changed state.
Bug 2038637 Summary: Review Request: rust-nu-test-support - Support for writing Nushell tests https://bugzilla.redhat.com/show_bug.cgi?id=2038637
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |NOTABUG
https://bugzilla.redhat.com/show_bug.cgi?id=2038788 Bug 2038788 depends on bug 2038636, which changed state.
Bug 2038636 Summary: Review Request: rust-nu-path - Path handling library for Nushell https://bugzilla.redhat.com/show_bug.cgi?id=2038636
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2038788
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2022-04-17 22:21:18
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-00805ead9b has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2038788
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-f12eda9c87 has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2038788
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-a7b8406617 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com