Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: perl-Env-Path - Advanced operations on path variables Alias: perl-Env-Path
https://bugzilla.redhat.com/show_bug.cgi?id=751531
Summary: Review Request: perl-Env-Path - Advanced operations on path variables Product: Fedora Version: rawhide Platform: Unspecified URL: http://search.cpan.org/dist/Env-Path/ OS/Version: Unspecified Status: NEW Severity: unspecified Priority: unspecified Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: iarnell@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: ---
Spec URL: http://fedorapeople.org/~iarnell/review/perl-Env-Path.spec SRPM URL: http://fedorapeople.org/~iarnell/review/perl-Env-Path-0.18-1.fc17.src.rpm
Description: Env::Path presents an object-oriented interface to path variables, defined as that subclass of environment variables which name an ordered list of filesystem elements separated by a platform-standard separator.
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3490625
*rt-0.10_02
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=751531
Mario Blättermann mariobl@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mariobl@freenet.de AssignedTo|nobody@fedoraproject.org |mariobl@freenet.de Flag| |fedora-review+
--- Comment #1 from Mario Blättermann mariobl@freenet.de 2011-11-07 09:10:34 EST --- $ rpmlint -i -v * perl-Env-Path.noarch: I: checking perl-Env-Path.noarch: W: spelling-error %description -l en_US filesystem -> file system, file-system, systemically The value of this tag appears to be misspelled. Please double-check.
perl-Env-Path.noarch: I: checking-url http://search.cpan.org/dist/Env-Path/ (timeout 10 seconds) perl-Env-Path.src: I: checking perl-Env-Path.src: W: spelling-error %description -l en_US filesystem -> file system, file-system, systemically The value of this tag appears to be misspelled. Please double-check.
perl-Env-Path.src: I: checking-url http://search.cpan.org/dist/Env-Path/ (timeout 10 seconds) perl-Env-Path.src: I: checking-url http://www.cpan.org/authors/id/D/DS/DSB/Env-Path-0.18.tar.gz (timeout 10 seconds) perl-Env-Path.spec: I: checking-url http://www.cpan.org/authors/id/D/DS/DSB/Env-Path-0.18.tar.gz (timeout 10 seconds) 2 packages and 1 specfiles checked; 0 errors, 2 warnings.
Some ignoreable spelling errors, no further issues.
--------------------------------- key:
[+] OK [.] OK, not applicable [X] needs work ---------------------------------
[+] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name}. [+] MUST: The package must meet the Packaging Guidelines. [+] MUST: The package must be licensed with a Fedora approved license. GPL+ or Artistic [+] MUST: The License field in the package spec file must match the actual license. [.] MUST: The file containing the text of the license(s) for the package must be included in %doc. [+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [+] MUST: The sources used to build the package must match the upstream source. $ md5sum * 3be7b2f3521eb604d621f6fdf36b86da Env-Path-0.18.tar.gz 3be7b2f3521eb604d621f6fdf36b86da Env-Path-0.18.tar.gz.packaged
[+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. - Succesful Koji build available. [.] MUST: If the package does not successfully compile, build or work on an architecture, ... [+] MUST: All build dependencies must be listed in BuildRequires. [.] MUST: The spec file MUST handle locales properly. [.] MUST: If a package installs files below %{_datadir}/icons, the icon cache must be updated. [.] MUST: Packages storing shared library files (not just symlinks) must call ldconfig in %post and %postun. [.] MUST: Packages must NOT bundle copies of system libraries. [.] MUST: If the package is designed to be relocatable, ... [+] MUST: A package must own all directories that it creates. [+] MUST: A Fedora package must not list a file more than once in %files. [+] MUST: Permissions on files must be set properly. [+] MUST: Packages must not provide RPM dependency information when that information is not global in nature, or are otherwise handled. [.] MUST: When filtering automatically generated RPM dependency information, the filtering system implemented by Fedora must be used. [+] MUST: Each package must consistently use macros. [+] MUST: The package must contain code, or permissable content. [.] MUST: Large documentation files must go in a -doc subpackage. [+] MUST: Files in %doc must not affect the runtime of the application. [.] MUST: Header files must be in a -devel package. [.] MUST: Static libraries must be in a -static package. [.] MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), ... [.] MUST: devel packages must require the base package using a fully versioned dependency. [.] MUST: Packages must NOT contain any .la libtool archives. [.] MUST: Packages containing GUI applications must include a %{name}.desktop file [.] MUST: .desktop files must be properly installed with desktop-file-install in the %install section. [+] MUST: Packages must not own files or directories already owned by other packages. [+] MUST: All filenames in rpm packages must be valid UTF-8.
[.] SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream... [+] SHOULD: Timestamps of files should be preserved. [+] SHOULD: The reviewer should test that the package builds in mock. See Koji build above (which uses mock anyway) [+] SHOULD: The reviewer should test that the package functions as described. I assume the packager has tested it. Don't know how to test it on my system. [+] SHOULD: If scriptlets are used, those scriptlets must be sane. [.] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. [.] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg. [.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin ... [+] SHOULD: Your package should contain man pages for binaries/scripts.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=751531
--- Comment #2 from Mario Blättermann mariobl@freenet.de 2011-11-07 09:20:02 EST --- Oops, did forgot to mention:
PACKAGE APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=751531
--- Comment #3 from Iain Arnell iarnell@gmail.com 2011-11-07 10:25:57 EST --- New Package SCM Request ======================= Package Name: perl-Env-Path Short Description: Advanced operations on path variables Owners: iarnell Branches: f15 f16 InitialCC: perl-sig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=751531
Iain Arnell iarnell@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=751531
--- Comment #4 from Jon Ciesla limb@jcomserv.net 2011-11-07 10:53:28 EST --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=751531
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=751531
--- Comment #5 from Fedora Update System updates@fedoraproject.org 2011-11-07 11:16:01 EST --- perl-Env-Path-0.18-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/perl-Env-Path-0.18-1.fc16
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=751531
--- Comment #6 from Fedora Update System updates@fedoraproject.org 2011-11-07 11:16:10 EST --- perl-Env-Path-0.18-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/perl-Env-Path-0.18-1.fc15
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=751531
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #7 from Fedora Update System updates@fedoraproject.org 2011-11-10 12:28:24 EST --- perl-Env-Path-0.18-1.fc16 has been pushed to the Fedora 16 testing repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=751531
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |perl-Env-Path-0.18-1.fc15 Resolution| |ERRATA Last Closed| |2011-11-24 21:02:54
--- Comment #8 from Fedora Update System updates@fedoraproject.org 2011-11-24 21:02:54 EST --- perl-Env-Path-0.18-1.fc15 has been pushed to the Fedora 15 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=751531
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|perl-Env-Path-0.18-1.fc15 |perl-Env-Path-0.18-1.fc16
--- Comment #9 from Fedora Update System updates@fedoraproject.org 2011-11-24 21:14:22 EST --- perl-Env-Path-0.18-1.fc16 has been pushed to the Fedora 16 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=751531
Petr Šabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |psabata@redhat.com Flags|fedora-cvs+ |fedora-cvs?
--- Comment #10 from Petr Šabata psabata@redhat.com --- Package Change Request ====================== Package Name: perl-Env-Path New Branches: el6 epel7 Owners: georgiou InitialCC: perl-sig
I'm requesting EPEL6+ branches on behalf of georgiou from bug #1018330.
https://bugzilla.redhat.com/show_bug.cgi?id=751531
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=751531
--- Comment #11 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla