[Bug 448561] New: Review Request: xorg-x11-drv-suncg6 - X driver for suncg6

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/show_bug.cgi?id=448561

Summary: Review Request: xorg-x11-drv-suncg6 - X driver for
                    suncg6
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail],[e-mail]

Spec URL: http://ausil.us/packages/xorg-x11-drv-suncg6.spec
SRPM URL: http://ausil.us/packages/xorg-x11-drv-suncg6-1.1.0-2.fc9.src.rpm
Description: 
X driver for suncg6 hardware

[Bug 448561] Review Request: xorg-x11-drv-suncg6 - X driver for suncg6

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xorg-x11-drv-suncg6 - X driver for suncg6

https://bugzilla.redhat.com/show_bug.cgi?id=448561

------- Additional Comments From [e-mail]  2008-06-03 19:29 EST -------
scratch build http://sparc.koji.fedoraproject.org/koji/taskinfo?taskID=58925

[Bug 448561] Review Request: xorg-x11-drv-suncg6 - X driver for suncg6

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xorg-x11-drv-suncg6 - X driver for suncg6

https://bugzilla.redhat.com/show_bug.cgi?id=448561

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review+

------- Additional Comments From [e-mail]  2008-06-03 21:44 EST -------
MD5Sum:
aa6b7836fe6ccc99994bf15ff2b74e86  xf86-video-suncg6-1.1.0.tar.bz2

Good:
* Source URL is canonical
* Upstream source tarball verified
* Package name conforms to the Fedora Naming Guidelines
* Group Tag is from the official list
* Buildroot has all required elements
* All paths begin with macros
* All necessary BuildRequires listed.
* Make succeeds even when %{_smp_mflags} is defined
* Files have appropriate permissions and owners

Bad:
* rpmlint produces the following errors which should be fixed:
xorg-x11-drv-suncg6.sparc64: E: standard-dir-owned-by-package /usr/share/man/man4
xorg-x11-drv-suncg6.sparc64: E: standard-dir-owned-by-package /usr/share/man
xorg-x11-drv-suncg6.sparc64: W: invalid-license MIT/X11

Looking at the license matrix, it looks like it should just be MIT.  You can fix
this when you import this into CVS.  And the directory errors can also be fixed
at import time.

Note: I don't have the hardware to verify that this driver works, but from a
packaging standpoint this package looks fine.

+1 APPROVE.

[Bug 448561] Review Request: xorg-x11-drv-suncg6 - X driver for suncg6

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xorg-x11-drv-suncg6 - X driver for suncg6

https://bugzilla.redhat.com/show_bug.cgi?id=448561

------- Additional Comments From [e-mail]  2008-06-03 22:54 EST -------
Package Name: xorg-x11-drv-suncg6
Short Description: X driver for suncg6
Owners: ausil spot jima pjones
Branches: F-9
InitialCC:
Cvsextras Commits: yes

[Bug 448561] Review Request: xorg-x11-drv-suncg6 - X driver for suncg6

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xorg-x11-drv-suncg6 - X driver for suncg6

https://bugzilla.redhat.com/show_bug.cgi?id=448561

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs+

[Bug 448561] Review Request: xorg-x11-drv-suncg6 - X driver for suncg6

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xorg-x11-drv-suncg6 - X driver for suncg6

https://bugzilla.redhat.com/show_bug.cgi?id=448561

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |RAWHIDE

------- Additional Comments From [e-mail]  2008-06-06 17:44 EST -------
imported and built  thanks for the review