[Bug 225291] New: Merge Review: audiofile

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225291

Summary: Merge Review: audiofile
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: normal
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail]

Fedora Merge Review: audiofile

http://cvs.fedora.redhat.com/viewcvs/devel/audiofile/

[Bug 225291] Merge Review: audiofile

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: audiofile

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225291

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review?

[Bug 225291] Merge Review: audiofile

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: audiofile

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225291

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]      |[e-mail]
                 CC|                            |[e-mail]
               Flag|fedora-review?              |fedora-review-

------- Additional Comments From [e-mail]  2007-02-03 17:54 EST -------
Good:
* Source URL is canonical
* Group Tag is from the official list

Needs to be Fixed:
* rpmlint error: W: audiofile no-url-tag
* Requires for devel package should be:
 Requires: %{name} = %{epoch}:%{version}-%{release}

Minor:
* Remove the '.' from the summaries to quite rpmlint.
* Doesn't use the preferred buildroot.
http://fedoraproject.org/wiki/Packaging/Guidelines#head-f196e7b2477c2f5dd97e...
* I don't believe the 'Prereq: /sbin/ldconfig' is needed.

[Bug 225291] Merge Review: audiofile

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: audiofile

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225291

------- Additional Comments From [e-mail]  2007-02-03 21:15 EST -------
I've corrected these things in audiofile-0.2.6-6.fc7

[Bug 225291] Merge Review: audiofile

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: audiofile

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225291

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]            |[e-mail]
               Flag|fedora-review-              |fedora-review?

[Bug 225291] Merge Review: audiofile

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: audiofile

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225291

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]      |[e-mail]
               Flag|fedora-review?              |fedora-review+

------- Additional Comments From [e-mail]  2007-02-04 13:07 EST -------
Changes look good. +1 Approved

[Bug 225291] Merge Review: audiofile

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: audiofile

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225291

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium
           Priority|normal                      |medium
            Product|Fedora Extras               |Fedora

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
         Resolution|                            |CURRENTRELEASE

------- Additional Comments From [e-mail]  2007-08-10 21:29 EST -------
Review done.