Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: perl-Log-Dispatch-Perl - Use core Perl functions for logging
https://bugzilla.redhat.com/show_bug.cgi?id=463133
Summary: Review Request: perl-Log-Dispatch-Perl - Use core Perl functions for logging Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: rc040203@freenet.de QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://corsepiu.fedorapeople.org/packages/perl-Log-Dispatch-Perl.spec SRPM URL: http://corsepiu.fedorapeople.org/packages/perl-Log-Dispatch-Perl-0.03-1.fc10...
Description: The "Log::Dispatch::Perl" module offers a logging alternative using standard Perl core functions. It allows you to fall back to the common Perl alternatives for logging, such as "warn" and "cluck". It also adds the possibility for a logging action to halt the current environment, such as with "die" and "croak".
This package is a dependency of rt-3.8's "devel-mode". i.e. it's not required for ordinary run-time use of rt3, but only by people developing on rt3.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=463133
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@gmail.com AssignedTo|nobody@fedoraproject.org |panemade@gmail.com
--- Comment #1 from Parag AN(पराग) panemade@gmail.com 2008-09-22 03:48:14 EDT --- Review: + package builds in mock (rawhide i386). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=835671 - rpmlint is silent NOT for SRPM and for RPM. perl-Log-Dispatch-Perl.noarch: W: invalid-license CHECK perl-Log-Dispatch-Perl.src: W: invalid-license CHECK ==> You should change it to "GPL+ or Artistic" + source files match upstream url e23dcef192fc33f0213e4c72553b76a7 Log-Dispatch-Perl-0.03.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful! Files=1, Tests=21, 0 wallclock secs ( 0.01 usr 0.01 sys + 0.04 cusr 0.00 csys = 0.06 CPU) + Package perl-Log-Dispatch-Perl-0.03-1.fc10 => Provides: perl(Log::Dispatch::Perl) = 0.03 Requires: perl(base) perl(strict)
Suggestions:- I see license for this package is "GPL+ or Artistic", but you listed as CHECK(GPL+ or Artistic) ?
Do you see any issues with license here?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=463133
--- Comment #2 from Ralf Corsepius rc040203@freenet.de 2008-09-22 04:03:21 EDT --- (In reply to comment #1)
Do you see any issues with license here?
Nope. This was an oversight.
cpanspec had added it and I missed to adjust it.
Update:
Spec URL: http://corsepiu.fedorapeople.org/packages/perl-Log-Dispatch-Perl.spec SRPM URL: http://corsepiu.fedorapeople.org/packages/perl-Log-Dispatch-Perl-0.03-2.fc10...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=463133
--- Comment #3 from Parag AN(पराग) panemade@gmail.com 2008-09-22 04:22:02 EDT --- APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=463133
--- Comment #4 from Ralf Corsepius rc040203@freenet.de 2008-09-22 04:31:25 EDT --- New Package CVS Request ======================= Package Name: perl-Log-Dispatch-Perl Short Description: Use core Perl functions for logging Owners: corsepiu Branches: F-9 F-8 InitialCC: perl-sig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=463133
Ralf Corsepius rc040203@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |459536
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=463133
--- Comment #5 from Huzaifa S. Sidhpurwala huzaifas@redhat.com 2008-09-22 05:33:21 EDT --- cvs done
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=463133
Ralf Corsepius rc040203@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |huzaifas@redhat.com
--- Comment #6 from Ralf Corsepius rc040203@freenet.de 2008-09-22 05:58:41 EDT --- I am unable to check in/cvs-import to any of the repositories you've created.
*** Access denied: corsepiu is not in ACL for rpms/perl-Log-Dispatch-Perl/devel cvs commit: Pre-commit check failed **** Access denied: corsepiu is not in ACL for rpms/perl-Log-Dispatch-Perl/F-8 cvs commit: Pre-commit check failed **** Access denied: corsepiu is not in ACL for rpms/perl-Log-Dispatch-Perl/F-9 cvs commit: Pre-commit check failed cvs [commit aborted]: correct above errors first!
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=463133
--- Comment #7 from Huzaifa S. Sidhpurwala huzaifas@redhat.com 2008-09-22 06:09:55 EDT --- hmm really strange, can you try this once more please. Most of the packages with perl-sig in the cc list are ok, I wondering what went wrong with this.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=463133
--- Comment #8 from Ralf Corsepius rc040203@freenet.de 2008-09-22 06:28:12 EDT --- (In reply to comment #7)
hmm really strange, can you try this once more please.
More strange was the fact that adding the *.gz to the lookaside cache had worked, while the "cvs commit" failed :/
I wondering what went wrong with this.
No idea :-)
Now, "cvs commit" below perl-Log-Dispatch-Perl worked. I will try to cvs-import the other packages soon.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=463133
--- Comment #9 from Ralf Corsepius rc040203@freenet.de 2008-09-22 06:55:21 EDT --- The crazyness continues:
Now bodhi's web GUI doesn't offer the F-9/F-8 packages which just completed.
Commandline "make bodhi" bombs out with this error: ... Traceback (most recent call last): File "/usr/bin/bodhi", line 5, in <module> from pkg_resources import load_entry_point File "/usr/lib/python2.5/site-packages/pkg_resources.py", line 2561, in <module> working_set.require(__requires__) File "/usr/lib/python2.5/site-packages/pkg_resources.py", line 626, in require needed = self.resolve(parse_requirements(requirements)) File "/usr/lib/python2.5/site-packages/pkg_resources.py", line 524, in resolve raise DistributionNotFound(req) # XXX put more info here pkg_resources.DistributionNotFound: bodhi==0.5.0
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=463133
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2008-09-22 08:10:11 EDT --- perl-Log-Dispatch-Perl-0.03-2.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/perl-Log-Dispatch-Perl-0.03-2.fc9
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=463133
--- Comment #11 from Fedora Update System updates@fedoraproject.org 2008-09-22 08:12:02 EDT --- perl-Log-Dispatch-Perl-0.03-2.fc8 has been submitted as an update for Fedora 8. http://admin.fedoraproject.org/updates/perl-Log-Dispatch-Perl-0.03-2.fc8
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=463133
--- Comment #12 from Fedora Update System updates@fedoraproject.org 2008-09-24 20:02:48 EDT --- perl-Log-Dispatch-Perl-0.03-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=463133
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=463133
--- Comment #13 from Fedora Update System updates@fedoraproject.org 2008-09-24 20:18:57 EDT --- perl-Log-Dispatch-Perl-0.03-2.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=463133
Mark Chappell tremble@tremble.org.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |tremble@tremble.org.uk Flag|fedora-cvs+ |fedora-cvs?
--- Comment #14 from Mark Chappell tremble@tremble.org.uk 2010-06-18 12:47:16 EDT --- corsepiu is listed as not interested in EPEL
Package Change Request ====================== Package Name: perl-Log-Dispatch-Perl New Branches: EL-6 Owners: tremble
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=463133
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #15 from Kevin Fenzi kevin@tummy.com 2010-06-20 21:51:45 EDT --- cvs done.
package-review@lists.fedoraproject.org