https://bugzilla.redhat.com/show_bug.cgi?id=1251136
Bug ID: 1251136 Summary: Review Request: qpid-tests - Conformance tests for Apache Qpid Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: iboverma@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: qpid-tests.spec (attached) SRPM URL: qpid-tests-0.32-1.el7.src.rpm (attached)
Fedora Account System Username: irina
https://bugzilla.redhat.com/show_bug.cgi?id=1251136
Irina Boverman iboverma@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment| |review? #1059976 Flags| |
--- Comment #1 from Irina Boverman iboverma@redhat.com --- Created attachment 1059976 --> https://bugzilla.redhat.com/attachment.cgi?id=1059976&action=edit Package spec file
https://bugzilla.redhat.com/show_bug.cgi?id=1251136
--- Comment #2 from Irina Boverman iboverma@redhat.com --- Created attachment 1059977 --> https://bugzilla.redhat.com/attachment.cgi?id=1059977&action=edit source rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1251136
Irina Boverman iboverma@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? | |fedora_requires_release_not | |e? fedora-cvs?
https://bugzilla.redhat.com/show_bug.cgi?id=1251136
Irina Boverman iboverma@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |
https://bugzilla.redhat.com/show_bug.cgi?id=1251136
Irina Boverman iboverma@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1251146
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1251146 [Bug 1251146] Re-organise qpid-cpp package, un-retire python-qpid package, add qpid-tools and qpid-tests packages.
https://bugzilla.redhat.com/show_bug.cgi?id=1251136
--- Comment #3 from Jon Ciesla limburgher@gmail.com --- No SCM request found.
https://bugzilla.redhat.com/show_bug.cgi?id=1251136
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |
https://bugzilla.redhat.com/show_bug.cgi?id=1251136
Irina Boverman iboverma@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |aconway@redhat.com Flags| |fedora-review+
https://bugzilla.redhat.com/show_bug.cgi?id=1251136
Irina Boverman iboverma@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment|0 |1 #1059977 is| | obsolete| |
--- Comment #4 from Irina Boverman iboverma@redhat.com --- Created attachment 1062811 --> https://bugzilla.redhat.com/attachment.cgi?id=1062811&action=edit source rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1251136
Irina Boverman iboverma@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment|0 |1 #1059976 is| | obsolete| | Attachment|review? | #1059976 Flags| |
--- Comment #5 from Irina Boverman iboverma@redhat.com --- Created attachment 1062812 --> https://bugzilla.redhat.com/attachment.cgi?id=1062812&action=edit Package spec file
https://bugzilla.redhat.com/show_bug.cgi?id=1251136
--- Comment #7 from Alan Conway aconway@redhat.com --- I give this a pass. There are two failed SHOULD items, I don't know how important they are but I suspect not very.
Issues: ======= - Package contains BR: python2-devel or python3-devel
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* Apache (v2.0)". Detailed output of licensecheck in /home/aconway/tmp/review/review-qpid-tests/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [x]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [!]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: qpid-tests-0.32-1.fc24.noarch.rpm qpid-tests-0.32-1.fc24.src.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings.
Rpmlint (installed packages) ---------------------------- 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Requires -------- qpid-tests (rpmlib, GLIBC filtered): python(abi) python-qpid python-qpid-qmf
Provides -------- qpid-tests: qpid-tests
Source checksums ---------------- http://www.apache.org/dist/qpid/0.32/qpid-tests-0.32.tar.gz : CHECKSUM(SHA256) this package : bb4c8fa15021730cb00c3580a6b0abf666c875fd71fed42c26fa9ed4e6e8cdfb CHECKSUM(SHA256) upstream package : bb4c8fa15021730cb00c3580a6b0abf666c875fd71fed42c26fa9ed4e6e8cdfb
Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -n qpid-tests Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
https://bugzilla.redhat.com/show_bug.cgi?id=1251136
Irina Boverman iboverma@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #8 from Irina Boverman iboverma@redhat.com --- New Package SCM Request ======================= Package Name: qpid-tests Short Description: Conformance tests for Apache Qpid Upstream URL: http://qpid.apache.org Owners: irina Branches: f23 epel7 InitialCC: irina
https://bugzilla.redhat.com/show_bug.cgi?id=1251136
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=1251136
--- Comment #9 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=1251136
Pete Travis me@petetravis.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |me@petetravis.com Flags|fedora_requires_release_not | |e? |
https://bugzilla.redhat.com/show_bug.cgi?id=1251136
Alan Conway aconway@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |EOL Last Closed| |2016-04-07 11:34:13
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla