[Bug 2246724] New: Review Request: rust-h3-quinn - QUIC transport implementation based on Quinn

https://bugzilla.redhat.com/show_bug.cgi?id=2246724

            Bug ID: 2246724
           Summary: Review Request: rust-h3-quinn - QUIC transport
                    implementation based on Quinn
           Product: Fedora
           Version: rawhide
            Status: NEW
         Component: Package Review
          Assignee: nobody(a)fedoraproject.org
          Reporter: decathorpe(a)gmail.com
        QA Contact: extras-qa(a)fedoraproject.org
                CC: package-review(a)lists.fedoraproject.org
  Target Milestone: ---
    Classification: Fedora



Spec URL: https://decathorpe.fedorapeople.org/rust-h3-quinn.spec
SRPM URL:
https://decathorpe.fedorapeople.org/rust-h3-quinn-0.0.3-1.fc39.src.rpm

Description:
QUIC transport implementation based on Quinn.

Fedora Account System Username: decathorpe


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2246724

Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...

[Bug 2246724] Review Request: rust-h3-quinn - QUIC transport implementation based on Quinn

https://bugzilla.redhat.com/show_bug.cgi?id=2246724



--- Comment #1 from Fedora Review Service <fedora-review-bot(a)fedoraproject.org&gt; ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6577375
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-...

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2246724

Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...

[Bug 2246724] Review Request: rust-h3-quinn - QUIC transport implementation based on Quinn

https://bugzilla.redhat.com/show_bug.cgi?id=2246724
Bug 2246724 depends on bug 2246720, which changed state.

Bug 2246720 Summary: Review Request: rust-h3 - Async HTTP/3 implementation
https://bugzilla.redhat.com/show_bug.cgi?id=2246720

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |CLOSED
         Resolution|---                         |RAWHIDE




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2246724

[Bug 2246724] Review Request: rust-h3-quinn - QUIC transport implementation based on Quinn

https://bugzilla.redhat.com/show_bug.cgi?id=2246724
Bug 2246724 depends on bug 2246723, which changed state.

Bug 2246723 Summary: Review Request: rust-quinn - Versatile QUIC transport protocol
implementation
https://bugzilla.redhat.com/show_bug.cgi?id=2246723

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |CLOSED
         Resolution|---                         |RAWHIDE




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2246724

[Bug 2246724] Review Request: rust-h3-quinn - QUIC transport implementation based on Quinn

https://bugzilla.redhat.com/show_bug.cgi?id=2246724



--- Comment #2 from Fabio Valentini <decathorpe(a)gmail.com&gt; ---
koji scratch build for rawhide:
https://koji.fedoraproject.org/koji/taskinfo?taskID=108384779


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2246724

Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...

[Bug 2246724] Review Request: rust-h3-quinn - QUIC transport implementation based on Quinn

https://bugzilla.redhat.com/show_bug.cgi?id=2246724

blinxen <h-k-81(a)hotmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review+
                 CC|                            |h-k-81(a)hotmail.com
           Assignee|nobody(a)fedoraproject.org    |h-k-81(a)hotmail.com
             Status|NEW                         |POST



--- Comment #3 from blinxen <h-k-81(a)hotmail.com&gt; ---
Taking this review

General comments:

- Package was generated with rust2rpm
- Missing license file was added manually (upstream PR for including license
file in the next release is already merged)
- A new version has been published in the mean time, please update as soon as
possible

APPROVED

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
     Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. No licenses
     found. Please check the source files for licenses manually.
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     rust-h3-quinn-devel , rust-h3-quinn+default-devel
[x]: Package functions as described.
[!]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.


Rpmlint
-------
Checking: rust-h3-quinn-devel-0.0.3-1.fc40.noarch.rpm
          rust-h3-quinn+default-devel-0.0.3-1.fc40.noarch.rpm
          rust-h3-quinn-0.0.3-1.fc40.src.rpm
============================ rpmlint session starts
============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp389lb45p')]
checks: 31, packages: 3

rust-h3-quinn+default-devel.noarch: W: no-documentation
 3 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken
0.1 s




Rpmlint (installed packages)
----------------------------
(none): E: there is no installed rpm "rust-h3-quinn-devel".
(none): E: there is no installed rpm "rust-h3-quinn+default-devel".
There are no files to process nor additional arguments.
Nothing to do, aborting.
============================ rpmlint session starts
============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 2

 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken
0.0 s



Source checksums
----------------
https://github.com/hyperium/h3/raw/h3-quinn-v0.0.3/LICENSE :
  CHECKSUM(SHA256) this package     :
a0d039cdafe68f363893abddb5e4d50dbe6f8b56611e2650aaab4237103285f1
  CHECKSUM(SHA256) upstream package :
a0d039cdafe68f363893abddb5e4d50dbe6f8b56611e2650aaab4237103285f1
https://crates.io/api/v1/crates/h3-quinn/0.0.3/download#/h3-quinn-0.0.3.c... :
  CHECKSUM(SHA256) this package     :
2d4a1a1763e4f3e82ee9f1ecf2cf862b22cc7316ebe14684e42f94532b5ec64d
  CHECKSUM(SHA256) upstream package :
2d4a1a1763e4f3e82ee9f1ecf2cf862b22cc7316ebe14684e42f94532b5ec64d


Requires
--------
rust-h3-quinn-devel (rpmlib, GLIBC filtered):
    (crate(bytes/default) >= 1.0.0 with crate(bytes/default) < 2.0.0~)
    (crate(futures/default) >= 0.3.27 with crate(futures/default) < 0.4.0~)
    (crate(quinn) >= 0.10.0 with crate(quinn) < 0.11.0~)
    (crate(quinn-proto) >= 0.10.0 with crate(quinn-proto) < 0.11.0~)
    (crate(tokio-util/default) >= 0.7.7 with crate(tokio-util/default) <
0.8.0~)
    cargo
    crate(h3/default)
    rust

rust-h3-quinn+default-devel (rpmlib, GLIBC filtered):
    cargo
    crate(h3-quinn)



Provides
--------
rust-h3-quinn-devel:
    crate(h3-quinn)
    rust-h3-quinn-devel

rust-h3-quinn+default-devel:
    crate(h3-quinn/default)
    rust-h3-quinn+default-devel



Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name
rust-h3-quinn --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, Generic
Disabled plugins: fonts, SugarActivity, Python, Java, PHP, C/C++, R, Perl,
Ocaml, Haskell
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2246724

Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...

[Bug 2246724] Review Request: rust-h3-quinn - QUIC transport implementation based on Quinn

https://bugzilla.redhat.com/show_bug.cgi?id=2246724



--- Comment #4 from Fabio Valentini <decathorpe(a)gmail.com&gt; ---
Thanks for the review!
I'll update the package as soon as reqwest is compatible with the latest
version.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2246724

Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...

[Bug 2246724] Review Request: rust-h3-quinn - QUIC transport implementation based on Quinn

https://bugzilla.redhat.com/show_bug.cgi?id=2246724



--- Comment #5 from Fedora Admin user for bugzilla script actions
<fedora-admin-xmlrpc(a)fedoraproject.org&gt; ---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-h3-quinn


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2246724

Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...

[Bug 2246724] Review Request: rust-h3-quinn - QUIC transport implementation based on Quinn

https://bugzilla.redhat.com/show_bug.cgi?id=2246724

Fabio Valentini <decathorpe(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |CLOSED
   Fixed In Version|                            |rust-h3-quinn-0.0.3-1.fc40
         Resolution|---                         |RAWHIDE
        Last Closed|                            |2023-11-06 13:34:38



--- Comment #6 from Fabio Valentini <decathorpe(a)gmail.com&gt; ---
Imported and built:
https://bodhi.fedoraproject.org/updates/FEDORA-2023-75720ad614


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2246724

Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...