Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225880
Summary: Merge Review: hal Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: nobody@fedoraproject.org QAContact: fedora-package-review@redhat.com CC: davidz@redhat.com
Fedora Merge Review: hal
http://cvs.fedora.redhat.com/viewcvs/devel/hal/ Initial Owner: davidz@redhat.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: hal
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225880
------- Additional Comments From rc040203@freenet.de 2007-02-02 03:28 EST ------- MUSTFIX: - package must not own /usr/share/locale/* and /usr/share/locale/*/LC_MESSAGES
Package should use %find_lang
- Source0 is not an absolute URL
- *-devel contains *.pc => Requires: pkgconfig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: hal
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225880
tcallawa@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- BugsThisDependsOn| |161548
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: hal
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225880
Bug 225880 depends on bug 161548, which changed state.
Bug 161548 Summary: Hal owns directories that it should not own https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=161548
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |RAWHIDE Status|ASSIGNED |CLOSED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: hal
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225880
mclasen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|davidz@redhat.com |rc040203@freenet.de Flag|fedora-review- |fedora-review?
------- Additional Comments From mclasen@redhat.com 2007-02-03 22:45 EST ------- Fixed in hal-0.5.8.1-8.fc7
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: hal
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225880
pertusus@free.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |pertusus@free.fr
------- Additional Comments From pertusus@free.fr 2007-02-18 09:17 EST ------- Issues:
* use RPM_BUILD_ROOT or buildroot
* BuildRequires: perl-XML-Parser should certainly be replaced by BuildRequires: perl(XML::Parser)
* Missing Requires(post): /sbin/ldconfig Requires(pre): /usr/sbin/useradd Requires(postun): gawk, grep, coreutils, /sbin/ldconfig I guessed that triggerpostun is associated with Requires(postun), maybe this is wrong.
* There are no static libraries, the -devel %description should be updated
* /etc/dbus-1/system.d/hal.conf should certainly be %config(noreplace)
* Why is %doc commented out? And also %{_datadir}/doc/hal-%{version}/conf/* seems wrong to me but it's not completely obvious.
* remove Application; X-Red-Hat-Base; from desktop file Categories remove X-Desktop-File-Install-Version=0.10 from desktop file
* --vendor should be fedora and not redhat. There is a cryptic comment saying that it shouldn't change during release but I guess we are between releases...
* shouldn't hal-info be put in another package?
Suggestions:
* replace %defattr(-,root,root) with %defattr(-,root,root,-)
* replace cp -f %{SOURCE1} $RPM_BUILD_ROOT%{_datadir}/hal/fdi/policy/10osvendor/ with cp -p %{SOURCE1} $RPM_BUILD_ROOT%{_datadir}/hal/fdi/policy/10osvendor/
There is an issue of directory ownership for /usr/share/gtk-doc/html/, but it is not obvious how to solve it.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: hal
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225880
------- Additional Comments From davidz@redhat.com 2007-02-18 19:25 EST ------- In response to comment 3:
I've fixed most of this except making /etc/dbus-1/system.d/hal.conf %config(noreplace). I've made it %config however as /etc/dbus-1/system.d/hal.conf isn't a configuration at all; however some developers like to tweak it around and as such their changes will be saved as .rpmsave.
I've also cleaned up the %files sections of the spec file - please review if I broke anything and if you think the spec file looks good now. Thanks.
This will appear in tomorrows Rawhide and I've uploaded the spec file and SRPM here
http://people.redhat.com/davidz/hal.spec http://people.redhat.com/davidz/hal-0.5.9-0.git20070218.fc7.src.rpm
Thanks for reviewing this.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: hal
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225880
------- Additional Comments From pertusus@free.fr 2007-02-19 18:51 EST ------- (In reply to comment #4)
In response to comment 3:
I've fixed most of this except making /etc/dbus-1/system.d/hal.conf %config(noreplace). I've made it %config however as /etc/dbus-1/system.d/hal.conf isn't a configuration at all;
It defines the security policy of HAL, it is an obvious config file. You may prefer to keep it under the packager responsibility, but it is a config file. I am personally fine with having this file %config, seems like a good compromise.
I think that %{_sysconfdir}/rc.d/init.d/haldaemon shouldn't be %config. Maybe you could use %_initrddir for that file.
The Application category in .desktop file is deprecated.
What about putting hal-info in another package?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: hal
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225880
rc040203@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|rc040203@freenet.de |nobody@fedoraproject.org
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: hal
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225880
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium
------- Additional Comments From mclasen@redhat.com 2007-06-17 01:02 EST ------- hal-info is a separate package by now; I agree that the invalid Application category should be removed fron the desktop file; should probably be fixed upstream though, not worth carrying a patch for.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: hal
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225880
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Product|Fedora Extras |Fedora
------- Additional Comments From mclasen@redhat.com 2007-08-10 23:26 EST ------- The hal-gnome package (and with it the desktop file) is gone now.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=225880
Nicola Soranzo nsoranzo@tiscali.it changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED CC| |nsoranzo@tiscali.it Resolution| |WONTFIX Last Closed| |2011-04-21 05:48:29
--- Comment #8 from Nicola Soranzo nsoranzo@tiscali.it 2011-04-21 05:48:29 EDT --- Hal has been deprecated in rawhide today, so I'm closing this Merge Review as WONTFIX.
package-review@lists.fedoraproject.org