https://bugzilla.redhat.com/show_bug.cgi?id=1739133
Bug ID: 1739133 Summary: Review Request: opensbi - RISC-V Open Source Supervisor Binary Interface (OpenSBI) Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: rjones@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: http://oirase.annexia.org/reviews/opensbi/opensbi.spec SRPM URL: http://oirase.annexia.org/reviews/opensbi/opensbi-0.4-1.gitc1b9dd3a.fc30.src... Description: RISC-V Open Source Supervisor Binary Interface (OpenSBI) Fedora Account System Username:
https://bugzilla.redhat.com/show_bug.cgi?id=1739133
--- Comment #1 from Richard W.M. Jones rjones@redhat.com --- Spec URL: http://oirase.annexia.org/reviews/opensbi/opensbi.spec SRPM URL: http://oirase.annexia.org/reviews/opensbi/opensbi-0.4-1.gitc1b9dd3a.fc30.src... Description: RISC-V Open Source Supervisor Binary Interface (OpenSBI) Fedora Account System Username: rjones
https://bugzilla.redhat.com/show_bug.cgi?id=1739133
--- Comment #2 from Richard W.M. Jones rjones@redhat.com --- Scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=36862762
https://bugzilla.redhat.com/show_bug.cgi?id=1739133
Paolo Bonzini pbonzini@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |pbonzini@redhat.com
--- Comment #3 from Paolo Bonzini pbonzini@redhat.com --- Please install the files in /usr/share rather than /usr/lib.
Can the .a files be used in a Linux program or are they used to build more firmware? If the former, they should probably reside in /usr/lib and in a riscv package. If the latter, they should be in a noarch package and should stay in /usr/share.
Either way, binaries that are used by QEMU should be in a subpackage.
https://bugzilla.redhat.com/show_bug.cgi?id=1739133
--- Comment #4 from Richard W.M. Jones rjones@redhat.com --- The new package does install the files in /usr/share/opensbi:
$ rpm -qlp ~/rpmbuild/RPMS/noarch/opensbi-0.4-1.gitc1b9dd3a.fc30.noarch.rpm /usr/share/opensbi /usr/share/opensbi/opensbi-riscv64-sifive_u-fw_jump.bin /usr/share/opensbi/opensbi-riscv64-virt-fw_jump.bin
It will require us to add symlinks from /usr/share/qemu into the qemu package.
Good point about the lib*.a files. I forgot that they're RISC-V libraries. I'm not totally sure why we would need to package them (or the header files). I wonder if we should just drop the -devel package altogether. David?
Product: Fedora Version: rawhide Component: Package Review
Package Review package-review@lists.fedoraproject.org has canceled Package Review package-review@lists.fedoraproject.org's request for Richard W.M. Jones rjones@redhat.com's needinfo: Bug 1739133: Review Request: opensbi - RISC-V Open Source Supervisor Binary Interface (OpenSBI) https://bugzilla.redhat.com/show_bug.cgi?id=1739133
--- Comment #6 from Package Review package-review@lists.fedoraproject.org --- This is an automatic action taken by review-stats script.
The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it.
https://bugzilla.redhat.com/show_bug.cgi?id=1739133
Itamar Reis Peixoto itamar@ispbrasil.com.br changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |NEW CC| |itamar@ispbrasil.com.br Resolution|NOTABUG |--- Flags| |needinfo?(rjones@redhat.com | |) Keywords| |Reopened
--- Comment #7 from Itamar Reis Peixoto itamar@ispbrasil.com.br --- lets finish this.
https://bugzilla.redhat.com/show_bug.cgi?id=1739133
Richard W.M. Jones rjones@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(rjones@redhat.com | |) |
--- Comment #8 from Richard W.M. Jones rjones@redhat.com --- Unsetting NEEDINFO. I discussed this bug with David Abdurachmanov last week and we will attempt to add this package soon, and at a later version.
https://bugzilla.redhat.com/show_bug.cgi?id=1739133
Richard W.M. Jones rjones@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Flags|needinfo?(rjones@redhat.com | |) | Status|NEW |CLOSED Last Closed|2020-09-08 00:45:20 |2021-09-20 09:26:06
--- Comment #10 from Richard W.M. Jones rjones@redhat.com --- I'm going to close this as I'm not sure if we really need it. qemu is currently shipping the required firmware.
However in case anyone takes it over I have left my latest work on this package here:
http://git.annexia.org/?p=fedora-reviews.git;a=tree;f=opensbi
Product: Fedora Version: rawhide Component: Package Review
Richard W.M. Jones rjones@redhat.com has canceled Package Review package-review@lists.fedoraproject.org's request for Richard W.M. Jones rjones@redhat.com's needinfo: Bug 1739133: Review Request: opensbi - RISC-V Open Source Supervisor Binary Interface (OpenSBI) https://bugzilla.redhat.com/show_bug.cgi?id=1739133
--- Comment #10 from Richard W.M. Jones rjones@redhat.com --- I'm going to close this as I'm not sure if we really need it. qemu is currently shipping the required firmware.
However in case anyone takes it over I have left my latest work on this package here:
http://git.annexia.org/?p=fedora-reviews.git;a=tree;f=opensbi
package-review@lists.fedoraproject.org