https://bugzilla.redhat.com/show_bug.cgi?id=2253490
Bug ID: 2253490 Summary: Review Request: akonadi-server - PIM Storage Service Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: farchord@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://farchord.fedorapeople.org/reviews/akonadi-server/akonadi-server.spec SRPM URL: https://farchord.fedorapeople.org/reviews/akonadi-server/akonadi-server-24.0...
Description: PIM Storage Service.
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=110009217
https://bugzilla.redhat.com/show_bug.cgi?id=2253490
Steve Cossette farchord@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Comment|0 |updated
--- Comment #0 has been edited ---
Spec URL: https://farchord.fedorapeople.org/reviews/akonadi-server/akonadi-server.spec SRPM URL: https://farchord.fedorapeople.org/reviews/akonadi-server/akonadi-server-24.0...
Description: PIM Storage Service.
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=110009217
Fedora Account System Username: farchord
https://bugzilla.redhat.com/show_bug.cgi?id=2253490
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://invent.kde.org/fram | |eworks/akonadi
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6731988 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2253490
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value CC| |ngompa13@gmail.com Status|NEW |ASSIGNED Flags| |fedora-review? Assignee|nobody@fedoraproject.org |ngompa13@gmail.com
--- Comment #2 from Neal Gompa ngompa13@gmail.com --- Taking this review.
https://bugzilla.redhat.com/show_bug.cgi?id=2253490
--- Comment #3 from Neal Gompa ngompa13@gmail.com --- Spec review:
# trim changelog included in binary rpms %global _changelog_trimtime %(date +%s -d "1 year ago")
This can be dropped. We have a global setting in redhat-rpm-config now.
%global mysql mysql %if 0%{?rhel} > 6 # el7 mariadb pkgs don't have compat Provides: mysql (apparently?) %global mysql mariadb %endif
This can be dropped and we can just depend on mysql directly.
Conflicts: akonadi < 1.13.0-100
# translations moved here Conflicts: kde-l10n < 17.03
# when kf5-akonadi was split, -socialutils was dropped Obsoletes: kf5-akonadi-socialutils < 16.07
This can be dropped.
Obsoletes: kf5-akonadi-devel < 16.03 # when kf5-akonadi was split, -socialutils was dropped Obsoletes: kf5-akonadi-socialutils-devel < 16.07
This can be dropped.
# at least dbus-1/interfaces conflict, maybe more -- rex Conflicts: akonadi-devel
We also need a "Conflicts: kf5-akonadi-server-devel" here.
# upgrade path Obsoletes: akonadi < 1.7.90-2 Obsoletes: akonadi-mysql < 15.08.0
This can be dropped.
%if "%{?mysql}" != "mariadb" && 0%{?fedora} > 20 Recommends: mariadb-server %endif
This can be dropped. We'll depend on "mysql-server".
https://bugzilla.redhat.com/show_bug.cgi?id=2253490
--- Comment #4 from Steve Cossette farchord@gmail.com --- Spec URL: https://farchord.fedorapeople.org/reviews/akonadi-server/akonadi-server.spec SRPM URL: https://farchord.fedorapeople.org/reviews/akonadi-server/akonadi-server-24.0...
Updated with requested spec changes
https://bugzilla.redhat.com/show_bug.cgi?id=2253490
--- Comment #5 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2003141 --> https://bugzilla.redhat.com/attachment.cgi?id=2003141&action=edit The .spec file difference from Copr build 6731988 to 6732193
https://bugzilla.redhat.com/show_bug.cgi?id=2253490
--- Comment #6 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6732193 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2253490
--- Comment #7 from Steve Cossette farchord@gmail.com --- Spec URL: https://farchord.fedorapeople.org/reviews/akonadi-server/akonadi-server.spec SRPM URL: https://farchord.fedorapeople.org/reviews/akonadi-server/akonadi-server-24.0...
Updated
https://bugzilla.redhat.com/show_bug.cgi?id=2253490
--- Comment #8 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2003144 --> https://bugzilla.redhat.com/attachment.cgi?id=2003144&action=edit The .spec file difference from Copr build 6732193 to 6732237
https://bugzilla.redhat.com/show_bug.cgi?id=2253490
--- Comment #9 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6732237 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2253490
--- Comment #10 from Steve Cossette farchord@gmail.com --- New scratch build link: https://koji.fedoraproject.org/koji/taskinfo?taskID=110023409
https://bugzilla.redhat.com/show_bug.cgi?id=2253490
--- Comment #11 from Steve Cossette farchord@gmail.com --- Spec URL: https://farchord.fedorapeople.org/reviews/akonadi-server/akonadi-server.spec SRPM URL: https://farchord.fedorapeople.org/reviews/akonadi-server/akonadi-server-24.0...
Updated devel runtime reqs
https://bugzilla.redhat.com/show_bug.cgi?id=2253490
--- Comment #12 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2003152 --> https://bugzilla.redhat.com/attachment.cgi?id=2003152&action=edit The .spec file difference from Copr build 6732237 to 6732296
https://bugzilla.redhat.com/show_bug.cgi?id=2253490
--- Comment #13 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6732296 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2253490
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #14 from Neal Gompa ngompa13@gmail.com --- Review notes:
* Package follows Fedora Packaging Guidelines * Package builds and installs * Package licensing is correctly handled * No serious issues from rpmlint
PACKAGE APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=2253490
--- Comment #15 from Steve Cossette farchord@gmail.com --- Thank you for the review, Neal
https://bugzilla.redhat.com/show_bug.cgi?id=2253490
--- Comment #16 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/akonadi-server
https://bugzilla.redhat.com/show_bug.cgi?id=2253490
Steve Cossette farchord@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |RAWHIDE Status|POST |CLOSED Last Closed| |2023-12-07 21:40:51
package-review@lists.fedoraproject.org