Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=399721
Summary: Review Request: fusion icon - Compiz Fusion panel applet Product: Fedora Version: devel Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: karlikt@gmail.com QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com
Spec URL: http://karlik.nonlogic.org/fusion-icon/fusion-icon.spec SRPM URL: http://karlik.nonlogic.org/fusion-icon/fusion-icon-0-0.1.20071126git.fc8.src... Description: The Compiz Fusion Icon is a simple panel applet for starting and controlling Compiz Fusion. Upon launch, it will attempt to start Compiz Fusion automatically. You may need to select a window decorator, if one does not appear.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: fusion icon - Compiz Fusion panel applet
https://bugzilla.redhat.com/show_bug.cgi?id=399721
panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |panemade@gmail.com Status|NEW |ASSIGNED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: fusion icon - Compiz Fusion panel applet
https://bugzilla.redhat.com/show_bug.cgi?id=399721
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|devel |rawhide
------- Additional Comments From panemade@gmail.com 2007-12-01 08:01 EST ------- rpmlint reported fusion-icon.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/FusionIcon/data.py 0644 fusion-icon.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/FusionIcon/interface.py 0644 fusion-icon.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/FusionIcon/start.py 0644 fusion-icon.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/FusionIcon/parser.py 0644 fusion-icon.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/FusionIcon/execute.py 0644 fusion-icon.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/FusionIcon/environment.py 0644 fusion-icon.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/FusionIcon/__init__.py 0644 fusion-icon.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/FusionIcon/util.py 0644 fusion-icon-gtk.noarch: W: no-documentation fusion-icon-gtk.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/FusionIcon/interface_gtk/main.py 0644 fusion-icon-gtk.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/FusionIcon/interface_gtk/__init__.py 0644 fusion-icon-qt.noarch: W: no-documentation fusion-icon-qt.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/FusionIcon/interface_qt4/main.py 0644 fusion-icon-qt.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/FusionIcon/interface_qt4/__init__.py 0644
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: fusion icon - Compiz Fusion panel applet
https://bugzilla.redhat.com/show_bug.cgi?id=399721
------- Additional Comments From karlikt@gmail.com 2007-12-01 11:02 EST ------- I think it might be ignored, because these scripts are only included by "core" and fusion-icon doesn't require chmod +x to work. If it is blocking the approving, I can set +x. "no-documentation" can be ignored because of needing core package.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: fusion icon - Compiz Fusion panel applet
https://bugzilla.redhat.com/show_bug.cgi?id=399721
------- Additional Comments From panemade@gmail.com 2007-12-03 01:48 EST ------- Being the reviewer here and in my opinion rpmlint errors reported above are safe to ignore.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: fusion icon - Compiz Fusion panel applet
https://bugzilla.redhat.com/show_bug.cgi?id=399721
------- Additional Comments From panemade@gmail.com 2007-12-03 01:55 EST ------- source is not matching upstream. do you want to keep logs directory that is producing difference or can you remove them?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: fusion icon - Compiz Fusion panel applet
https://bugzilla.redhat.com/show_bug.cgi?id=399721
panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: fusion icon - Compiz Fusion panel applet
https://bugzilla.redhat.com/show_bug.cgi?id=399721
------- Additional Comments From karlikt@gmail.com 2007-12-03 09:42 EST ------- If it is a problem I can remove .git before taring but in the next release if it is not a problem for reviewing.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: fusion icon - Compiz Fusion panel applet
https://bugzilla.redhat.com/show_bug.cgi?id=399721
panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From panemade@gmail.com 2007-12-03 11:44 EST ------- no problem for now but take care to remove them from next release please. Review: + package builds in mock (development i386). + rpmlint is silent for SRPM. - rpmlint complains follwing messages on RPMS fusion-icon.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/FusionIcon/data.py 0644 fusion-icon.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/FusionIcon/interface.py 0644 fusion-icon.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/FusionIcon/start.py 0644 fusion-icon.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/FusionIcon/parser.py 0644 fusion-icon.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/FusionIcon/execute.py 0644 fusion-icon.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/FusionIcon/environment.py 0644 fusion-icon.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/FusionIcon/__init__.py 0644 fusion-icon.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/FusionIcon/util.py 0644 fusion-icon-gtk.noarch: W: no-documentation fusion-icon-gtk.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/FusionIcon/interface_gtk/main.py 0644 fusion-icon-gtk.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/FusionIcon/interface_gtk/__init__.py 0644 fusion-icon-qt.noarch: W: no-documentation fusion-icon-qt.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/FusionIcon/interface_qt4/main.py 0644 fusion-icon-qt.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/FusionIcon/interface_qt4/__init__.py 0644 + source files match upstream with assumptions that logs will differ dd4c1c967fe4bb1282801e22bb43fa41 fusion-icon-20071126.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists but -gtk and -qt subpackages present. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + gtk-update-icon-cache scriptlets are used. + Desktop file installed correctly. + GUI app.
APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: fusion icon - Compiz Fusion panel applet
https://bugzilla.redhat.com/show_bug.cgi?id=399721
------- Additional Comments From karlikt@gmail.com 2007-12-03 13:14 EST ------- Thanks for review and approve.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: fusion icon - Compiz Fusion panel applet
https://bugzilla.redhat.com/show_bug.cgi?id=399721
karlikt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
------- Additional Comments From karlikt@gmail.com 2007-12-03 13:19 EST ------- New Package CVS Request ======================= Package Name: fusion-icon Short Description: Compiz Fusion panel applet Owners: karlikt@gmail.com Branches: F-8 InitialCC: Cvsextras Commits: yes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: fusion icon - Compiz Fusion panel applet
https://bugzilla.redhat.com/show_bug.cgi?id=399721
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From kevin@tummy.com 2007-12-03 14:21 EST ------- (Please use fedora account names for Owners line...)
cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: fusion icon - Compiz Fusion panel applet
https://bugzilla.redhat.com/show_bug.cgi?id=399721
karlikt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From karlikt@gmail.com 2007-12-03 17:34 EST ------- Built correct for F-8.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: fusion-icon - Compiz Fusion panel applet
https://bugzilla.redhat.com/show_bug.cgi?id=399721
karlikt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: fusion icon |Review Request: fusion-icon |- Compiz Fusion panel applet|- Compiz Fusion panel applet
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=399721
leigh scott leigh123linux@googlemail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |leigh123linux@googlemail.co | |m
--- Comment #11 from leigh scott leigh123linux@googlemail.com 2011-04-05 15:27:58 EDT --- Hi Karol,
I would like fusion-icon to be included in EPEL6, I have built all the other compiz packages required.
https://admin.fedoraproject.org/updates/compizconfig-backend-kconfig4-0.8.4-...
Would you like to build it or grant me permission to do so?
Many thanks
Leigh
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=399721
--- Comment #12 from Karol Trzcionka karlikt@gmail.com 2011-04-05 15:40:38 EDT --- I'll grant perms to you because I don't have RHEL nor CentOS.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=399721
Karol Trzcionka karlikt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs+ |fedora-cvs?
--- Comment #13 from Karol Trzcionka karlikt@gmail.com 2011-04-05 15:41:30 EDT --- Package Change Request ====================== Package Name: fusion-icon New Branches: el6 Owners: karlik leigh123linux
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=399721
--- Comment #14 from leigh scott leigh123linux@googlemail.com 2011-04-05 17:10:53 EDT --- (In reply to comment #12)
I'll grant perms to you because I don't have RHEL nor CentOS.
Thank you.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=399721
--- Comment #15 from Jason Tibbitts tibbs@math.uh.edu 2011-04-06 13:55:37 EDT --- Git done (by process-git-requests).
package-review@lists.fedoraproject.org