[Bug 1208873] New: Review Request: libskindesignerapi - Library which provides the Skindesigner API to other VDR Plugins
https://bugzilla.redhat.com/show_bug.cgi?id=1208873
Bug ID: 1208873 Summary: Review Request: libskindesignerapi - Library which provides the Skindesigner API to other VDR Plugins Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: mgansser@alice.de QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/libskindesignerapi.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/libskindesignerapi-0.0.1-1.fc...
Description: Library which provides the Skindesigner API to other VDR Plugins. VDR Plugins using this API are able to use all Skindesigner facilities to display their OSD representation
Fedora Account System Username: martinkg
Rpmlint ------- Checking: libskindesignerapi-0.0.1-1.fc23.x86_64.rpm devel-0.0.1-1.fc23.x86_64.rpm libskindesignerapi-0.0.1-1.fc23.src.rpm devel.x86_64: W: only-non-binary-in-usr-lib devel.x86_64: W: no-documentation devel.x86_64: W: devel-file-in-non-devel-package /usr/include/libskindesignerapi/skindesignerosdbase.h devel.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libskindesignerapi.so devel.x86_64: W: devel-file-in-non-devel-package /usr/include/libskindesignerapi/osdelements.h devel.x86_64: W: devel-file-in-non-devel-package /usr/lib64/pkgconfig/libskindesignerapi.pc devel.x86_64: W: devel-file-in-non-devel-package /usr/include/libskindesignerapi/skindesignerapi.h libskindesignerapi.src: W: invalid-url Source0: libskindesignerapi-0.0.1.tar.bz2 3 packages and 0 specfiles checked; 0 errors, 8 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1208873
Mario Blättermann mario.blaettermann@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mario.blaettermann@gmail.co | |m Assignee|nobody@fedoraproject.org |mario.blaettermann@gmail.co | |m Alias| |libskindesignerapi Flags| |fedora-review?
--- Comment #1 from Mario Blättermann mario.blaettermann@gmail.com --- Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9408136
Some comments:
License texts are no longer in %doc, please move COPYING to %license.
%files -n devel This produces a package named "devel" instead of "%{name}-devel". Please omit the -n switch to get the latter.
%dir %{_includedir}/%{name}/ %{_includedir}/%{name}/osdelements.h %{_includedir}/%{name}/skindesignerapi.h %{_includedir}/%{name}/skindesignerosdbase.h
This can be shrinked as long as you don't have to exclude anything from this directory:
%{_includedir}/%{name}/
However, it is your choice.
And here is what rpmlint says:
$ rpmlint -i -v * devel.x86_64: I: checking devel.x86_64: I: checking-url http://projects.vdr-developer.org/projects/plg-skindesigner (timeout 10 seconds) devel.x86_64: W: only-non-binary-in-usr-lib There are only non binary files in /usr/lib so they should be in /usr/share.
devel.x86_64: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files.
devel.x86_64: W: devel-file-in-non-devel-package /usr/include/libskindesignerapi/skindesignerosdbase.h A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package.
devel.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libskindesignerapi.so A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package.
devel.x86_64: W: devel-file-in-non-devel-package /usr/include/libskindesignerapi/osdelements.h A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package.
devel.x86_64: W: devel-file-in-non-devel-package /usr/lib64/pkgconfig/libskindesignerapi.pc A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package.
devel.x86_64: W: devel-file-in-non-devel-package /usr/include/libskindesignerapi/skindesignerapi.h A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package.
libskindesignerapi.src: I: checking libskindesignerapi.src: E: description-line-too-long C Library which provides the Skindesigner API to other VDR Plugins. VDR Plugins using Your description lines must not exceed 80 characters. If a line is exceeding this number, cut it to fit in two lines.
libskindesignerapi.src: I: checking-url http://projects.vdr-developer.org/projects/plg-skindesigner (timeout 10 seconds) libskindesignerapi.src: W: invalid-url Source0: libskindesignerapi-0.0.1.tar.bz2 The value should be a valid, public HTTP, HTTPS, or FTP URL.
libskindesignerapi.x86_64: I: checking libskindesignerapi.x86_64: E: description-line-too-long C Library which provides the Skindesigner API to other VDR Plugins. VDR Plugins using Your description lines must not exceed 80 characters. If a line is exceeding this number, cut it to fit in two lines.
libskindesignerapi.x86_64: I: checking-url http://projects.vdr-developer.org/projects/plg-skindesigner (timeout 10 seconds) libskindesignerapi-debuginfo.x86_64: I: checking libskindesignerapi-debuginfo.x86_64: I: checking-url http://projects.vdr-developer.org/projects/plg-skindesigner (timeout 10 seconds) libskindesignerapi.spec: I: checking libskindesignerapi.spec: W: invalid-url Source0: libskindesignerapi-0.0.1.tar.bz2 The value should be a valid, public HTTP, HTTPS, or FTP URL.
4 packages and 1 specfiles checked; 2 errors, 9 warnings.
Well, rpmlint doesn't detect the devel package as such, so the appropriate issues can be ignored. There only remain the too long description lines.
https://bugzilla.redhat.com/show_bug.cgi?id=1208873
--- Comment #2 from MartinKG mgansser@alice.de --- Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/libskindesignerapi.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/libskindesignerapi-0.0.1-2.fc...
%changelog * Fri Apr 03 2015 Martin Gansser martinkg@fedoraproject.org - 0.0.1-2 - Mark license files as %%license where available - omitted the -n switch on %%files sectuib - shrinked %%{_includedir} path - truncated description lines
https://bugzilla.redhat.com/show_bug.cgi?id=1208873
Mario Blättermann mario.blaettermann@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #3 from Mario Blättermann mario.blaettermann@gmail.com --- Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9408515
$ rpmlint -i -v * libskindesignerapi.src: I: checking libskindesignerapi.src: I: checking-url http://projects.vdr-developer.org/projects/plg-skindesigner (timeout 10 seconds) libskindesignerapi.src:65: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 65) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both.
libskindesignerapi.src: W: invalid-url Source0: libskindesignerapi-0.0.1.tar.bz2 The value should be a valid, public HTTP, HTTPS, or FTP URL.
libskindesignerapi.x86_64: I: checking libskindesignerapi.x86_64: I: checking-url http://projects.vdr-developer.org/projects/plg-skindesigner (timeout 10 seconds) libskindesignerapi-debuginfo.x86_64: I: checking libskindesignerapi-debuginfo.x86_64: I: checking-url http://projects.vdr-developer.org/projects/plg-skindesigner (timeout 10 seconds) libskindesignerapi-devel.x86_64: I: checking libskindesignerapi-devel.x86_64: I: checking-url http://projects.vdr-developer.org/projects/plg-skindesigner (timeout 10 seconds) libskindesignerapi-devel.x86_64: W: only-non-binary-in-usr-lib There are only non binary files in /usr/lib so they should be in /usr/share.
libskindesignerapi-devel.x86_64: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files.
libskindesignerapi.spec: I: checking libskindesignerapi.spec:65: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 65) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both.
libskindesignerapi.spec: W: invalid-url Source0: libskindesignerapi-0.0.1.tar.bz2 The value should be a valid, public HTTP, HTTPS, or FTP URL.
4 packages and 1 specfiles checked; 0 errors, 6 warnings.
One ugly issue, the mixed use of space and tabs... It is no blocker, but don't forget to remove to stray tab tab in line 65 when importing your package into the Git repo.
--------------------------------- key:
[+] OK [.] OK, not applicable [X] needs work ---------------------------------
[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review. [+] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. [+] MUST: The package must meet the Packaging Guidelines. [+] MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. [+] MUST: The License field in the package spec file must match the actual license. GPLv2+ [+] MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %license. [+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [+] MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use sha256sum for this task as it is used by the sources file once imported into git. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this. $ sha256sum * 40f84bf737406e2b1ff14bde63eda5c08f95ead0f7944d0e637bc43cd1209aaf libskindesignerapi-0.0.1.tar.bz2 40f84bf737406e2b1ff14bde63eda5c08f95ead0f7944d0e637bc43cd1209aaf libskindesignerapi-0.0.1.tar.bz2.orig
[+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. [.] MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in bugzilla, describing the reason that the package does not compile/build/work on that architecture. The bug number MUST be placed in a comment, next to the corresponding ExcludeArch line. [+] MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense. [.] MUST: The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden. [.] MUST: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. [.] MUST: Packages must NOT bundle copies of system libraries. [.] MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. Without this, use of Prefix: /usr is considered a blocker. [+] MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. [+] MUST: A Fedora package must not list a file more than once in the spec file's %files listings. (Notable exception: license texts in specific situations) [+] MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example. [+] MUST: Each package must consistently use macros. [+] MUST: The package must contain code, or permissable content. [.] MUST: Large documentation files must go in a -doc subpackage. (The definition of large is left up to the packager's best judgement, but is not restricted to size. Large can refer to either size or quantity). [+] MUST: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present. [.] MUST: Static libraries must be in a -static package. [+] MUST: Development files must be in a -devel package. [+] MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name}%{?_isa} = %{version}-%{release} [.] MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built. [.] MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. If you feel that your packaged GUI application does not need a .desktop file, you must put a comment in the spec file with your explanation. [+] MUST: Packages must not own files or directories already owned by other packages. The rule of thumb here is that the first package to be installed should own the files or directories that other packages may rely upon. This means, for example, that no package in Fedora should ever share ownership with any of the files or directories owned by the filesystem or man package. If you feel that you have a good reason to own a file or directory that another package owns, then please present that at package review time. [+] MUST: All filenames in rpm packages must be valid UTF-8.
[.] SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [.] SHOULD: The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available. [+] SHOULD: The reviewer should test that the package builds in mock. See Koji build above (which uses Mock anyway). [+] SHOULD: The package should compile and build into binary rpms on all supported architectures. [.] SHOULD: The reviewer should test that the package functions as described. A package should not segfault instead of running, for example. [+] SHOULD: If scriptlets are used, those scriptlets must be sane. This is vague, and left up to the reviewers judgement to determine sanity. [.] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. [+] SHOULD: The placement of pkgconfig(.pc) files depends on their usecase, and this is usually for development purposes, so should be placed in a -devel pkg. A reasonable exception is that the main pkg itself is a devel tool not installed in a user runtime, e.g. gcc or gdb. [.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself. [.] SHOULD: your package should contain man pages for binaries/scripts. If it doesn't, work with upstream to add them where they make sense.
----------------
PACKAGE APPROVED
----------------
https://bugzilla.redhat.com/show_bug.cgi?id=1208873
MartinKG mgansser@alice.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #4 from MartinKG mgansser@alice.de --- @Mario Thanks for the review.
New Package SCM Request ======================= Package Name: libskindesignerapi Short Description: Library which provides the Skindesigner API to other VDR Plugins Owners: martinkg Branches: f21 f22 InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=1208873
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=1208873
--- Comment #5 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=1208873
MartinKG mgansser@alice.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |NEXTRELEASE Last Closed| |2015-04-04 16:00:14
--- Comment #6 from MartinKG mgansser@alice.de --- package has been built successfully on f21, fc22 and rawhide.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla