Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226309
Summary: Merge Review: postgresql-jdbc Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: nobody@fedoraproject.org QAContact: fedora-package-review@redhat.com CC: tgl@redhat.com
Fedora Merge Review: postgresql-jdbc
http://cvs.fedora.redhat.com/viewcvs/devel/postgresql-jdbc/ Initial Owner: tgl@redhat.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: postgresql-jdbc
https://bugzilla.redhat.com/show_bug.cgi?id=226309
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide
chris@hubick.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@hubick.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226309
--- Comment #1 from Chris Hubick chris@hubick.com 2009-06-27 16:42:15 EDT --- Hi.
I was just wondering if there was any particular reason the JDBC4 driver isn't being shipped with Fedora yet?
I needed the SQL Array support, so I downloaded the upstream JDBC4 driver from the jdbc.postgresql.org site (which says "If you are using the 1.6 JVM, then you should use the JDBC4 version"), and it seems to work great for me under OpenJDK from Fedora 11.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226309
--- Comment #2 from Tom Lane tgl@redhat.com 2009-06-28 13:23:29 EDT --- AFAIK postgresql-jdbc.jar is a perfectly good JDBC4 driver, or at least it has as much JDBC4 support as is available from upstream. It is not my intention to ship a postgresql-jdbc4.jar symlink, unless someone explains to me why one is needed.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226309
Alexander Kurtakov akurtako@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |akurtako@redhat.com
--- Comment #3 from Alexander Kurtakov akurtako@redhat.com 2011-07-28 01:36:24 EDT --- I would do this one. Initial comments based on getting a smaller spec for the official review: * would you please drop gcj_support from the spec to remove a good number of lines :) * Requires(post|postun): jpackage-utils and %post/postun %update_maven_depmap are no longer needed on F15+ * empty "export CLASSPATH=" line can be removed * rm -rf ${RPM_BUILD_ROOT} in %install and %clean section can be removed in modern fedoras * %add_to_maven_depmap postgresql postgresql %{version} JPP postgresql-jdbc should become %add_maven_depmap JPP-postgresql-jdbc.pom %{name}.jar - it's quite more simple and detects groupId:artifactId automatically * %defattr(-,root,root) is no longer needed * there is no need in installing %{_javadir}/%{name}-%{version}.jar as per java guidelines %{_javadir}/%{name}.jar should be the default and versioned one is not needed * ant jar publicapi should be called and javadoc subpackage should be installed * BuildRoot definition can be safely removed
Once these are done I'll do the official review. Or if you want I can do the changes and commit them push a new build - they shouldn't take more than 10 mins.
package-review@lists.fedoraproject.org