https://bugzilla.redhat.com/show_bug.cgi?id=1208665
Bug ID: 1208665 Summary: Review Request: python-tambo - A command line object dispatcher Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: ktdreyer@ktdreyer.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://ktdreyer.fedorapeople.org/reviews/python-tambo.spec SRPM URL: https://ktdreyer.fedorapeople.org/reviews/python-tambo-0.0.9-1.fc23.src.rpm Description: Use any argument parser you want for each sub-command. Easily manage each command as a self-contained application. Fedora Account System Username: ktdreyer
Rawhide (F23) scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9401358
https://bugzilla.redhat.com/show_bug.cgi?id=1208665
Ken Dreyer ktdreyer@ktdreyer.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |adeza@redhat.com, | |branto@redhat.com
--- Comment #1 from Ken Dreyer ktdreyer@ktdreyer.com --- Boris, would you mind taking this package review?
https://bugzilla.redhat.com/show_bug.cgi?id=1208665
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zbyszek@in.waw.pl Assignee|nobody@fedoraproject.org |zbyszek@in.waw.pl Flags| |fedora-review?
--- Comment #2 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- Taking the review.
https://bugzilla.redhat.com/show_bug.cgi?id=1208665
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #3 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- == Notes ==
You can add %global _docdir_fmt %{name} to get the same license and doc directories for python- and python3- subpackages. They contain the same files, so there's no benefit for the user from having two copies in the file system.
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. MIT.
[x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 12 files have unknown license. Detailed output of licensecheck in /var/tmp/1208665-python- tambo/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-tambo Not needed obviously.
[x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: python-tambo-0.0.9-1.fc22.noarch.rpm python3-tambo-0.0.9-1.fc22.noarch.rpm python-tambo-0.0.9-1.fc22.src.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings.
Rpmlint (installed packages) ---------------------------- 2 packages and 0 specfiles checked; 0 errors, 0 warnings.
Requires -------- python3-tambo (rpmlib, GLIBC filtered): python(abi) python3
python-tambo (rpmlib, GLIBC filtered): python(abi)
Provides -------- python3-tambo: python3-tambo
python-tambo: python-tambo
Source checksums ---------------- https://pypi.python.org/packages/source/t/tambo/tambo-0.0.9.tar.gz : CHECKSUM(SHA256) this package : 47cf2f8fcbeaaac0a88eedc2089c834675d3efd551ca8f8c619d9c23660a3072 CHECKSUM(SHA256) upstream package : 47cf2f8fcbeaaac0a88eedc2089c834675d3efd551ca8f8c619d9c23660a3072
Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04 Command line :/usr/bin/fedora-review -b 1208665 -m fedora-22-x86_64 Buildroot used: fedora-22-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Very nice spec file. See Notes as the top. Package is APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=1208665
--- Comment #4 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- Friendly ping, in case you forgot about this.
https://bugzilla.redhat.com/show_bug.cgi?id=1208665
Ken Dreyer ktdreyer@ktdreyer.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #5 from Ken Dreyer ktdreyer@ktdreyer.com --- My apologies, I was on vacation when you approved the package and I forgot to return to this. Thanks very much for the review!
I've made the _doc_fmt change you suggested, here: https://fedorapeople.org/cgit/ktdreyer/public_git/python-tambo.git/commit/?i...
New Package SCM Request ======================= Package Name: python-tambo Short Description: A command line object dispatcher Upstream URL: https://github.com/alfredodeza/tambo Owners: ktdreyer Branches: f21 el6 epel7
https://bugzilla.redhat.com/show_bug.cgi?id=1208665
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=1208665
--- Comment #6 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=1208665
Ken Dreyer ktdreyer@ktdreyer.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE Last Closed| |2015-07-03 02:10:42
--- Comment #7 from Ken Dreyer ktdreyer@ktdreyer.com --- Rawhide (F23) build: http://koji.fedoraproject.org/koji/buildinfo?buildID=666683
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla