[Bug 183953] Review Request: bit (A bit-oriented data stream parser and gtkmm widget set)

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bit (A bit-oriented data stream parser and gtkmm widget set)

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=183953

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  BugsThisDependsOn|183322                      |
OtherBugsDependingO|163778                      |163779
              nThis|                            |

------- Additional Comments From [e-mail]  2006-07-06 06:56 EST -------
It must be "BuildRequires: cppunit-devel" instead of cppunit.

Apart from that:

* reported issues fixed
  * packager is upstream
  * APPROVED

Warnings:

- compiler warnings about type-punning are worrisome
   (I see dangerous C-style casts in the code)

Suggested cleanup:

- Remove *.md5, *.map and *.dot files from the HTML documentation
   (91 files in total).

Hints:

- Note that "mv docs/reference/html ." in your %install section
   breaks --short-circuit installs, which are _very_ useful during
   debugging of spec files. As a rule of thumb, never modify your
   source tree in a way that repeating commands would fail. In this
   case, better "cp" the html tree to somewhere.
   "rpm --short-circuit -ivh bit.spec" should work again and again.