https://bugzilla.redhat.com/show_bug.cgi?id=2088753
Bug ID: 2088753 Summary: New python-docstring-parser RPM Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: pkszub@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
I want to volunteer for the maintenance of the python-docstring-parser package in Fedora.
The docstring_parser is a Python library [1] used to parse Python docstrings. Currently support ReST, Google, Numpydoc-style and Epydoc docstrings.
SPEC: https://github.com/pszubiak/rpms/blob/master/python-docstring-parser/python-...
SRPM: https://download.copr.fedorainfracloud.org/results/pszubiak/python-docstring...
Automated Fedora Review on Copr: https://download.copr.fedorainfracloud.org/results/pszubiak/python-docstring...
[1] https://github.com/rr-/docstring_parser
https://bugzilla.redhat.com/show_bug.cgi?id=2088753
Piotr Szubiakowski pkszub@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|New python-docstring-parser |Review Request: | RPM |python-docstring-parser - | |docstring parser
https://bugzilla.redhat.com/show_bug.cgi?id=2088753
Maxwell G gotmax@e.email changed:
What |Removed |Added ---------------------------------------------------------------------------- Comment|0 |updated
--- Comment #0 has been edited ---
I want to volunteer for the maintenance of the python-docstring-parser package in Fedora.
The docstring_parser is a Python library [1] used to parse Python docstrings. Currently support ReST, Google, Numpydoc-style and Epydoc docstrings.
[1] https://github.com/rr-/docstring_parser
Spec URL: https://github.com/pszubiak/rpms/raw/master/python-docstring-parser/python-d... SRPM URL: https://download.copr.fedorainfracloud.org/results/pszubiak/python-docstring... Description: Parse Python docstrings. Currently support ReST, Google, Numpydoc-style and Epydoc docstrings. Fedora Account System Username: pszubiak Automated Fedora Review on Copr: https://download.copr.fedorainfracloud.org/results/pszubiak/python-docstring...
https://bugzilla.redhat.com/show_bug.cgi?id=2088753
Maxwell G gotmax@e.email changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841 (FE-NEEDSPONSOR) Doc Type|--- |If docs needed, set a value CC| |gotmax@e.email
--- Comment #1 from Maxwell G gotmax@e.email --- I've reformatted your description to follow the https://bugzilla.redhat.com/bugzilla/enter_bug.cgi?product=Fedora&format... template and have blocked FE-NEEDSPONSOR.
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=2088753
--- Comment #2 from Maxwell G gotmax@e.email --- Your specfile looks pretty good! I just have a couple minor comments.
%{url}/archive/refs/tags/%{version}.tar.gz
This should be %{url}/archive/%{version}/%{name}-%{version}.tar.gz. Source0 can also be shortened to Source if you'd like. RPM has supported automatic source file numbering since 4.15.x.
Summary: Parse Python docstrings.
The Summary tag should not have a period.
%description %{_description}
Normally, you'd have the text of the description on a newline after the `%description` macro. However,
``` %global _description %{expand: Parse Python docstrings. Currently support ReST, Google, Numpydoc-style and Epydoc docstrings.} ```
already has a leading newline, so you want it formatted as `%description %{_description}`. The same thing applies for `%description -n python3-%{srcname}`.
Regarding your sponsorship, you should send an introduction email to the devel list if you haven't already[1].
[1]: https://docs.fedoraproject.org/en-US/package-maintainers/Joining_the_Package...
https://bugzilla.redhat.com/show_bug.cgi?id=2088753
Piotr Szubiakowski pszubiak@eso.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(gotmax@e.email)
--- Comment #3 from Piotr Szubiakowski pszubiak@eso.org --- Thank you for the review!
The new SRPM URL: https://download.copr.fedorainfracloud.org/results/pszubiak/python-docstring...
My introduction to the devel community: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/...
https://bugzilla.redhat.com/show_bug.cgi?id=2088753
Maxwell G gotmax@e.email changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(gotmax@e.email) |
--- Comment #4 from Maxwell G gotmax@e.email --- I'm dropping my NEEDINFO so another reviewer who has more time than me can look at this. I will come back to this later if nobody beats me to it. Generally, you shouldn't use NEEDINFO in this type of scenario, anyways.
https://bugzilla.redhat.com/show_bug.cgi?id=2088753
Dominik 'Rathann' Mierzejewski dominik@greysector.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |dominik@greysector.net
--- Comment #5 from Dominik 'Rathann' Mierzejewski dominik@greysector.net --- The package looks good. License is correctly tagged, follows packaging guidelines and sources match upstream:
0f6927d45ca22a20fd7530e27cd8bbc5409d4b08c8cfbc6f30a148532d497936 python-docstring-parser-0.14.1.tar.gz
It builds in mock successfully (I tested F36+). The included test suite runs successfully as well.
Package is APPROVED.
I'll also sponsor Piotr.
https://bugzilla.redhat.com/show_bug.cgi?id=2088753
--- Comment #6 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-docstring-parser
https://bugzilla.redhat.com/show_bug.cgi?id=2088753
Piotr Szubiakowski pszubiak@eso.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |NEXTRELEASE Last Closed| |2022-09-30 12:56:52
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com