https://bugzilla.redhat.com/show_bug.cgi?id=2237656
Bug ID: 2237656 Summary: Review Request: bluechi - A systemd service controller for multi-nodes environments Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: pingou@pingoured.fr QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://pingou.fedorapeople.org/RPMs/bluechi.spec SRPM URL: https://pingou.fedorapeople.org/RPMs/bluechi-0.5.0-1.fc40.src.rpm Description: BlueChi is a systemd service controller for multi-nodes environements with a predefined number of nodes and with a focus on highly regulated environment such as those requiring functional safety (for example in cars). Fedora Account System Username: pingou
This is a re-review request for a package rename, this project used to be called hirte and has been renamed to bluechi.
https://bugzilla.redhat.com/show_bug.cgi?id=2237656
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://github.com/containe | |rs/bluechi
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6375740 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2237656
Pierre-YvesChibon pingou@pingoured.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value
--- Comment #2 from Pierre-YvesChibon pingou@pingoured.fr --- [fedora-review-service-build]
https://bugzilla.redhat.com/show_bug.cgi?id=2237656
--- Comment #3 from Pierre-YvesChibon pingou@pingoured.fr --- I have two questions for the reviewer: a/ the project has been renamed due to a potential trademark issue. The renaming also changed the dbus API used to interact with the main service, so it's not quite a drop-in replacement. That being said: should bluechi obsolete hirte? On the one hand, yes because it's a semi-legal driven renaming, on the other hand, it's not a fully drop-in replacement since the API changed. Thoughts?
b/ when importing bluechi into dist-git, should I preserve the history for the hirte git repo or start from a clean repo?
Thanks :)
https://bugzilla.redhat.com/show_bug.cgi?id=2237656
--- Comment #4 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 1987255 --> https://bugzilla.redhat.com/attachment.cgi?id=1987255&action=edit The .spec file difference from Copr build 6375740 to 6375799
https://bugzilla.redhat.com/show_bug.cgi?id=2237656
--- Comment #5 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6375799 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2237656
--- Comment #6 from Pierre-YvesChibon pingou@pingoured.fr --- [fedora-review-service-build]
https://bugzilla.redhat.com/show_bug.cgi?id=2237656
--- Comment #7 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 1987269 --> https://bugzilla.redhat.com/attachment.cgi?id=1987269&action=edit The .spec file difference from Copr build 6375799 to 6377539
https://bugzilla.redhat.com/show_bug.cgi?id=2237656
--- Comment #8 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6377539 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2237656
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags| |fedora-review? CC| |ngompa13@gmail.com Assignee|nobody@fedoraproject.org |ngompa13@gmail.com
--- Comment #9 from Neal Gompa ngompa13@gmail.com --- Taking this review.
https://bugzilla.redhat.com/show_bug.cgi?id=2237656
--- Comment #10 from Neal Gompa ngompa13@gmail.com --- (In reply to Pierre-YvesChibon from comment #3)
I have two questions for the reviewer: a/ the project has been renamed due to a potential trademark issue. The renaming also changed the dbus API used to interact with the main service, so it's not quite a drop-in replacement. That being said: should bluechi obsolete hirte? On the one hand, yes because it's a semi-legal driven renaming, on the other hand, it's not a fully drop-in replacement since the API changed. Thoughts?
I think for all the important points that matter, the full Obsoletes+Provides is fine.
b/ when importing bluechi into dist-git, should I preserve the history for the hirte git repo or start from a clean repo?
Thanks :)
Up to you, though I prefer the history if you can keep it.
https://bugzilla.redhat.com/show_bug.cgi?id=2237656
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST
--- Comment #11 from Neal Gompa ngompa13@gmail.com --- Review notes:
- package follows Fedora Packaging Guidelines - package builds and installs without errors on rawhide - test suite is run, unit tests pass - latest version is packaged - license matches upstream specification and is acceptable for Fedora - license file is included with %license in %files
PACKAGE APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=2237656
--- Comment #12 from Neal Gompa ngompa13@gmail.com --- Small notes:
BuildRequires: git
You should use "git-core" here, since you only need the core parts of git.
%autosetup -S git
I'd recommend "%autosetup -S git_am" instead.
You can make those changes on import if you so choose.
https://bugzilla.redhat.com/show_bug.cgi?id=2237656
--- Comment #13 from Pierre-YvesChibon pingou@pingoured.fr --- Many thanks for the prompt review! Much appreciated :)
I'll do the two suggested change, while they aren't used at the moment, it'll save me from remembering them next time :)
Thanks again!
https://bugzilla.redhat.com/show_bug.cgi?id=2237656
--- Comment #14 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/bluechi
https://bugzilla.redhat.com/show_bug.cgi?id=2237656
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-7710f4bf9f has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-7710f4bf9f
https://bugzilla.redhat.com/show_bug.cgi?id=2237656
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-7710f4bf9f has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-7710f4bf9f
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-4da0fed184 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-4da0fed184
https://bugzilla.redhat.com/show_bug.cgi?id=2237656
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-4da0fed184 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-4da0fed184 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-4da0fed184
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2237656
--- Comment #19 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-3a5d2b5919 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-3a5d2b5919 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-3a5d2b5919
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2237656
--- Comment #20 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-7710f4bf9f has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-7710f4bf9f *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-7710f4bf9f
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2237656
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2023-09-15 01:35:08
--- Comment #21 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-3a5d2b5919 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2237656
--- Comment #22 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-7710f4bf9f has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2237656
--- Comment #23 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-4da0fed184 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org