https://bugzilla.redhat.com/show_bug.cgi?id=2346427
Bug ID: 2346427 Summary: Review Request: perl-X-Tiny - Base class for a bare-bones exception factory Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: linux@cmadams.net QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://fedorapeople.org/~cmadams/perl-X-Tiny/perl-X-Tiny.spec SRPM URL: https://fedorapeople.org/~cmadams/perl-X-Tiny/perl-X-Tiny-0.22-1.fc41.src.rp... Description: This stripped-down exception framework provides a baseline of functionality for distributions that want to expose exception hierarchies with minimal fuss. It's a pattern that I implemented in some other distributions I created and didn't want to copy/paste around.
Fedora Account System Username: cmadams
https://bugzilla.redhat.com/show_bug.cgi?id=2346427
Michal Josef Spacek mspacek@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mspacek@redhat.com Assignee|nobody@fedoraproject.org |mspacek@redhat.com Status|NEW |ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=2346427
Michal Josef Spacek mspacek@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(linux@cmadams.net | |)
--- Comment #1 from Michal Josef Spacek mspacek@redhat.com --- @linux@cmadams.net Hi Chris,
There is one more provides: "perl(DB)"
You need to add: %global __provides_exclude %{?__provides_exclude:%__provides_exclude|}^perl\(DB\)$
https://bugzilla.redhat.com/show_bug.cgi?id=2346427
--- Comment #2 from Michal Josef Spacek mspacek@redhat.com --- FYI: I created a PR to upstream for removing Test::Simple dependency: https://github.com/FGasper/p5-X-Tiny/pull/3
https://bugzilla.redhat.com/show_bug.cgi?id=2346427
Chris Adams linux@cmadams.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(linux@cmadams.net | |) |
--- Comment #3 from Chris Adams linux@cmadams.net --- Oh, nice catch on the provides, thanks. Updated:
Spec URL: https://fedorapeople.org/~cmadams/perl-X-Tiny/perl-X-Tiny.spec SRPM URL: https://fedorapeople.org/~cmadams/perl-X-Tiny/perl-X-Tiny-0.22-2.fc41.src.rp...
https://bugzilla.redhat.com/show_bug.cgi?id=2346427
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |AutomationTriaged URL| |https://metacpan.org/dist/X | |-Tiny
--- Comment #4 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8853698 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2346427
Michal Josef Spacek mspacek@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(linux@cmadams.net | |)
--- Comment #5 from Michal Josef Spacek mspacek@redhat.com --- @linux@cmadams.net I found that you need to add BuildRequires for coreutils. This is used by %{_fixperms}.
FYI: I created patch for cpanspec (https://github.com/michal-josef-spacek/cpanspec/commit/327eb8b16ac1cae6acd1e...)
And you need to add sed to BuildRequires (by your sed -i '/Test::Simple/d' Makefile.PL)
https://bugzilla.redhat.com/show_bug.cgi?id=2346427
Chris Adams linux@cmadams.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(linux@cmadams.net | |) |
--- Comment #6 from Chris Adams linux@cmadams.net --- I'll change the sed to perl (should have done that to start).
The idea to require coreutils seems like it could be a little over-requires... how %{_fixperms} is implemented is pretty opaque (and rpm itself already requires coreutils). Checking the current perl SRPMs, there are a whole lot that use %{_fixperms} but don't BuildRequire coreutils. The %{_fixperms} macro could change, or call a tool not in coreutils, and there'd be a lot of extra BuildRequires.
I'll add it (I also see a lot of perl SRPMs that do BuildRequire it, about half), but I'm wondering if maybe that shouldn't be the norm; just expect that the package that provides the macro also BuildRequires anything needed to implement the macro.
Spec URL: https://fedorapeople.org/~cmadams/perl-X-Tiny/perl-X-Tiny.spec SRPM URL: https://fedorapeople.org/~cmadams/perl-X-Tiny/perl-X-Tiny-0.22-3.fc41.src.rp...
https://bugzilla.redhat.com/show_bug.cgi?id=2346427
--- Comment #7 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2083353 --> https://bugzilla.redhat.com/attachment.cgi?id=2083353&action=edit The .spec file difference from Copr build 8853698 to 8859436
https://bugzilla.redhat.com/show_bug.cgi?id=2346427
--- Comment #8 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8859436 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2346427
--- Comment #9 from Michal Josef Spacek mspacek@redhat.com --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed BuildRequires are ok
$ rpm -qp --requires perl-X-Tiny-0.22-3.fc43.noarch.rpm | sort | uniq -c | grep -v rpmlib 1 perl(constant) 1 perl-libs 1 perl(Module::Runtime) 1 perl(strict) 1 perl(warnings) There is missing perl(overload) for run time. Probably not detected by perl-generator
$ rpm -qp --provides perl-X-Tiny-0.22-3.fc43.noarch.rpm | sort | uniq -c 1 perl(X::Tiny::Base) 1 perl(X::Tiny) = 0.22 1 perl-X-Tiny = 0.22-3.fc43 Binary provides are Ok.
$ rpmlint ./perl-X-Tiny* 3 packages and 1 specfiles checked; 1 errors, 0 warnings, 12 filtered, 1 badness; has taken 0.7 s There is funny rpm lint issue: incorrect-fsf-address /usr/share/licenses/perl-X-Tiny/LICENSE I don't know what about it.
In case of coreutils, you are right. Delivering of macro should be dependency to coreutils, ideally.
https://bugzilla.redhat.com/show_bug.cgi?id=2346427
--- Comment #10 from Michal Josef Spacek mspacek@redhat.com --- Ok, there is information (https://docs.fedoraproject.org/en-US/package-maintainers/CommonRpmlintIssues...) about incorrect-fsf-address. I will report.
https://bugzilla.redhat.com/show_bug.cgi?id=2346427
--- Comment #11 from Michal Josef Spacek mspacek@redhat.com --- Reported: https://github.com/FGasper/p5-X-Tiny/issues/4
https://bugzilla.redhat.com/show_bug.cgi?id=2346427
--- Comment #12 from Chris Adams linux@cmadams.net --- Ahh yeah, the overload module is used via an eval, probably why it's missed. Added a manual Requires:. I also saw the rpmlint bit about the address, didn't think I should go editing somebody else's license, so I left it alone. If I get some time, I'll try to summarize the bit about %{_fixperms} and coreutils and ask fedora-devel's opinion (since the perl packages appear to be split about half and half).
Spec URL: https://fedorapeople.org/~cmadams/perl-X-Tiny/perl-X-Tiny.spec SRPM URL: https://fedorapeople.org/~cmadams/perl-X-Tiny/perl-X-Tiny-0.22-4.fc41.src.rp...
https://bugzilla.redhat.com/show_bug.cgi?id=2346427
--- Comment #13 from Fedora Review Service fedora-review-bot@fedoraproject.org --- There seems to be some problem with the following file. SRPM URL: https://fedorapeople.org/~cmadams/perl-X-Tiny/perl-X-Tiny-0.22-4.fc41.src.rp... Fetching it results in a 404 Not Found error. Please make sure the URL is correct and publicly available.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2346427
Michal Josef Spacek mspacek@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+
--- Comment #14 from Michal Josef Spacek mspacek@redhat.com --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed BuildRequires are ok
$ rpm -qp --requires perl-X-Tiny-0.22-4.fc43.noarch.rpm | sort | uniq -c | grep -v rpmlib 1 perl(constant) 1 perl-libs 1 perl(Module::Runtime) 1 perl(overload) 1 perl(strict) 1 perl(warnings)
Binary requires are Ok.
$ rpm -qp --provides perl-X-Tiny-0.22-4.fc43.noarch.rpm | sort | uniq -c 1 perl(X::Tiny::Base) 1 perl(X::Tiny) = 0.22 1 perl-X-Tiny = 0.22-4.fc43 Binary provides are Ok.
rpmlint: perl-X-Tiny.noarch: E: incorrect-fsf-address /usr/share/licenses/perl-X-Tiny/LICENSE reported, ok
The package is in line with Fedora and Perl packaging guide lines.
https://bugzilla.redhat.com/show_bug.cgi?id=2346427
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RELEASE_PENDING
--- Comment #15 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-X-Tiny
https://bugzilla.redhat.com/show_bug.cgi?id=2346427
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RELEASE_PENDING |MODIFIED
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-6a17ddff5e (perl-X-Tiny-0.22-4.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2025-6a17ddff5e
https://bugzilla.redhat.com/show_bug.cgi?id=2346427
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-4a3629324e (perl-X-Tiny-0.22-4.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-4a3629324e
https://bugzilla.redhat.com/show_bug.cgi?id=2346427
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-4a3629324e has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-4a3629324e *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-4a3629324e
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2346427
--- Comment #19 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-6a17ddff5e has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-6a17ddff5e *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-6a17ddff5e
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2346427
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2025-05-01 02:06:20
--- Comment #20 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-4a3629324e (perl-X-Tiny-0.22-4.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2346427
--- Comment #21 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-6a17ddff5e (perl-X-Tiny-0.22-4.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org