https://bugzilla.redhat.com/show_bug.cgi?id=1269603
Bug ID: 1269603 Summary: Review Request: vim-commentary - Comment stuff out; takes a motion as a target Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: vondruch@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://fedorapeople.org/cgit/vondruch/public_git/vim-commentary.git/tree/vi... SRPM URL: http://people.redhat.com/vondruch/vim-commentary-1.2-1.fc24.src.rpm
Description: Comment stuff out. Use gcc to comment out a line (takes a count), gc to comment out the target of a motion (for example, gcap to comment out a paragraph), and gc in visual mode to comment out the selection. That's it.
Fedora Account System Username: vondruch
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=11359188
https://bugzilla.redhat.com/show_bug.cgi?id=1269603
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zbyszek@in.waw.pl Assignee|nobody@fedoraproject.org |zbyszek@in.waw.pl Flags| |fedora-review+
--- Comment #1 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- Please link to the raw spec file. Otherwise fedora-review doesn't work ootb.
Yep, looks good. The %description is kind of hard to parse, but I don't use vim, maybe it would make sense if I did. I think you should change the Summary to be something like "Comment stuff out in vim using ...".
- license is OK - license file is not present, but that's fine for a 35 line script that uses a common license :)
- requires/provides are ok - appdata file is present, nice! - scriptlets are ok - latest version - fedora-review doesn't complain - rpmlint:
vim-commentary.noarch: W: spelling-error %description -l en_US gcc -> cc, g cc vim-commentary.noarch: W: spelling-error %description -l en_US gc -> cg, g, c vim-commentary.noarch: W: spelling-error %description -l en_US gcap -> gap, cap, g cap All OK.
vim-commentary.noarch: W: invalid-url URL: http://www.vim.org/scripts/script.php?script_id=3695 HTTP Error 503: Service Unavailable Works for me.
Package is APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=1269603
--- Comment #2 from Vít Ondruch vondruch@redhat.com --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #1)
Please link to the raw spec file. Otherwise fedora-review doesn't work ootb.
Sorry, this was mistake on my side, since I typically do so
Yep, looks good. The %description is kind of hard to parse, but I don't use vim, maybe it would make sense if I did.
Well, yeah, I know, it could be better, but there is really nothing more to say (but suggestions are welcome :)
I think you should change the Summary to be something like "Comment stuff out in vim using ...".
I'll go with "Comment and uncomments stuff in Vim using motion as a target"
Package is APPROVED.
Thanks for the review!
https://bugzilla.redhat.com/show_bug.cgi?id=1269603
--- Comment #3 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/vim-commentary
https://bugzilla.redhat.com/show_bug.cgi?id=1269603
Vít Ondruch vondruch@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Fixed In Version| |vim-commentary-1.2-1.fc24 Resolution|--- |RAWHIDE Last Closed| |2015-12-02 04:55:36
package-review@lists.fedoraproject.org