https://bugzilla.redhat.com/show_bug.cgi?id=1077746
Bug ID: 1077746 Summary: Review Request: libappstream-glib - Library for AppStream metadata Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: rhughes@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://people.freedesktop.org/~hughsient/temp/libappstream-glib.spec SRPM URL: http://people.freedesktop.org/~hughsient/temp/libappstream-glib-0.1.0-1.fc20... Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6645564 Description:
This library provides GObjects and helper methods to make it easy to read and write AppStream metadata. It also provides a simple DOM implementation that makes it easy to edit nodes and convert to and from the standardized XML representation.
This library will be used in gnome-software (already in fedora) post 3.12, appdata-tools (already in fedora) for the next release and createrepo_as (not yet in fedora).
Fedora Account System Username: rhughes
rpmbuild warnings:
libappstream-glib.x86_64: W: spelling-error Summary(en_US) metadata -> meta data, meta-data, metatarsal libappstream-glib.x86_64: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsal libappstream-glib-devel.x86_64: W: spelling-error Summary(en_US) appstream -> app stream, app-stream, upstream libappstream-glib-devel.x86_64: W: spelling-error %description -l en_US appstream -> app stream, app-stream, upstream libappstream-glib.src: W: spelling-error Summary(en_US) metadata -> meta data, meta-data, metatarsal libappstream-glib.src: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsal 4 packages and 1 specfiles checked; 0 errors, 6 warnings.
(all false positives, "metadata" is of course a correct word, and "AppStream" is the name of the XML standard)
Comments and suggestions very welcome, thanks.
https://bugzilla.redhat.com/show_bug.cgi?id=1077746
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |rdieter@math.unl.edu Assignee|nobody@fedoraproject.org |rdieter@math.unl.edu Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1077746
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #1 from Rex Dieter rdieter@math.unl.edu --- naming: ok
sources: ok c8f2bb33d2615be39eed28969173a12e appstream-glib-0.1.0.tar.xz
licensing: ok
builds/installs: ok
scriptlets: ok
looks good in general, some mostly smaller items:
1. SHOULD use arch'd dependency in -devel subpkg, use Requires: %{name}%{?_isa} = %{version}-%{release} instead of Requires: %{name} = %{version}-%{release}
2. SHOULD omit deprecated tags %defattr
3. SHOULD up build dep BuildRequires: glib2-devel >= 2.16.1 to BuildRequires: glib2-devel >= 2.39
build fails on f20 using glib2-2.28, with: ./.libs/libappstream-glib.so: error: undefined reference to 'g_str_tokenize_and_fold' which I believe is new in 2.39 (I could be wrong though)
4. SHOULD track library soname in %files, I'd prefer: %{_libdir}/libappstream-glib.so.1* instead of: %{_libdir}/*libappstream-glib*.so.*
which avoids the possibility of surprise soname bumps.
5. SHOULD omit unused macro: %define alphatag .20140318git
As these are not blockers, APPROVED
(though I'd prefer you consider addressing these prior to doing any official builds in koji).
https://bugzilla.redhat.com/show_bug.cgi?id=1077746
--- Comment #2 from Richard Hughes rhughes@redhat.com ---
- SHOULD use arch'd dependency in -devel subpkg, use
Requires: %{name}%{?_isa} = %{version}-%{release} instead of Requires: %{name} = %{version}-%{release}
Fixed.
- SHOULD omit deprecated tags
%defattr
Fixed.
- SHOULD up build dep
BuildRequires: glib2-devel >= 2.16.1 to BuildRequires: glib2-devel >= 2.39
Fixed, and good catch.
- SHOULD track library soname in %files, I'd prefer:
%{_libdir}/libappstream-glib.so.1* instead of: %{_libdir}/*libappstream-glib*.so.*
Fixed.
- SHOULD omit unused macro:
%define alphatag .20140318git
Fixed.
Thanks for the speedy review.
https://bugzilla.redhat.com/show_bug.cgi?id=1077746
Richard Hughes rhughes@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #3 from Richard Hughes rhughes@redhat.com --- New Package SCM Request ======================= Package Name: libappstream-glib Short Description: Library for AppStream metadata Owners: rhughes Branches: f20 InitialCC: rhughes
https://bugzilla.redhat.com/show_bug.cgi?id=1077746
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=1077746
--- Comment #4 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=1077746
Richard Hughes rhughes@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |NEXTRELEASE Last Closed| |2014-03-18 13:58:19
--- Comment #5 from Richard Hughes rhughes@redhat.com --- Build fine, thanks all!
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla