[Bug 1786774] New: Review Request: obs-service-tar_scm - An OBS source service: checkout or update a tarball from svn/git/hg
https://bugzilla.redhat.com/show_bug.cgi?id=1786774
Bug ID: 1786774 Summary: Review Request: obs-service-tar_scm - An OBS source service: checkout or update a tarball from svn/git/hg Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: ngompa13@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://ngompa.fedorapeople.org/for-review/obs-service-tar_scm.spec SRPM URL: https://ngompa.fedorapeople.org/for-review/obs-service-tar_scm-0.10.10-1.fc3...
Description: This is a source service for openSUSE Build Service.
It supports downloading from svn, git, hg and bzr repositories.
Fedora Account System Username: ngompa
https://bugzilla.redhat.com/show_bug.cgi?id=1786774
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1785461 Doc Type|--- |If docs needed, set a value
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1785461 [Bug 1785461] Services required for new'ish "buildtime" option not packaged
https://bugzilla.redhat.com/show_bug.cgi?id=1786774
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |zebob.m@gmail.com Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review+
--- Comment #1 from Robert-André Mauchin zebob.m@gmail.com --- - These 5 packages all depend on obs-service-obs_scm-common so you don't need to repeat %license debian/copyright in each of them. Same with README.md.
%files %{_prefix}/lib/obs/service/tar_scm.service
%files -n obs-service-tar %{_prefix}/lib/obs/service/tar %{_prefix}/lib/obs/service/tar.service
%files -n obs-service-obs_scm %{_prefix}/lib/obs/service/obs_scm %{_prefix}/lib/obs/service/obs_scm.service
%files -n obs-service-appimage %{_prefix}/lib/obs/service/appimage*
%files -n obs-service-snapcraft %{_prefix}/lib/obs/service/snapcraft*
- Bother upstream again for a LICENSE file
- Use %global not %define:
%global service tar_scm
- Keep timestamps:
sed -i "s|install -m|install -pm|" GNUmakefile
- There are a bunch of errors related to python-bytecode-inconsistent-mtime
python-bytecode-inconsistent-mtime: The timestamp embedded in this python bytecode file isn't equal to the mtime of the original source file, which will force the interpreter to recompile the .py source every time, ignoring the saved bytecode.
%install %make_install PREFIX="%{_prefix}" SYSCFG="%{_sysconfdir}" PYTHON="%{__python3}" %py_byte_compile %{__python3} %{buildroot}%{_prefix}/lib/obs/service/TarSCM
- Package approved, please fix the aforementioned issues before import.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GPL (v2 or later)". 74 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/obs-service-tar_scm/review-obs-service- tar_scm/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /etc/obs(obs-service- download_files), /etc/obs/services(obs-service-download_files), /usr/lib/obs(obs-service-extract_file, obs-service-set_version, obs- service-download_files, obs-service-rust2rpm, osc), /usr/lib/obs/service(obs-service-extract_file, obs-service- set_version, obs-service-download_files, obs-service-rust2rpm, osc) [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 122880 bytes in 6 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in obs- service-obs_scm-common , obs-service-tar , obs-service-obs_scm , obs- service-appimage , obs-service-snapcraft [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [!]: Packages should try to preserve timestamps of original installed files. [!]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define service tar_scm [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: obs-service-tar_scm-0.10.10-1.fc32.noarch.rpm obs-service-obs_scm-common-0.10.10-1.fc32.noarch.rpm obs-service-tar-0.10.10-1.fc32.noarch.rpm obs-service-obs_scm-0.10.10-1.fc32.noarch.rpm obs-service-appimage-0.10.10-1.fc32.noarch.rpm obs-service-snapcraft-0.10.10-1.fc32.noarch.rpm obs-service-tar_scm-0.10.10-1.fc32.src.rpm obs-service-tar_scm.noarch: W: spelling-error Summary(en_US) svn -> sen, sin, son obs-service-tar_scm.noarch: W: spelling-error Summary(en_US) hg -> Hg, jg, hf obs-service-tar_scm.noarch: W: spelling-error %description -l en_US openSUSE -> opens Use, open SUSE, open-SUSE obs-service-tar_scm.noarch: W: spelling-error %description -l en_US svn -> sen, sin, son obs-service-tar_scm.noarch: W: spelling-error %description -l en_US hg -> Hg, jg, hf obs-service-tar_scm.noarch: W: spelling-error %description -l en_US bzr -> bar, brr, bur obs-service-tar_scm.noarch: W: only-non-binary-in-usr-lib obs-service-obs_scm-common.noarch: W: spelling-error %description -l en_US openSUSE -> opens Use, open SUSE, open-SUSE obs-service-obs_scm-common.noarch: W: spelling-error %description -l en_US svn -> sen, sin, son obs-service-obs_scm-common.noarch: W: spelling-error %description -l en_US hg -> Hg, jg, hf obs-service-obs_scm-common.noarch: W: spelling-error %description -l en_US bzr -> bar, brr, bur obs-service-obs_scm-common.noarch: W: only-non-binary-in-usr-lib obs-service-obs_scm-common.noarch: E: python-bytecode-inconsistent-mtime /usr/lib/obs/service/TarSCM/__pycache__/__init__.cpython-38.pyc 2019-08-21T14:26:29 /usr/lib/obs/service/TarSCM/__init__.py 2019-12-28T00:22:34 obs-service-obs_scm-common.noarch: E: python-bytecode-inconsistent-mtime /usr/lib/obs/service/TarSCM/__pycache__/archive.cpython-38.pyc 2019-08-21T14:26:29 /usr/lib/obs/service/TarSCM/archive.py 2019-12-28T00:22:34 obs-service-obs_scm-common.noarch: E: python-bytecode-inconsistent-mtime /usr/lib/obs/service/TarSCM/__pycache__/changes.cpython-38.pyc 2019-08-21T14:26:29 /usr/lib/obs/service/TarSCM/changes.py 2019-12-28T00:22:34 obs-service-obs_scm-common.noarch: E: python-bytecode-inconsistent-mtime /usr/lib/obs/service/TarSCM/__pycache__/cli.cpython-38.pyc 2019-08-21T14:26:29 /usr/lib/obs/service/TarSCM/cli.py 2019-12-28T00:22:34 obs-service-obs_scm-common.noarch: E: python-bytecode-inconsistent-mtime /usr/lib/obs/service/TarSCM/__pycache__/config.cpython-38.pyc 2019-08-21T14:26:29 /usr/lib/obs/service/TarSCM/config.py 2019-12-28T00:22:34 obs-service-obs_scm-common.noarch: E: python-bytecode-inconsistent-mtime /usr/lib/obs/service/TarSCM/__pycache__/exceptions.cpython-38.pyc 2019-08-21T14:26:29 /usr/lib/obs/service/TarSCM/exceptions.py 2019-12-28T00:22:34 obs-service-obs_scm-common.noarch: E: python-bytecode-inconsistent-mtime /usr/lib/obs/service/TarSCM/__pycache__/helpers.cpython-38.pyc 2019-08-21T14:26:29 /usr/lib/obs/service/TarSCM/helpers.py 2019-12-28T00:22:34 obs-service-obs_scm-common.noarch: E: python-bytecode-inconsistent-mtime /usr/lib/obs/service/TarSCM/__pycache__/tasks.cpython-38.pyc 2019-08-21T14:26:29 /usr/lib/obs/service/TarSCM/tasks.py 2019-12-28T00:22:34 obs-service-obs_scm-common.noarch: E: python-bytecode-inconsistent-mtime /usr/lib/obs/service/TarSCM/scm/__pycache__/__init__.cpython-38.pyc 2019-08-21T14:26:29 /usr/lib/obs/service/TarSCM/scm/__init__.py 2019-12-28T00:22:34 obs-service-obs_scm-common.noarch: E: python-bytecode-inconsistent-mtime /usr/lib/obs/service/TarSCM/scm/__pycache__/base.cpython-38.pyc 2019-08-21T14:26:29 /usr/lib/obs/service/TarSCM/scm/base.py 2019-12-28T00:22:34 obs-service-obs_scm-common.noarch: E: python-bytecode-inconsistent-mtime /usr/lib/obs/service/TarSCM/scm/__pycache__/bzr.cpython-38.pyc 2019-08-21T14:26:29 /usr/lib/obs/service/TarSCM/scm/bzr.py 2019-12-28T00:22:34 obs-service-obs_scm-common.noarch: E: python-bytecode-inconsistent-mtime /usr/lib/obs/service/TarSCM/scm/__pycache__/git.cpython-38.pyc 2019-08-21T14:26:29 /usr/lib/obs/service/TarSCM/scm/git.py 2019-12-28T00:22:34 obs-service-obs_scm-common.noarch: E: python-bytecode-inconsistent-mtime /usr/lib/obs/service/TarSCM/scm/__pycache__/hg.cpython-38.pyc 2019-08-21T14:26:29 /usr/lib/obs/service/TarSCM/scm/hg.py 2019-12-28T00:22:34 obs-service-obs_scm-common.noarch: E: python-bytecode-inconsistent-mtime /usr/lib/obs/service/TarSCM/scm/__pycache__/svn.cpython-38.pyc 2019-08-21T14:26:29 /usr/lib/obs/service/TarSCM/scm/svn.py 2019-12-28T00:22:34 obs-service-obs_scm-common.noarch: E: python-bytecode-inconsistent-mtime /usr/lib/obs/service/TarSCM/scm/__pycache__/tar.cpython-38.pyc 2019-08-21T14:26:29 /usr/lib/obs/service/TarSCM/scm/tar.py 2019-12-28T00:22:34 obs-service-tar.noarch: W: only-non-binary-in-usr-lib obs-service-tar.noarch: W: dangling-relative-symlink /usr/lib/obs/service/tar tar_scm obs-service-obs_scm.noarch: W: spelling-error Summary(en_US) cpio -> CPI obs-service-obs_scm.noarch: W: spelling-error %description -l en_US cpio -> CPI obs-service-obs_scm.noarch: W: only-non-binary-in-usr-lib obs-service-obs_scm.noarch: W: dangling-relative-symlink /usr/lib/obs/service/obs_scm tar_scm obs-service-appimage.noarch: W: spelling-error Summary(en_US) yml -> ml, y ml obs-service-appimage.noarch: W: spelling-error %description -l en_US yml -> ml, y ml obs-service-appimage.noarch: W: only-non-binary-in-usr-lib obs-service-appimage.noarch: W: dangling-relative-symlink /usr/lib/obs/service/appimage tar_scm obs-service-snapcraft.noarch: W: spelling-error Summary(en_US) yaml -> yam, yams, yawl obs-service-snapcraft.noarch: W: spelling-error %description -l en_US yaml -> yam, yams, yawl obs-service-snapcraft.noarch: W: only-non-binary-in-usr-lib obs-service-snapcraft.noarch: W: dangling-relative-symlink /usr/lib/obs/service/snapcraft tar_scm obs-service-tar_scm.src: W: spelling-error Summary(en_US) svn -> sen, sin, son obs-service-tar_scm.src: W: spelling-error Summary(en_US) hg -> Hg, jg, hf obs-service-tar_scm.src: W: spelling-error %description -l en_US openSUSE -> opens Use, open SUSE, open-SUSE obs-service-tar_scm.src: W: spelling-error %description -l en_US svn -> sen, sin, son obs-service-tar_scm.src: W: spelling-error %description -l en_US hg -> Hg, jg, hf obs-service-tar_scm.src:108: E: hardcoded-library-path in %{_prefix}/lib/obs/service/tar_scm.service obs-service-tar_scm.src:113: E: hardcoded-library-path in %{_prefix}/lib/obs obs-service-tar_scm.src:114: E: hardcoded-library-path in %{_prefix}/lib/obs/service obs-service-tar_scm.src:115: E: hardcoded-library-path in %{_prefix}/lib/obs/service/TarSCM obs-service-tar_scm.src:116: E: hardcoded-library-path in %{_prefix}/lib/obs/service/tar_scm obs-service-tar_scm.src:124: E: hardcoded-library-path in %{_prefix}/lib/obs/service/tar obs-service-tar_scm.src:125: E: hardcoded-library-path in %{_prefix}/lib/obs/service/tar.service obs-service-tar_scm.src:130: E: hardcoded-library-path in %{_prefix}/lib/obs/service/obs_scm obs-service-tar_scm.src:131: E: hardcoded-library-path in %{_prefix}/lib/obs/service/obs_scm.service obs-service-tar_scm.src:136: E: hardcoded-library-path in %{_prefix}/lib/obs/service/appimage* obs-service-tar_scm.src:141: E: hardcoded-library-path in %{_prefix}/lib/obs/service/snapcraft* 7 packages and 0 specfiles checked; 26 errors, 31 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1786774
--- Comment #2 from Igor Gnatenko i.gnatenko.brain@gmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/obs-service-tar_scm
https://bugzilla.redhat.com/show_bug.cgi?id=1786774
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #3 from Fedora Update System updates@fedoraproject.org --- FEDORA-2019-346af3e9c5 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-346af3e9c5
https://bugzilla.redhat.com/show_bug.cgi?id=1786774
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA Last Closed| |2020-01-04 20:33:04
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- obs-build-20191205-325.1.1.fc31, obs-service-recompress-0.3.1-3.git20170704.59bf231.fc31, obs-service-tar_scm-0.10.10-2.fc31, osc-0.167.1-281.1.3.fc31, osc-source_validator-0.19-3.fc31, perl-BSSolv-0.15-2.git20191121.1955d7f.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1786774
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- obs-build-20191205-325.1.1.fc30, obs-service-recompress-0.3.1-3.git20170704.59bf231.fc30, obs-service-tar_scm-0.10.10-2.fc30, osc-0.167.1-281.1.3.fc30, osc-source_validator-0.19-3.fc30, perl-BSSolv-0.15-2.git20191121.1955d7f.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com