[Bug 1201870] New: Review Request: vdr-tvguideng - TvGuideNG is a highly customizable 2D EPG viewer plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1201870
Bug ID: 1201870 Summary: Review Request: vdr-tvguideng - TvGuideNG is a highly customizable 2D EPG viewer plugin Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: mgansser@alice.de QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/vdr-tvguideng.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/vdr-tvguideng-0.0.1-1.fc21.sr...
Description: "TvGuideNG" is a highly customizable 2D EPG viewer plugin. The "Search & Recordings" Menü provided by the red button allows to search in the EPG and manage timers, search timers, series timers and switch timers in an convenient way.
Fedora Account System Username: martinkg
rpmlint vdr-weatherforecast-0.0.3-1.fc21.x86_64.rpm vdr-weatherforecast.x86_64: W: spelling-error %description -l en_US io -> oi, Io, ii 1 packages and 0 specfiles checked; 0 errors, 1 warnings.
# rpmlint vdr-weatherforecast-debuginfo-0.0.3-1.fc21.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
# rpmlint vdr-weatherforecast-0.0.3-1.fc21.src.rpm vdr-weatherforecast.src: W: spelling-error %description -l en_US io -> oi, Io, ii 1 packages and 0 specfiles checked; 0 errors, 1 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1201870
Mario Blättermann mario.blaettermann@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |mario.blaettermann@gmail.co | |m Alias| |vdr-tvguideng Flags| |fedora-review?
--- Comment #1 from Mario Blättermann mario.blaettermann@gmail.com --- The source tarball contains the file services/epgsearch.h, which obviously comes from a separate project [1]. The bundled file is a newer version than in the Fedora srpm of vdr-epgsearch, but there's no -devel package which ships the header file. Having a deeper look at the Makefile of vdr-epgsearch, I can't find any "make" target which would install header files for external use by other software. Is this a peculiarity of the VDR stuff...?
Finally, your package requires vdr-epgsearch at runtime anyway, so I assume the package would also build with the vdr-epgsearch package, if the *.h file would exist there. Somewhat strange, there's a header file bundled which is not available from the Fedora package although the runtime files are present.
There's a typo in the description: »Menü« is German, not English ;)
https://bugzilla.redhat.com/show_bug.cgi?id=1201870
Mario Blättermann mario.blaettermann@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW CC|mario.blaettermann@gmail.co | |m | Assignee|mario.blaettermann@gmail.co |nobody@fedoraproject.org |m |
--- Comment #2 from Mario Blättermann mario.blaettermann@gmail.com --- Sorry, I don't have the time anymore for package reviews.
https://bugzilla.redhat.com/show_bug.cgi?id=1201870
Ville Skyttä ville.skytta@iki.fi changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |
https://bugzilla.redhat.com/show_bug.cgi?id=1201870
Antonio Trande anto.trande@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |anto.trande@gmail.com
--- Comment #3 from Antonio Trande anto.trande@gmail.com --- Please, fix:
Source checksums ---------------- http://projects.vdr-developer.org/git/vdr-plugin-tvguideng.git/snapshot/vdr-... : CHECKSUM(SHA256) this package : 2a7a556f51b7df1e594d70f47d34dd99f5ca7373cbff34104fea882495f3c16e CHECKSUM(SHA256) upstream package : 442d48ab70ddd0f9fe8268efd2daf8b02aee56fbcf2edddc0c5e9e0e43a99ddf
https://bugzilla.redhat.com/show_bug.cgi?id=1201870
--- Comment #4 from MartinKG mgansser@alice.de --- new upstream packages available:
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/vdr-tvguideng.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/vdr-tvguideng-0.1.6-1.fc23.sr...
%changelog * Wed Jan 06 2016 Martin Gansser martinkg@fedoraproject.org - 0.1.6-1 - Update to 0.1.6
https://bugzilla.redhat.com/show_bug.cgi?id=1201870
Antonio Trande anto.trande@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC|anto.trande@gmail.com | Assignee|nobody@fedoraproject.org |anto.trande@gmail.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1201870
--- Comment #5 from Antonio Trande anto.trande@gmail.com --- - vdr-skindesigner is not in Fedora but in RPMFusion-free.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://fedoraproject.org/wiki/Packaging:Guidelines
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* GPL (v2 or later)", "GPL (v2 or later)", "Unknown or generated". 54 files have unknown license. Detailed output of licensecheck in /home/sagitter/1201870-vdr- tvguideng/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in vdr- tvguideng-debuginfo [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Installation errors ------------------- INFO: mock.py version 1.2.14 starting (python version = 3.4.3)... Start: init plugins INFO: selinux enabled Finish: init plugins Start: run INFO: Running /usr/bin/dnf install /home/sagitter/1201870-vdr-tvguideng/results/vdr-tvguideng-0.1.6-1.fc24.x86_64.rpm /home/sagitter/1201870-vdr-tvguideng/results/vdr-tvguideng-debuginfo-0.1.6-1.fc24.x86_64.rpm /home/sagitter/1201870-vdr-tvguideng/results/vdr-tvguideng-debuginfo-0.1.6-1.fc24.x86_64.rpm Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled yum cache Start: cleaning yum metadata Finish: cleaning yum metadata INFO: enabled ccache Mock Version: 1.2.14 INFO: Mock Version: 1.2.14 Finish: chroot init ERROR: Command failed. See logs for output. # /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 24 install /home/sagitter/1201870-vdr-tvguideng/results/vdr-tvguideng-0.1.6-1.fc24.x86_64.rpm /home/sagitter/1201870-vdr-tvguideng/results/vdr-tvguideng-debuginfo-0.1.6-1.fc24.x86_64.rpm /home/sagitter/1201870-vdr-tvguideng/results/vdr-tvguideng-debuginfo-0.1.6-1.fc24.x86_64.rpm --setopt=tsflags=nocontexts
Rpmlint ------- Checking: vdr-tvguideng-0.1.6-1.fc24.x86_64.rpm vdr-tvguideng-debuginfo-0.1.6-1.fc24.x86_64.rpm vdr-tvguideng-0.1.6-1.fc24.src.rpm vdr-tvguideng.x86_64: W: spelling-error Summary(en_US) customizable -> customization vdr-tvguideng.x86_64: W: spelling-error %description -l en_US customizable -> customization vdr-tvguideng.src: W: spelling-error Summary(en_US) customizable -> customization vdr-tvguideng.src: W: spelling-error %description -l en_US customizable -> customization 3 packages and 0 specfiles checked; 0 errors, 4 warnings.
Requires -------- vdr-tvguideng (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libskindesignerapi.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) vdr(abi)(x86-64) vdr-epgsearch vdr-skindesigner
vdr-tvguideng-debuginfo (rpmlib, GLIBC filtered):
Provides -------- vdr-tvguideng: libvdr-tvguideng.so.2.2.0()(64bit) vdr-tvguideng vdr-tvguideng(x86-64)
vdr-tvguideng-debuginfo: vdr-tvguideng-debuginfo vdr-tvguideng-debuginfo(x86-64)
Source checksums ---------------- https://projects.vdr-developer.org/git/vdr-plugin-tvguideng.git/snapshot/vdr... : CHECKSUM(SHA256) this package : 6c87e29da1d01f222cd6ff5ef439319b421a934760ce245dda4344d734783265 CHECKSUM(SHA256) upstream package : 6c87e29da1d01f222cd6ff5ef439319b421a934760ce245dda4344d734783265
Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -v -o --yum-cmd --yum -m fedora-rawhide-x86_64 -b 1201870 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
https://bugzilla.redhat.com/show_bug.cgi?id=1201870
Antonio Trande anto.trande@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mgansser@alice.de Flags|fedora-review? |fedora-review- | |needinfo?(mgansser@alice.de | |)
--- Comment #6 from Antonio Trande anto.trande@gmail.com --- @Martin
What do you want to move this package on RPMFusion?
https://bugzilla.redhat.com/show_bug.cgi?id=1201870
--- Comment #7 from Antonio Trande anto.trande@gmail.com --- (In reply to Antonio Trande from comment #6)
@Martin
What do you want to move this package on RPMFusion?
Sorry, bad English.
Do you prefer to move this package on RPMFusion?
https://bugzilla.redhat.com/show_bug.cgi?id=1201870
MartinKG mgansser@alice.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |WONTFIX Flags|needinfo?(mgansser@alice.de | |) | Last Closed| |2016-01-09 05:11:24
--- Comment #8 from MartinKG mgansser@alice.de --- @Antonio yes, i prefer to move vdr-tvguideng on RPMFusion, because it depends on vdr-skindesigner that is in RPMFusion-free.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla