[Bug 1196827] New: Review Request: <main package name here> - <short summary here>

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196827

Bug ID: 1196827
           Summary: Review Request: <main package name here> - <short
                    summary here>
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Spec URL:
https://raw.githubusercontent.com/dpocock/qt-client/fedora/postbooks.spec
SRPM URL: https://secure.trendhosting.net/fedora/postbooks-4.8.1-1.fc19.src.rpm
Description: Full accounting and ERP suite.  This is the desktop client, one or
more users can run it to connect to the PostgreSQL server.  Apart from
PostgreSQL, no other server components are required to support users with the
desktop GUI.  It is developed in C++ and has a Qt GUI.  xTuple also provides a
web and mobile interface, that can work off the same PostgreSQL schema but it
is not included in this package.
Fedora Account System Username: pocock

[Bug 1196827] Review Request: postbooks - PostgreSQL-based accounting and ERP suite, Qt-based desktop version

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196827

Daniel Pocock  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends On|                            |1196782, 1196780
            Summary|Review Request: <main       |Review Request: postbooks -
                   |package name here> - <short |PostgreSQL-based accounting
                   |summary here>               |and ERP suite, Qt-based
                   |                            |desktop version

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1196780
[Bug 1196780] Review Request: openrpt - reporting tool for xTuple /
PostBooks
https://bugzilla.redhat.com/show_bug.cgi?id=1196782
[Bug 1196782] Review Request: csvimp - xTuple / PostBooks data import
utility

[Bug 1196827] Review Request: postbooks - PostgreSQL-based accounting and ERP suite, Qt-based desktop version

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196827

--- Comment #1 from Daniel Pocock  ---

I've created a pull request for the upstream developers to accept the spec file
in their repository:

https://github.com/xtuple/qt-client/pull/613

[Bug 1196827] Review Request: postbooks - PostgreSQL-based accounting and ERP suite, Qt-based desktop version

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196827

Zbigniew Jędrzejewski-Szmek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review?

--- Comment #2 from Zbigniew Jędrzejewski-Szmek  ---
It'd be nice to have Requires on separate lines, especially for the ones with
%{?...} variables. This applied to all three reviews.

Why is ldconfig in the %post for main package?

%clean can be removed.

rm at the begininng of %install looks strange.

All three specs look great...

[Bug 1196827] Review Request: postbooks - PostgreSQL-based accounting and ERP suite, Qt-based desktop version

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196827

--- Comment #3 from Gil Moskowitz  ---
https://github.com/xtuple/qt-client/pull/684 addressing review comments has
been merged

[Bug 1196827] Review Request: postbooks - PostgreSQL-based accounting and ERP suite, Qt-based desktop version

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196827

--- Comment #4 from Daniel Pocock  ---
Spec URL: https://secure.trendhosting.net/fedora/fedora/postbooks.spec
SRPM URL: https://secure.trendhosting.net/fedora/postbooks-4.8.1-1.fc21.src.rpm

[Bug 1196827] Review Request: postbooks - PostgreSQL-based accounting and ERP suite, Qt-based desktop version

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196827

--- Comment #5 from Daniel Pocock  ---
Thanks all, the specs and new src RPM URLs have been added

[Bug 1196827] Review Request: postbooks - PostgreSQL-based accounting and ERP suite, Qt-based desktop version

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196827

--- Comment #6 from Daniel Pocock  ---
Latest SRPM:

Spec URL: https://secure.trendhosting.net/fedora/fedora/postbooks.spec
SRPM URL: https://secure.trendhosting.net/fedora/postbooks-4.8.2-1.fc21.src.rpm

Note: upstream hasn't actually tagged 4.8.2 yet, but the desktop file is in his
repository so the SRPM has been built from a snapshot of the 4_8_x branch. 
Upstream will probably tag 4.8.2 if there are no other changes requested for
Fedora to approve the package.

[Bug 1196827] Review Request: postbooks - PostgreSQL-based accounting and ERP suite, Qt-based desktop version

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196827

--- Comment #7 from Zbigniew Jędrzejewski-Szmek  ---
Issues:

This package should have an appdata file [1]. It's not mandatory, just strongly
encouraged, but I think it would be really nice for postbooks to show up
prominently in gnome software.

[1] https://fedoraproject.org/wiki/Packaging:AppData

postbooks-libs hath no license.

The same as in other packages:
- xpm is deprecated and the icon is awfully small.
- /usr/share/applications/postbooks.desktop: warning: key "Encoding" in group
"Desktop Entry" is deprecated

Apart from that, things seem mostly kosher.

rpmlint:
postbooks.src: W: spelling-error Summary(en_US) xTuple -> sextuplet
postbooks.src: W: summary-not-capitalized C xTuple Accounting/ERP suite desktop
client
postbooks.src: W: spelling-error %description -l en_US xTuple -> sextuplet
postbooks.src:77: W: macro-in-comment %{buildroot}
postbooks.src:78: W: macro-in-comment %{buildroot}
postbooks.src:78: W: macro-in-comment %{_libdir}
postbooks.src: W: invalid-url Source0:
https://github.com/xtuple/qt-client/archive/v4.8.2.tar.gz HTTP Error 404: Not
Found
1 packages and 0 specfiles checked; 0 errors, 7 warnings.

postbooks.x86_64: W: spelling-error Summary(en_US) xTuple -> sextuplet
postbooks.x86_64: W: summary-not-capitalized C xTuple Accounting/ERP suite
desktop client
postbooks.x86_64: W: spelling-error %description -l en_US xTuple -> sextuplet
postbooks.x86_64: W: incoherent-version-in-changelog 4.8.1-1 ['4.8.2-1.fc22',
'4.8.2-1']
postbooks.x86_64: W: no-documentation
postbooks.x86_64: W: no-manual-page-for-binary xtuple
postbooks.x86_64: W: no-manual-page-for-binary postbooks
postbooks-libs.x86_64: W: spelling-error %description -l en_US xTuple ->
sextuplet
postbooks-libs.x86_64: W: spelling-error %description -l en_US libpostbooks ->
pocketbooks
postbooks-libs.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libxtuplecommon.so.1.0.0 /lib64/libQtXmlPatterns.so.4
postbooks-libs.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libxtuplecommon.so.1.0.0 /lib64/libpthread.so.0
postbooks-libs.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libxtuplecommon.so.1.0.0 /lib64/libm.so.6
postbooks-libs.x86_64: W: no-documentation

All ignorable.

[Bug 1196827] Review Request: postbooks - PostgreSQL-based accounting and ERP suite, Qt-based desktop version

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196827

--- Comment #8 from Daniel Pocock  ---

The SRPM has been updated again:

Spec URL: https://secure.trendhosting.net/fedora/fedora/postbooks.spec
SRPM URL: https://secure.trendhosting.net/fedora/postbooks-4.8.2-1.fc21.src.rpm

[Bug 1196827] Review Request: postbooks - PostgreSQL-based accounting and ERP suite, Qt-based desktop version

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196827

Zbigniew Jędrzejewski-Szmek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

--- Comment #9 from Zbigniew Jędrzejewski-Szmek  ---
Still there:
> postbooks-libs hath no license.

Please fix that.

Apart from the above, no issues. Package is APPROVED.

[Bug 1196827] Review Request: postbooks - PostgreSQL-based accounting and ERP suite, Qt-based desktop version

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196827

Daniel Pocock  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-cvs?

--- Comment #10 from Daniel Pocock  ---
New Package SCM Request
=======================
Package Name: postbooks
Short Description: Postbooks multi-user accounting, CRM and ERP suite
Upstream URL: https://github.com/xtuple/qt-client
Owners: pocock
Branches: f20 f21 f22 el6 epel7

[Bug 1196827] Review Request: postbooks - PostgreSQL-based accounting and ERP suite, Qt-based desktop version

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196827

Jon Ciesla  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-cvs?                 |fedora-cvs+

[Bug 1196827] Review Request: postbooks - PostgreSQL-based accounting and ERP suite, Qt-based desktop version

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196827

--- Comment #11 from Jon Ciesla  ---
Git done (by process-git-requests).

[Bug 1196827] Review Request: postbooks - PostgreSQL-based accounting and ERP suite, Qt-based desktop version

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196827

--- Comment #12 from Zbigniew Jędrzejewski-Szmek  ---
So, what's the status here? Would be great to do the last step and put the
package in the hands of users :)

[Bug 1196827] Review Request: postbooks - PostgreSQL-based accounting and ERP suite, Qt-based desktop version

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196827

--- Comment #13 from Daniel Pocock  ---

Updates were pushed for fc20, fc21 and fc22:

https://admin.fedoraproject.org/updates/postbooks

Is any further action needed for these versions or for it to appear in Fedora
23?

[Bug 1196827] Review Request: postbooks - PostgreSQL-based accounting and ERP suite, Qt-based desktop version

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196827

Zbigniew Jędrzejewski-Szmek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
   Fixed In Version|                            |postbooks-4.8.2-1.fc22
         Resolution|---                         |ERRATA
        Last Closed|                            |2015-06-27 14:16:44

--- Comment #14 from Zbigniew Jędrzejewski-Szmek  ---
Ah, OK. The review bug number is normally added to the newpackage update, so
the review bug is automatically closed when it goes stable. So no, everything
is OK, I just didn't know about the updates.

[Bug 1196827] Review Request: postbooks - PostgreSQL-based accounting and ERP suite, Qt-based desktop version

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196827
Bug 1196827 depends on bug 1196782, which changed state.

Bug 1196782 Summary: Review Request: xtuple-csvimp - xTuple / PostBooks data import utility
https://bugzilla.redhat.com/show_bug.cgi?id=1196782

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|---                         |ERRATA

[Bug 1196827] Review Request: postbooks - PostgreSQL-based accounting and ERP suite, Qt-based desktop version

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196827
Bug 1196827 depends on bug 1196780, which changed state.

Bug 1196780 Summary: Review Request: xtuple-openrpt - reporting tool for xTuple / PostBooks
https://bugzilla.redhat.com/show_bug.cgi?id=1196780

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|---                         |ERRATA