Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=376531
Summary: Review Request: <perl-Dir-Which> - <Search for directory entries in a list of directories> Product: Fedora Version: devel Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: jacquelin.charbonnel@math.cnrs.fr QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com
Spec URL: http://math.univ-angers.fr/RPMS/Dir-Which.spec SRPM URL: http://math.univ-angers.fr/RPMS/perl-Dir-Which-0.3-1.src.rpm Description: <Search for directory entries in a list of directories. This module searches directory entries (files, dirs, links, named pipes...) in a list of directories specified as a path-like string. The path string can be specified in an environment variable or as an argument.>
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: <perl-Dir-Which> - <Search for directory entries in a list of directories>
https://bugzilla.redhat.com/show_bug.cgi?id=376531
jacquelin.charbonnel@math.cnrs.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: <perl-Dir- |Review Request: <perl-Dir- |Which> - <Search for |Which> - <Search for |directory entries in a list |directory entries in a list |of directories> |of directories>
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Dir-Which - Search for directory entries in a list of directories
https://bugzilla.redhat.com/show_bug.cgi?id=376531
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: <perl-Dir- |Review Request: perl-Dir- |Which> - <Search for |Which - Search for directory |directory entries in a list |entries in a list of |of directories> |directories
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: perl-Dir-Which - Search for directory entries in a list of directories
https://bugzilla.redhat.com/show_bug.cgi?id=376531
jacquelin.charbonnel@math.cnrs.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |177841 nThis| | Summary|Review Request: perl-Dir- |perl-Dir-Which - Search for |Which - Search for directory|directory entries in a list |entries in a list of |of directories |directories |
------- Additional Comments From jacquelin.charbonnel@math.cnrs.fr 2007-11-16 16:03 EST ------- this is my first package and I need a sponsor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: perl-Dir-Which - Search for directory entries in a list of directories
https://bugzilla.redhat.com/show_bug.cgi?id=376531
------- Additional Comments From tibbs@math.uh.edu 2007-11-17 23:50 EST ------- Hmm, cpanspec sure seems to generate prettier Perl module specfiles than cpan2rpm. Honestly it would be much simpler if you installed cpanspec, ran "cpanspec Dir::Which", change License: as appropriate and add BuildRequires: perl(Test::More) perl(Test::Pod) perl(Test::Pod::Coverage) to get a perfectly acceptable package.
I'll go ahead and review the current package, but there are very many negative comments. To find more information about many of these, you can consult the packaging guidelines at http://fedoraproject.org/wiki/Packaging/Guidelines.
It's not usual Fedora style to have all of the specfile tags in lower case, but it's OK.
Don't use Packager:.
You aren't using the %dist tag in your Release. It's not mandatory, but for a new packager it's recommended. I'd ask that you demonstrate that you understand how to manage a package across multiple releases without it. See http://fedoraproject.org/wiki/Packaging/DistTag for more information.
Don't use Vendor:.
The License: tag isn't proper; see http://fedoraproject.org/Licensing for proper license tags. Also note that the CPAN page lists a completely different license.
The URL: should point to something relevant to the package, not just to the CPAN main page. Probably http://search.cpan.org/dist/Dir-Which/.
BuildRoot: is not proper; please use one of the approved BuildRoots: or at least include %{release}.
Don't use Prefix:
You are missing the proper dependency on perl(:MODULE_COMPAT_...).
I am not sure why the complicated %build section is needed. Why all of the grep and xargs stuff? Does it not suffice to do the usual %{__perl} Build.PL installdirs=vendor ./Build ? And the "Build test" call goes in %check, not in %build.
%install should not ever call brp-compress.
The entire "SuSE Linux" stuff should all go; this is a Fedora package.
I don't even inderstand the block starting with "%{__perl} -MFile::Find -le '"; why is it needed?
%install and %clean don't need to check that the buildroot isn't "/"; you set it to something other than "/" earlier in the spec.
I put the cpanspec-generated spec at http://www.math.uh.edu/~tibbs/perl-Dir-Which.spec
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: perl-Dir-Which - Search for directory entries in a list of directories
https://bugzilla.redhat.com/show_bug.cgi?id=376531
------- Additional Comments From jacquelin.charbonnel@math.cnrs.fr 2007-11-18 06:48 EST ------- (In reply to comment #2)
Hmm, cpanspec sure seems to generate prettier Perl module specfiles than cpan2rpm. Honestly it would be much simpler if you installed cpanspec, ran "cpanspec Dir::Which", change License: as appropriate and add BuildRequires: perl(Test::More) perl(Test::Pod) perl(Test::Pod::Coverage) to get a perfectly acceptable package.
Done. Thank you.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: perl-Dir-Which - Search for directory entries in a list of directories
https://bugzilla.redhat.com/show_bug.cgi?id=376531
jacquelin.charbonnel@math.cnrs.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: perl-Dir-Which - Search for directory entries in a list of directories
https://bugzilla.redhat.com/show_bug.cgi?id=376531
------- Additional Comments From jacquelin.charbonnel@math.cnrs.fr 2007-11-24 13:55 EST ------- What must I do now ?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: perl-Dir-Which - Search for directory entries in a list of directories
https://bugzilla.redhat.com/show_bug.cgi?id=376531
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|devel |rawhide
------- Additional Comments From panemade@gmail.com 2007-12-16 10:52 EST ------- *** Bug 425817 has been marked as a duplicate of this bug. ***
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: perl-Dir-Which - Search for directory entries in a list of directories
https://bugzilla.redhat.com/show_bug.cgi?id=376531
------- Additional Comments From panemade@gmail.com 2007-12-16 10:52 EST ------- *** Bug 425814 has been marked as a duplicate of this bug. ***
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: perl-Dir-Which - Search for directory entries in a list of directories
https://bugzilla.redhat.com/show_bug.cgi?id=376531
------- Additional Comments From panemade@gmail.com 2007-12-16 11:02 EST ------- Jacquelin, Will you please provide updated SPEC and SRPM links here that should resolve issues raised in comment #2?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: perl-Dir-Which - Search for directory entries in a list of directories
https://bugzilla.redhat.com/show_bug.cgi?id=376531
------- Additional Comments From jacquelin.charbonnel@math.cnrs.fr 2007-12-17 04:21 EST ------- (In reply to comment #7)
Jacquelin, Will you please provide updated SPEC and SRPM links here that should resolve issues raised in comment #2?
Yes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: perl-Dir-Which - Search for directory entries in a list of directories
https://bugzilla.redhat.com/show_bug.cgi?id=376531
------- Additional Comments From jacquelin.charbonnel@math.cnrs.fr 2007-12-23 12:41 EST ------- What must I do now, to continue the processus of validation ?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: perl-Dir-Which - Search for directory entries in a list of directories
https://bugzilla.redhat.com/show_bug.cgi?id=376531
rjones@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |rjones@redhat.com Status|MODIFIED |ASSIGNED Flag| |fedora-review?
------- Additional Comments From rjones@redhat.com 2008-02-28 14:49 EST ------- Starting review.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: perl-Dir-Which - Search for directory entries in a list of directories
https://bugzilla.redhat.com/show_bug.cgi?id=376531
------- Additional Comments From rjones@redhat.com 2008-02-28 15:07 EST ------- + rpmlint output rpmlint is clean + package name satisfies the packaging naming guidelines + specfile name matches the package base name - package should satisfy packaging guidelines should filter provides/requires (http://fedoraproject.org/wiki/Packaging/Perl) + license meets guidelines and is acceptable to Fedora + license matches the actual package license + %doc includes license file + spec file written in American English + spec file is legible + upstream sources match sources in the srpm md5 a5af1ec69180f9b54e9b07cf4cb8bada + package successfully builds on at least one architecture i386 + ExcludeArch bugs filed N/A + BuildRequires list all build dependencies + %find_lang instead of %{_datadir}/locale/* N/A + binary RPM with shared library files must call ldconfig in %post and %postun N/A + does not use Prefix: /usr + package owns all directories it creates + no duplicate files in %files + %defattr line + %clean contains rm -rf $RPM_BUILD_ROOT + consistent use of macros + package must contain code or permissible content + large documentation files should go in -doc subpackage N/A docs are small + files marked %doc should not affect package + header files should be in -devel N/A + static libraries should be in -static N/A + packages containing pkgconfig (.pc) files need 'Requires: pkgconfig' N/A + libfoo.so must go in -devel N/A + -devel must require the fully versioned base N/A + packages should not contain libtool .la files N/A + packages containing GUI apps must include %{name}.desktop file N/A + packages must not own files or directories owned by other packages N/A + %install must start with rm -rf %{buildroot} etc. + filenames must be valid UTF-8
Optional:
+ if there is no license file, packager should query upstream + translations of description and summary for non-English languages, if available ? reviewer should build the package in mock ? the package should build into binary RPMs on all supported architectures + review should test the package functions as described scriptlets should be sane + pkgconfig files should go in -devel + shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or /usr/sbin
--------
Please take a look at the Perl packaging guidelines. I'm not sure about this requirement for filtering provides & requires and as such I've just raised a question on fedora-packaging:
https://www.redhat.com/archives/fedora-packaging/2008-February/msg00111.html
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: perl-Dir-Which - Search for directory entries in a list of directories
https://bugzilla.redhat.com/show_bug.cgi?id=376531
rjones@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From rjones@redhat.com 2008-02-28 15:41 EST ------- OK, turns out that the provides and requires are fine for this package.
APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=376531
Richard W.M. Jones rjones@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo?(jacquelin.charbon | |nel@math.cnrs.fr)
--- Comment #13 from Richard W.M. Jones rjones@redhat.com 2008-09-09 09:46:55 EDT --- This has been reviewed for quite a while, but the reporter didn't get sponsorship and/or needs to file a CVS request.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=376531
Itamar Reis Peixoto itamar@ispbrasil.com.br changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |itamar@ispbrasil.com.br Alias| |perl-Dir-Which
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=376531
Richard W.M. Jones rjones@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |DEFERRED Flag|needinfo?(jacquelin.charbon | |nel@math.cnrs.fr) |
--- Comment #14 from Richard W.M. Jones rjones@redhat.com 2009-03-10 11:09:44 EDT --- Closing out.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=376531
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|177841(FE-NEEDSPONSOR) |201449(FE-DEADREVIEW)
package-review@lists.fedoraproject.org