https://bugzilla.redhat.com/show_bug.cgi?id=1875495
Bug ID: 1875495 Summary: Review Request: python-ee - Port of node.js's EventEmitter to Python Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: mail@fabian-affolter.ch QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-ee.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-ee-7.0.2-1.fc32.src.rpm
Project URL: https://github.com/jfhbrook/pyee
Description: pyee supplies a BaseEventEmitter object that is similar to the EventEmitter class from Node.js. It also supplies a number of sub classes with added support for async and threaded programming in Python, such as async/await.
Koji scratch build: fails due to missing dependency
rpmlint output: $ rpmlint python-ee-7.0.2-1.fc32.src.rpm python-ee.src: W: spelling-error Summary(en_US) js's -> dis's, As's, Os's python-ee.src: W: spelling-error %description -l en_US pyee -> pyre, pee, payee python-ee.src: W: spelling-error %description -l en_US js -> dis, ks, j python-ee.src: W: spelling-error %description -l en_US async -> sync, a sync 1 packages and 0 specfiles checked; 0 errors, 4 warnings.
$ rpmlint python3-ee-7.0.2-1.fc32.noarch.rpm python3-ee.noarch: W: spelling-error Summary(en_US) js's -> dis's, As's, Os's python3-ee.noarch: W: spelling-error %description -l en_US js -> dis, ks, j python3-ee.noarch: W: spelling-error %description -l en_US async -> sync, a sync 1 packages and 0 specfiles checked; 0 errors, 3 warnings.
Fedora Account System Username: fab
https://bugzilla.redhat.com/show_bug.cgi?id=1875495
Fabian Affolter mail@fabian-affolter.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1856163
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1856163 [Bug 1856163] Review Request: python-vcversioner - Use version control tags to discover version numbers
https://bugzilla.redhat.com/show_bug.cgi?id=1875495
Robert-André Mauchin 🐧 zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |zebob.m@gmail.com Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Doc Type|--- |If docs needed, set a value Flags| |fedora-review+
--- Comment #1 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- + /usr/bin/pytest -v tests ============================= test session starts ============================== platform linux -- Python 3.9.0rc1, pytest-6.0.1, py-1.9.0, pluggy-0.13.1 -- /usr/bin/python3 cachedir: .pytest_cache rootdir: /builddir/build/BUILD/pyee-7.0.2 plugins: asyncio-0.14.0, trio-0.6.0 collecting ... collected 4 items / 5 errors
E ModuleNotFoundError: No module named 'mock' * 5
Add BR:
BuildRequires: python3dist(mock)
Package approved, please fix the aforementioned issue before import.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Expat License", "*No copyright* Expat License". 22 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/python-ee/review-python- ee/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: python3-ee-7.0.2-1.fc34.noarch.rpm python-ee-7.0.2-1.fc34.src.rpm python3-ee.noarch: W: spelling-error Summary(en_US) js's -> dis's, As's, Os's python3-ee.noarch: W: spelling-error %description -l en_US js -> dis, ks, j python3-ee.noarch: W: spelling-error %description -l en_US async -> sync, a sync python-ee.src: W: spelling-error Summary(en_US) js's -> dis's, As's, Os's python-ee.src: W: spelling-error %description -l en_US pyee -> pyre, pee, payee python-ee.src: W: spelling-error %description -l en_US js -> dis, ks, j python-ee.src: W: spelling-error %description -l en_US async -> sync, a sync 2 packages and 0 specfiles checked; 0 errors, 7 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1875495
--- Comment #2 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-ee
https://bugzilla.redhat.com/show_bug.cgi?id=1875495
Fabian Affolter mail@fabian-affolter.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1877359
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1877359 [Bug 1877359] Review Request: python-thingserver - HTTP Web Thing implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1875495 Bug 1875495 depends on bug 1856163, which changed state.
Bug 1856163 Summary: Review Request: python-vcversioner - Use version control tags to discover version numbers https://bugzilla.redhat.com/show_bug.cgi?id=1856163
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ASSIGNED Resolution|NOTABUG |---
https://bugzilla.redhat.com/show_bug.cgi?id=1875495
Peter Robinson pbrobinson@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |pbrobinson@gmail.com
--- Comment #3 from Peter Robinson pbrobinson@gmail.com --- This is already packaged as pyee: https://src.fedoraproject.org/rpms/pyee
https://bugzilla.redhat.com/show_bug.cgi?id=1875495
Peter Robinson pbrobinson@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(zebob.m@gmail.com | |)
--- Comment #4 from Peter Robinson pbrobinson@gmail.com --- A very basic "dnf list python3-ee" would have revealed this. I wonder why this wasn't picked up by the packager or the reviewer?
https://bugzilla.redhat.com/show_bug.cgi?id=1875495
Peter Robinson pbrobinson@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |DUPLICATE Last Closed| |2020-10-09 12:10:50
--- Comment #5 from Peter Robinson pbrobinson@gmail.com ---
*** This bug has been marked as a duplicate of bug 1433756 ***
https://bugzilla.redhat.com/show_bug.cgi?id=1875495 Bug 1875495 depends on bug 1856163, which changed state.
Bug 1856163 Summary: Review Request: python-vcversioner - Use version control tags to discover version numbers https://bugzilla.redhat.com/show_bug.cgi?id=1856163
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com