[Bug 239933] New: Review Request: perl-Danga-Socket - Event loop and event-driven async socket base class

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239933

Summary: Review Request: perl-Danga-Socket - Event loop and
                    event-driven async socket base class
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]

Spec URL: http://rubenkerkhof.com/packages/perl-Danga-Socket.spec
SRPM URL: http://rubenkerkhof.com/packages/perl-Danga-Socket-1.57-1.src.rpm

Description:
This is an abstract base class for objects backed by a socket which
provides the basic framework for event-driven asynchronous IO, designed to
be fast. Danga::Socket is both a base class for objects, and an event loop.

[Bug 239933] Review Request: perl-Danga-Socket - Event loop and event-driven async socket base class

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Danga-Socket - Event loop and event-driven async socket base class

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239933

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review?

------- Additional Comments From [e-mail]  2007-05-15 17:25 EST -------
This is failing for me because perl-Sys-Syscall hasn't been pushed.  I guess it
didn't get tagged for F7.  I stuffed it in a local repository and things build fine.

[Bug 239933] Review Request: perl-Danga-Socket - Event loop and event-driven async socket base class

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Danga-Socket - Event loop and event-driven async socket base class

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239933

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

------- Additional Comments From [e-mail]  2007-05-15 17:32 EST -------
My only suggestion is that you include the examples directory as %doc.  I don't
think this is a blocker, though.

* source files match upstream:
   919be5206f5e9dbff4a825a5bea3ed9f223629c2e969360a6228a929c838c7f5  
   Danga-Socket-1.57.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   perl(Danga::Socket) = 1.57
   perl(Danga::Socket::Timer)
   perl-Danga-Socket = 1.57-1.fc7
  =
   perl(:MODULE_COMPAT_5.8.8)
   perl(Carp)
   perl(Errno)
   perl(POSIX)
   perl(Socket)
   perl(Sys::Syscall)
   perl(Time::HiRes)
   perl(bytes)
   perl(constant)
   perl(fields)
   perl(strict)
   perl(vars)
   perl(warnings)

* %check is present and all tests pass:
   All tests successful.
   Files=4, Tests=59,  8 wallclock secs ( 0.22 cusr +  0.06 csys =  0.28 CPU)
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

[Bug 239933] Review Request: perl-Danga-Socket - Event loop and event-driven async socket base class

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Danga-Socket - Event loop and event-driven async socket base class

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239933

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

------- Additional Comments From [e-mail]  2007-05-16 04:16 EST -------
Thanks again Jason. I've included the examples in %doc.

New Package CVS Request
=======================
Package Name: perl-Danga-Socket
Short Description:  Event loop and event-driven async socket base class
Owners: [e-mail]
Branches: FC-5 FC-6

[Bug 239933] Review Request: perl-Danga-Socket - Event loop and event-driven async socket base class

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Danga-Socket - Event loop and event-driven async socket base class

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239933

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

[Bug 239933] Review Request: perl-Danga-Socket - Event loop and event-driven async socket base class

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Danga-Socket - Event loop and event-driven async socket base class

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239933

------- Additional Comments From [e-mail]  2007-06-07 19:29 EST -------
Is there some reason this ticket is still open?

[Bug 239933] Review Request: perl-Danga-Socket - Event loop and event-driven async socket base class

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Danga-Socket - Event loop and event-driven async socket base class

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239933

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

------- Additional Comments From [e-mail]  2007-06-08 07:16 EST -------
Oops, sorry

[Bug 239933] Review Request: perl-Danga-Socket - Event loop and event-driven async socket base class

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Danga-Socket - Event loop and event-driven async socket base class

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239933

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Product|Fedora Extras               |Fedora

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs+                 |fedora-cvs?

------- Additional Comments From [e-mail]  2007-08-06 16:36 EST -------
Package Change Request
======================
Package Name: perl-Danga-Socket
New Branches: EL-4 EL-5

[Bug 239933] Review Request: perl-Danga-Socket - Event loop and event-driven async socket base class

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Danga-Socket - Event loop and event-driven async socket base class

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239933

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

[Bug 239933] Review Request: perl-Danga-Socket - Event loop and event-driven async socket base class

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=239933

Petr Pisar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
               Flag|fedora-cvs+                 |fedora-cvs?

--- Comment #7 from Petr Pisar  2011-07-13 04:50:20 EDT ---
Package Change Request
======================
Package Name: perl-Danga-Socket
Branches: f15 f14
New InitialCC: perl-sig

Please add `perl-sig' to CC list for all Fedora branches as this is Perl
package.

[Bug 239933] Review Request: perl-Danga-Socket - Event loop and event-driven async socket base class

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=239933

--- Comment #8 from Jason Tibbitts  2011-07-13 08:07:14 EDT ---
The requested branches already exist.  Just what are you requesting here?

[Bug 239933] Review Request: perl-Danga-Socket - Event loop and event-driven async socket base class

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=239933

Petr Sabata  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #9 from Petr Sabata  2011-07-13 08:11:49 EDT ---
(In reply to comment #8)
> The requested branches already exist.  Just what are you requesting here?

Petr requested the addition of perl-sig to the CC list in those branches.

[Bug 239933] Review Request: perl-Danga-Socket - Event loop and event-driven async socket base class

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=239933

--- Comment #10 from Jon Ciesla  2011-07-15 10:01:09 EDT ---
This is now done via pkgdb.

[Bug 239933] Review Request: perl-Danga-Socket - Event loop and event-driven async socket base class

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=239933

--- Comment #11 from Petr Sabata  2011-07-15 10:34:38 EDT ---
(In reply to comment #10)
> This is now done via pkgdb.

We can now add other users to our packages?  How?

[Bug 239933] Review Request: perl-Danga-Socket - Event loop and event-driven async socket base class

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=239933

--- Comment #12 from Jason Tibbitts  2011-07-15 11:24:02 EDT ---
Real users can simply add themselves.  Other actions require an administrator.

[Bug 239933] Review Request: perl-Danga-Socket - Event loop and event-driven async socket base class

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=239933

--- Comment #13 from Petr Sabata  2011-07-15 11:34:41 EDT ---
(In reply to comment #12)
> Real users can simply add themselves.  Other actions require an administrator.

Which is what this request is about -- perl-sig is not a real user.

[Bug 239933] Review Request: perl-Danga-Socket - Event loop and event-driven async socket base class

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=239933

--- Comment #14 from Jason Tibbitts  2011-07-15 11:51:38 EDT ---
Hmm, I interpreted Jon's comment as "it's been done" but it seems that I was
incorrect.

Can you simply mail me a list of all of the packages where you want the CC
added and I'll add it?  Please note any packages where you don't want it done
on all of devel, f15 and f14.  I know there are many, and doing one request per
ticket is kind of overkill.