[Bug 1079732] New: Review Request: perl-Catalyst-Plugin-CustomErrorMessage - Catalyst plugin to have more cute error message

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1079732

Bug ID: 1079732
           Summary: Review Request:
                    perl-Catalyst-Plugin-CustomErrorMessage - Catalyst
                    plugin to have more cute error message
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Spec URL:
http://nierlein.com/fedora/perl-Catalyst-Plugin-CustomErrorMessage.spec
SRPM URL:
http://nierlein.com/fedora/perl-Catalyst-Plugin-CustomErrorMessage-0.06-1.fc...
Description: 
Catalyst::Plugin::CustomErrorMessage is a Catalyst Plugin that provides
more cute error message.
Fedora Account System Username: sni

Successful koji build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=6664977

This is my first review request, so i am asking hereby for a sponsor.

This perl module is required to proceed in #1069988

Related review request: #1079718

[Bug 1079732] Review Request: perl-Catalyst-Plugin-CustomErrorMessage - Catalyst plugin to have more cute error message

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1079732

Sven Nierlein  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |177841 (FE-NEEDSPONSOR)

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor

[Bug 1079732] Review Request: perl-Catalyst-Plugin-CustomErrorMessage - Catalyst plugin to have more cute error message

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1079732

Christopher Meng  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1069988

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1069988
[Bug 1069988] Review Request: naemon - Open Source Host, Service And
Network Monitoring Program

[Bug 1079732] Review Request: perl-Catalyst-Plugin-CustomErrorMessage - Catalyst plugin to have more cute error message

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1079732

--- Comment #1 from Sven Nierlein  ---
Updated spec file according to comments from the related bugs and
uploaded new files here:

http://nierlein.com/fedora/2014-04-06/perl-Catalyst-Plugin-CustomErrorMessag...
http://nierlein.com/fedora/2014-04-06/perl-Catalyst-Plugin-CustomErrorMessag...

[Bug 1079732] Review Request: perl-Catalyst-Plugin-CustomErrorMessage - Catalyst plugin to have more cute error message

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1079732

--- Comment #2 from Sven Nierlein  ---
Source RPM:
http://nierlein.com/fedora/2014-04-06/perl-Catalyst-Plugin-CustomErrorMessag...

[Bug 1079732] Review Request: perl-Catalyst-Plugin-CustomErrorMessage - Catalyst plugin to have more cute error message

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1079732

Christopher Meng  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Alias|                            |perl-Catalyst-Plugin-Custom
                   |                            |ErrorMessage

[Bug 1079732] Review Request: perl-Catalyst-Plugin-CustomErrorMessage - Catalyst plugin to have more cute error message

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1079732

--- Comment #3 from Sven Nierlein  ---
new spec file:
http://nierlein.com/fedora/2014-04-21/perl-Catalyst-Plugin-CustomErrorMessag...

the only thing i changed is the release number.

[Bug 1079732] Review Request: perl-Catalyst-Plugin-CustomErrorMessage - Catalyst plugin to have more cute error message

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1079732

Ralf Corsepius  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Ralf Corsepius  ---
Missing [MUSTFIX]: 
Requires:  perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))

[Bug 1079732] Review Request: perl-Catalyst-Plugin-CustomErrorMessage - Catalyst plugin to have more cute error message

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1079732

David Dick  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
             Blocks|177841 (FE-NEEDSPONSOR)     |
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review?

--- Comment #5 from David Dick  ---
Taking this one

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor

[Bug 1079732] Review Request: perl-Catalyst-Plugin-CustomErrorMessage - Catalyst plugin to have more cute error message

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1079732

David Dick  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #6 from David Dick  ---
Hi Sven,

The following patch file (and comments) shows work to do on this spec file

--- perl-Catalyst-Plugin-CustomErrorMessage.old 2014-04-21 23:42:28.000000000
+1000
+++ perl-Catalyst-Plugin-CustomErrorMessage.proposed    2014-05-20
21:40:53.844909346 +1000
@@ -8,6 +8,8 @@
 Source0:       
http://search.cpan.org/CPAN/authors/id/J/JK/JKUTEJ/Catalyst-Plugin-CustomErr...
 BuildArch:      noarch
 BuildRequires:  perl
+BuildRequires:  perl(base) 
+BuildRequires:  perl(English)
 BuildRequires:  perl(Test::More)
 BuildRequires:  perl(ExtUtils::MakeMaker)
 BuildRequires:  perl(Carp::Clan)
@@ -15,7 +17,14 @@
 BuildRequires:  perl(Class::Data::Inheritable)
 BuildRequires:  perl(HTML::Entities)
 BuildRequires:  perl(MRO::Compat)
+BuildRequires:  perl(Pod::Coverage)
+BuildRequires:  perl(strict)
+BuildRequires:  perl(Test::Distribution)
+BuildRequires:  perl(Test::Pod)
+BuildRequires:  perl(Test::Pod::Coverage)
 BuildRequires:  perl(URI::Escape)
+BuildRequires:  perl(warnings)
+Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo
$version))

%description
 Catalyst::Plugin::CustomErrorMessage is a Catalyst Plugin that provides
@@ -39,8 +48,7 @@
 %files
 %{perl_vendorlib}/*
 %{_mandir}/man3/*
-%doc Changes
-%doc README
+%doc Changes README

%changelog
 * Sun Apr 06 2014 Sven Nierlein  0.06-2

Justifications follow

MUST FIX;

perl(base) is required at line 36 of lib/Catalyst/Plugin/CustomErrorMessage.pm
perl(English) is required at line 9 of
t/01-Catalyst-Plugin-CustomErrorMessage.t
perl(Pod::Coverage) is required in t/pod-coverage.t
perl(strict) is required at line 42 of
lib/Catalyst/Plugin/CustomErrorMessage.pm
perl(Test::Distribution) is required at line 3 of t/00-distribution.t
perl(Test::Pod) is required at line 9 of t/pod.t
perl(Test::Pod::Coverage) is required at line 7 of t/pod-coverage.t
perl(warnings) is required at line 43 of
lib/Catalyst/Plugin/CustomErrorMessage.pm

OPTIONAL;

The multiple %doc lines can safely be rolled into one line.

[Bug 1079732] Review Request: perl-Catalyst-Plugin-CustomErrorMessage - Catalyst plugin to have more cute error message

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1079732

--- Comment #7 from Sven Nierlein  ---
Thanks,

i added your changes here:
http://nierlein.com/fedora/2014-05-20/perl-Catalyst-Plugin-CustomErrorMessag...
http://nierlein.com/fedora/2014-05-20/perl-Catalyst-Plugin-CustomErrorMessag...

[Bug 1079732] Review Request: perl-Catalyst-Plugin-CustomErrorMessage - Catalyst plugin to have more cute error message

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1079732

David Dick  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

--- Comment #8 from David Dick  ---
Review results

License ok.

Build/Requires ok

no rpmlint warnings/errors

pure perl library

successful koji build at
http://koji.fedoraproject.org/koji/taskinfo?taskID=6868337

Package APPROVED

[Bug 1079732] Review Request: perl-Catalyst-Plugin-CustomErrorMessage - Catalyst plugin to have more cute error message

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1079732

Sven Nierlein  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-cvs?

--- Comment #9 from Sven Nierlein  ---
New Package SCM Request
=======================
Package Name: perl-Catalyst-Plugin-CustomErrorMessage
Short Description: Catalyst plugin to have more cute error message
Owners: sni
Branches: f21
InitialCC: perl-sig

[Bug 1079732] Review Request: perl-Catalyst-Plugin-CustomErrorMessage - Catalyst plugin to have more cute error message

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1079732

Jon Ciesla  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-cvs?                 |fedora-cvs+

[Bug 1079732] Review Request: perl-Catalyst-Plugin-CustomErrorMessage - Catalyst plugin to have more cute error message

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1079732

--- Comment #10 from Jon Ciesla  ---
Git done (by process-git-requests).

[Bug 1079732] Review Request: perl-Catalyst-Plugin-CustomErrorMessage - Catalyst plugin to have more cute error message

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1079732

--- Comment #11 from David Dick  ---
Hi Sven,

Just a ping for the git work on this package.

[Bug 1079732] Review Request: perl-Catalyst-Plugin-CustomErrorMessage - Catalyst plugin to have more cute error message

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1079732

Sven Nierlein  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
   Fixed In Version|                            |0.06-3
         Resolution|---                         |RAWHIDE
        Last Closed|                            |2014-06-05 15:02:51

--- Comment #12 from Sven Nierlein  ---
build and upload done