[Bug 190957] New: Review Request: php-pear-Net-Socket

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190957

Summary: Review Request: php-pear-Net-Socket
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: normal
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]

Spec URL: http://remi.collet.free.fr/rpms/extras/php-pear-Net-Socket.spec
SRPM URL: http://remi.collet.free.fr/rpms/extras/php-pear-Net-Socket-1.0.6-1.fc5.src.r...
Description: 
Net_Socket is a class interface to TCP sockets.  It provides blocking
and non-blocking operation, with different reading and writing modes
(byte-wise, block-wise, line-wise and special formats like network
byte-order ip addresses).

[Bug 190957] Review Request: php-pear-Net-Socket

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Net-Socket

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190957

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |190958
              nThis|                            |

[Bug 190957] Review Request: php-pear-Net-Socket

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Net-Socket

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190957

------- Additional Comments From [e-mail]  2006-05-20 12:17 EST -------
Spec URL: http://remi.collet.free.fr/rpms/extras/php-pear-Net-Socket.spec
SRPM URL:
http://remi.collet.free.fr/rpms/extras/php-pear-Net-Socket-1.0.6-2.fc5.src.r...
Mock build.log :
http://remi.collet.free.fr/rpms/extras/php-pear-Net-Socket-build.log

[Bug 190957] Review Request: php-pear-Net-Socket

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Net-Socket

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190957

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail] |[e-mail]
  BugsThisDependsOn|                            |190007
OtherBugsDependingO|163776                      |163778
              nThis|                            |

------- Additional Comments From [e-mail]  2006-06-27 05:56 EST -------
I will do a formal review on this package but you will not be able to check it
in until you are sponsered with bug #190007

[Bug 190957] Review Request: php-pear-Net-Socket

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Net-Socket
Alias: php-pear-Net-Socket

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190957

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Alias|                            |php-pear-Net-Socket

[Bug 190957] Review Request: php-pear-Net-Socket

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Net-Socket
Alias: php-pear-Net-Socket

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190957

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  BugsThisDependsOn|190007                      |

[Bug 190957] Review Request: php-pear-Net-Socket

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Net-Socket
Alias: php-pear-Net-Socket

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190957

------- Additional Comments From [e-mail]  2006-06-27 18:32 EST -------
MUST ITEM CHECKLIST:
- rpmlint output:
W: php-pear-Net-Socket invalid-license PHP License
W: php-pear-Net-Socket dangerous-command-in-%post install
W: php-pear-Net-Socket invalid-license PHP License

Warnings can be ignored

- package is named according to php packaging naming guidelines
- spec file name matches %{name}
- package meets packaging guidelines
- package is licensed with open source compatible license
- license field matches actual license
- source contains license file in %doc
- spec file is in American English (and french)
- spec file is legible
- sources match upstream
f961deffb093a58eb4c48478de1b27ed  Net_Socket-1.0.6.tgz
- package successfully compiles and builds on FC-5 x86_64
O This package is missing:
Requires(post):   php-pear >= 1.4.9
Requires(postun): php-pear >= 1.4.9
- package does not use locales
- package does not contain shared libraries in default paths (no need to run
ldconfig)
- package is not relocatable
- package does not own all directories it creates
It does not own the /usr/share/pear/Net directory.
- package does not contain any duplicate %files
- permissions are set properly
- package contains proper %clean section
- macro usage is consistant
- package contains permissible content
- package does not have large documentation
- package does not include header files or static libraries
- package does not use pkgconfig files
- package does not contain library with suffix
- package does not require a devel subpackage
- package does not contain any .la files
- package is not a gui and does not need a .desktop file
- package does not own files or directories owned by other packages
This may change in future.

MUST
- Must own the /usr/share/pear/Net directory add a %dir %{peardir}/Net
- Must Add:
Requires(post):   php-pear >= 1.4.9
Requires(postun): php-pear >= 1.4.9
- Explain why adding  || : in %post and %postun sections was added, should we
not fail if this step fails?
- Change %defattr to (-,root,root,-)
- Remove dist tages in changelog version numbers

[Bug 190957] Review Request: php-pear-Net-Socket

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Net-Socket
Alias: php-pear-Net-Socket

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190957

------- Additional Comments From [e-mail]  2006-06-28 05:40 EST -------
Also, please add php to the Requires as per the PHP packaging guidelines

[Bug 190957] Review Request: php-pear-Net-Socket

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Net-Socket
Alias: php-pear-Net-Socket

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190957

------- Additional Comments From [e-mail]  2006-09-02 03:30 EST -------
Spec: http://remi.collet.free.fr/rpms/extras/php-pear-Net-Socket.spec
SRPM: http://remi.collet.free.fr/rpms/extras/php-pear-Net-Socket-1.0.6-3.fc5.src.r...
Mock: http://remi.collet.free.fr/rpms/extras/php-pear-Net-Socket-build.log

Changes:
- install Licence in prep
- use new macros from /etc/rpm/macros.pear
- own /usr/share/pear/Net
- require php >= 4.3.0 (info from PHP_CompatInfo)

[Bug 190957] Review Request: php-pear-Net-Socket

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Net-Socket
Alias: php-pear-Net-Socket

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190957

------- Additional Comments From [e-mail]  2006-09-03 12:51 EST -------
Spec: http://remi.collet.free.fr/rpms/extras/php-pear-Net-Socket.spec
SRPM: http://remi.collet.free.fr/rpms/extras/php-pear-Net-Socket-1.0.6-4.fc5.src.r...
Mock: http://remi.collet.free.fr/rpms/extras/php-pear-Net-Socket-build.log

Changes:
- new and simpler %%prep and %%install

[Bug 190957] Review Request: php-pear-Net-Socket

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Net-Socket
Alias: php-pear-Net-Socket

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190957

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |

------- Additional Comments From [e-mail]  2006-09-03 20:04 EST -------
Change:
%defattr(-,root,root)

To:
%defattr(-,root,root,-)

After checking into CVS.  Approved.

[Bug 190957] Review Request: php-pear-Net-Socket

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Net-Socket
Alias: php-pear-Net-Socket

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190957

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

[Bug 190957] Review Request: php-pear-Net-Socket

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Net-Socket
Alias: php-pear-Net-Socket

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190957

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

------- Additional Comments From [e-mail]  2007-03-31 04:28 EST -------
Package Change Request
======================
Package Name: php-pear-Net-Socket
New Branches: EL-5

[Bug 190957] Review Request: php-pear-Net-Socket

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Net-Socket
Alias: php-pear-Net-Socket

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190957

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

------- Additional Comments From [e-mail]  2007-04-02 08:59 EST -------
done

[Bug 190957] Review Request: php-pear-Net-Socket

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Net-Socket
Alias: php-pear-Net-Socket

https://bugzilla.redhat.com/show_bug.cgi?id=190957

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|normal                      |medium
            Product|Fedora Extras               |Fedora
            Version|devel                       |rawhide