[Bug 177583] Review Request: zaptel-kmod

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: zaptel-kmod

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=177583

------- Additional Comments From [e-mail]  2006-10-04 09:13 EST -------
(In reply to comment #56)
> I already commented that someone else could do this, that's no surprise to me :-)
>
> I did not really consider the option that Linus would let us still be the
> official maintainers of Zaptel-in-the-kernel and thus we'd be responsible for
> merging all patches that come through other channels (unless we fail to do that
> job adequately).

That's basically the case, yes. Patches to well-maintained subsystems go through
the maintainers. Linus even rejected a patch from me to a USB driver I
comaintain a week or so ago, because it didn't go through the USB maintainer.

There are no guarantees, of course -- but basically I don't think you have
anything to worry about on that front.
> Given that, I'll talk to our people here and start the process,
> since that would allow us to maintain our licensing control where we need to.

That's excellent news -- thanks.
> However, given the current state of the code, I can guarantee that it won't get
> merged into the mainline kernel tree soon, as it does not currently meet kernel
> coding guidelines.

Indeed; that's one of the major reasons we insist on code being upstream before
we'll ship it.
> We'll need to get a kernel driver person working on cleaning
> up the code and preparing it for submission.

Let me know if you need assistance on this front. I have a disclaimer on file,
kernel hacking is what I do for fun after a hard day's work kernel hacking, and
my manager just told me to chase up the process of getting Asterisk into Fedora...

I still don't want a zaptel-kmod package, or indeed _any_ kmod package in
Extras. If/when it's good enough to ship and it's queued for 2.6.20 inclusion,
I'll probably just put it directly into the Fedora kernel. DaveJ approval
permitting, of course.