[Bug 206816] New: Review Request: freedoom-freedm - Deathmatch levels for freedoom

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206816

Summary: Review Request: freedoom-freedm - Deathmatch levels for
                    freedoom
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: normal
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]

Spec URL: http://www.kobold.org/~wart/fedora/freedoom-freedm.spec
SRPM URL: http://www.kobold.org/~wart/fedora/freedoom-freedm-0.5-1.src.rpm
Description: 
Multiplayer deathmatch levels for freedoom

[Bug 206816] Review Request: freedoom-freedm - Deathmatch levels for freedoom

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: freedoom-freedm - Deathmatch levels for freedoom

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206816

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail]    |[e-mail]
OtherBugsDependingO|163776                      |163778
              nThis|                            |

[Bug 206816] Review Request: freedoom-freedm - Deathmatch levels for freedoom

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: freedoom-freedm - Deathmatch levels for freedoom

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206816

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |

------- Additional Comments From [e-mail]  2006-09-23 00:35 EST -------
The source URL is failing for me; it's probably some sourceforge breakage.  I
specified a mirror (superb-west.dl.sourceforge.net) and it came through fine.

* source files match upstream:
   340a3e884729c22f45ff73353e2cc67a  freedoom-freedm-0.5.zip
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   freedoom-freedm = 0.5-1.fc6
  =
   freedoom
   prboom
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* game levels are acceptable content.
* documentation is small, so no -docs subpackage is necessary.
* desktop file is properly installed.

APPROVED

[Bug 206816] Review Request: freedoom-freedm - Deathmatch levels for freedoom

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: freedoom-freedm - Deathmatch levels for freedoom

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206816

------- Additional Comments From [e-mail]  2006-09-23 02:51 EST -------
I also tend to have problems downloading from sourceforge via curl or wget,
using various forms of the download URLs.  I haven't seen a perfect solution to
that problem yet.

Imported and built.  Thanks for the review!

[Bug 206816] Review Request: freedoom-freedm - Deathmatch levels for freedoom

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: freedoom-freedm - Deathmatch levels for freedoom

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206816

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

[Bug 206816] Review Request: freedoom-freedm - Deathmatch levels for freedoom

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: freedoom-freedm - Deathmatch levels for freedoom

https://bugzilla.redhat.com/show_bug.cgi?id=206816

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium
           Priority|normal                      |medium
            Product|Fedora Extras               |Fedora
            Version|devel                       |rawhide