[Bug 1080062] New: Review Request: pari-galpol - PARI/GP Computer Algebra System Galois polynomials
https://bugzilla.redhat.com/show_bug.cgi?id=1080062
Bug ID: 1080062 Summary: Review Request: pari-galpol - PARI/GP Computer Algebra System Galois polynomials Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: paul@city-fan.org QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://subversion.city-fan.org/repos/cfo-repo/pari-galpol/branches/fedora/pa... SRPM URL: http://www.city-fan.org/~paul/extras/pari/pari-galpol-20140218-1.fc21.src.rp... Description: This package contains the optional PARI package galpol, which contains a database of polynomials defining Galois extensions of the rationals representing all abstract groups of order up to 127 for all signatures (2429 polynomials).
Fedora Account System Username: pghmcfc
https://bugzilla.redhat.com/show_bug.cgi?id=1080062
Paulo Andrade paulo.cesar.pereira.de.andrade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |paulo.cesar.pereira.de.andr | |ade@gmail.com Assignee|nobody@fedoraproject.org |paulo.cesar.pereira.de.andr | |ade@gmail.com Flags| |fedora-review?
--- Comment #1 from Paulo Andrade paulo.cesar.pereira.de.andrade@gmail.com --- Only issue I see:
Multiple packages own %{_datadir}/pari/. Maybe it would be better to have only pari-gp owning it, and the data ones requring pari-gp. But this should be a minor cosmetic issue (that could start being "fixed" now).
Some extra comments:
rpmlint warns about several zero length files, and README tells they are used as a kind of flag in the database: ---%<--- a/b/non-wss: if present, then the group GAP4(a,b) is not weakly super-solvable, see ??galoisinit. ---%<--- so I presume this is ok.
Missing %check is not applicable as the package itself is required for pari %check.
https://bugzilla.redhat.com/show_bug.cgi?id=1080062
Paulo Andrade paulo.cesar.pereira.de.andrade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #2 from Paulo Andrade paulo.cesar.pereira.de.andrade@gmail.com --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/pari(pari-elldata, pari-galdata, pari-seadata, pari-gp) [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: pari-galpol-20140218-1.fc21.noarch.rpm pari-galpol-20140218-1.fc21.src.rpm pari-galpol.noarch: E: zero-length /usr/share/pari/galpol/120/35/non-wss pari-galpol.noarch: E: zero-length /usr/share/pari/galpol/120/5/non-wss pari-galpol.noarch: E: zero-length /usr/share/pari/galpol/96/227/non-wss pari-galpol.noarch: E: zero-length /usr/share/pari/galpol/60/5/non-wss pari-galpol.noarch: E: zero-length /usr/share/pari/galpol/56/11/non-wss pari-galpol.noarch: E: zero-length /usr/share/pari/galpol/80/49/non-wss pari-galpol.noarch: E: zero-length /usr/share/pari/galpol/96/204/non-wss pari-galpol.noarch: E: zero-length /usr/share/pari/galpol/96/203/non-wss pari-galpol.noarch: E: zero-length /usr/share/pari/galpol/96/64/non-wss pari-galpol.noarch: E: zero-length /usr/share/pari/galpol/120/34/non-wss pari-galpol.noarch: E: zero-length /usr/share/pari/galpol/108/15/non-wss pari-galpol.noarch: E: zero-length /usr/share/pari/galpol/48/3/non-wss pari-galpol.noarch: E: zero-length /usr/share/pari/galpol/96/229/non-wss pari-galpol.noarch: E: zero-length /usr/share/pari/galpol/96/71/non-wss pari-galpol.noarch: E: zero-length /usr/share/pari/galpol/108/37/non-wss pari-galpol.noarch: E: zero-length /usr/share/pari/galpol/72/45/non-wss pari-galpol.noarch: E: zero-length /usr/share/pari/galpol/72/41/non-wss pari-galpol.noarch: E: zero-length /usr/share/pari/galpol/96/68/non-wss pari-galpol.noarch: E: zero-length /usr/share/pari/galpol/75/2/non-wss pari-galpol.noarch: E: zero-length /usr/share/pari/galpol/36/9/non-wss pari-galpol.noarch: E: zero-length /usr/share/pari/galpol/96/3/non-wss pari-galpol.noarch: E: zero-length /usr/share/pari/galpol/96/72/non-wss pari-galpol.noarch: E: zero-length /usr/share/pari/galpol/72/19/non-wss pari-galpol.noarch: E: zero-length /usr/share/pari/galpol/108/36/non-wss pari-galpol.noarch: E: zero-length /usr/share/pari/galpol/72/39/non-wss pari-galpol.noarch: E: zero-length /usr/share/pari/galpol/96/70/non-wss pari-galpol.noarch: E: zero-length /usr/share/pari/galpol/112/41/non-wss pari-galpol.noarch: E: zero-length /usr/share/pari/galpol/72/40/non-wss pari-galpol.noarch: E: zero-length /usr/share/pari/galpol/48/50/non-wss 2 packages and 0 specfiles checked; 29 errors, 0 warnings.
Rpmlint (installed packages) ---------------------------- # rpmlint pari-galpol pari-galpol.noarch: E: zero-length /usr/share/pari/galpol/120/35/non-wss pari-galpol.noarch: E: zero-length /usr/share/pari/galpol/120/5/non-wss pari-galpol.noarch: E: zero-length /usr/share/pari/galpol/96/227/non-wss pari-galpol.noarch: E: zero-length /usr/share/pari/galpol/60/5/non-wss pari-galpol.noarch: E: zero-length /usr/share/pari/galpol/56/11/non-wss pari-galpol.noarch: E: zero-length /usr/share/pari/galpol/80/49/non-wss pari-galpol.noarch: E: zero-length /usr/share/pari/galpol/96/204/non-wss pari-galpol.noarch: E: zero-length /usr/share/pari/galpol/96/203/non-wss pari-galpol.noarch: E: zero-length /usr/share/pari/galpol/96/64/non-wss pari-galpol.noarch: E: zero-length /usr/share/pari/galpol/120/34/non-wss pari-galpol.noarch: E: zero-length /usr/share/pari/galpol/108/15/non-wss pari-galpol.noarch: E: zero-length /usr/share/pari/galpol/48/3/non-wss pari-galpol.noarch: E: zero-length /usr/share/pari/galpol/96/229/non-wss pari-galpol.noarch: E: zero-length /usr/share/pari/galpol/96/71/non-wss pari-galpol.noarch: E: zero-length /usr/share/pari/galpol/108/37/non-wss pari-galpol.noarch: E: zero-length /usr/share/pari/galpol/72/45/non-wss pari-galpol.noarch: E: zero-length /usr/share/pari/galpol/72/41/non-wss pari-galpol.noarch: E: zero-length /usr/share/pari/galpol/96/68/non-wss pari-galpol.noarch: E: zero-length /usr/share/pari/galpol/75/2/non-wss pari-galpol.noarch: E: zero-length /usr/share/pari/galpol/36/9/non-wss pari-galpol.noarch: E: zero-length /usr/share/pari/galpol/96/3/non-wss pari-galpol.noarch: E: zero-length /usr/share/pari/galpol/96/72/non-wss pari-galpol.noarch: E: zero-length /usr/share/pari/galpol/72/19/non-wss pari-galpol.noarch: E: zero-length /usr/share/pari/galpol/108/36/non-wss pari-galpol.noarch: E: zero-length /usr/share/pari/galpol/72/39/non-wss pari-galpol.noarch: E: zero-length /usr/share/pari/galpol/96/70/non-wss pari-galpol.noarch: E: zero-length /usr/share/pari/galpol/112/41/non-wss pari-galpol.noarch: E: zero-length /usr/share/pari/galpol/72/40/non-wss pari-galpol.noarch: E: zero-length /usr/share/pari/galpol/48/50/non-wss 1 packages and 0 specfiles checked; 29 errors, 0 warnings. # echo 'rpmlint-done:'
Requires -------- pari-galpol (rpmlib, GLIBC filtered):
Provides -------- pari-galpol: pari-galpol
Source checksums ---------------- http://pari.math.u-bordeaux.fr/pub/pari/packages/galpol.tgz : CHECKSUM(SHA256) this package : 20b7a4c19b60db8c05c157fe256bd2be35adc77650686d72f6a7cafc6df008f1 CHECKSUM(SHA256) upstream package : 20b7a4c19b60db8c05c157fe256bd2be35adc77650686d72f6a7cafc6df008f1 http://pari.math.u-bordeaux.fr/pub/pari/packages/galpol.tgz.asc : CHECKSUM(SHA256) this package : 2c8e334ea45dbe3b9fb98a09f98c55fc74374b0d631f7e1c9313f95d4959bcf3 CHECKSUM(SHA256) upstream package : 2c8e334ea45dbe3b9fb98a09f98c55fc74374b0d631f7e1c9313f95d4959bcf3
Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -b 1080062 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
https://bugzilla.redhat.com/show_bug.cgi?id=1080062
--- Comment #3 from Paul Howarth paul@city-fan.org --- (In reply to Paulo Andrade from comment #1)
Only issue I see:
Multiple packages own %{_datadir}/pari/. Maybe it would be better to have only pari-gp owning it, and the data ones requring pari-gp. But this should be a minor cosmetic issue (that could start being "fixed" now).
That would then result in circular build dependencies, e.g.:
pari => pari-galpol => pari-gp (which is built from pari)
So I think it's best to leave that as it is, as per the other pari data packages.
Some extra comments:
rpmlint warns about several zero length files, and README tells they are used as a kind of flag in the database: ---%<--- a/b/non-wss: if present, then the group GAP4(a,b) is not weakly super-solvable, see ??galoisinit. ---%<--- so I presume this is ok.
That's what I thought too. In fact, the package would be broken if we didn't include them.
I have a pari-2.7.0 build now but so far of the four packages I've tried building against it, three of them (Macaulay2, L-function, genus2reduction) failed and only eclib succeeded. Looks like this update may be quite a bit of work.
https://bugzilla.redhat.com/show_bug.cgi?id=1080062
Paul Howarth paul@city-fan.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #4 from Paul Howarth paul@city-fan.org --- New Package SCM Request ======================= Package Name: pari-galpol Short Description: PARI/GP Computer Algebra System Galois polynomials Owners: pghmcfc Branches: f19 f20
https://bugzilla.redhat.com/show_bug.cgi?id=1080062
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=1080062
--- Comment #5 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=1080062
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1080062
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- pari-galpol-20140218-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/pari-galpol-20140218-1.fc19
https://bugzilla.redhat.com/show_bug.cgi?id=1080062
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- pari-galpol-20140218-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/pari-galpol-20140218-1.fc20
https://bugzilla.redhat.com/show_bug.cgi?id=1080062
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- pari-galpol-20140218-1.fc19 has been pushed to the Fedora 19 testing repository.
https://bugzilla.redhat.com/show_bug.cgi?id=1080062
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |pari-galpol-20140218-1.fc19 Resolution|--- |ERRATA Last Closed| |2014-04-03 00:05:29
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- pari-galpol-20140218-1.fc19 has been pushed to the Fedora 19 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=1080062
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|pari-galpol-20140218-1.fc19 |pari-galpol-20140218-1.fc20
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- pari-galpol-20140218-1.fc20 has been pushed to the Fedora 20 stable repository.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla