Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904330
Bug ID: 904330 Summary: Review Request: perl-Data-Validate-IP - Ipv4 and ipv6 validation methods Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: unspecified Reporter: long@rule.lv
Spec URL: http://unibackup.rule.lv/FedoraRPM/perl-Data-Validate-IP.spec SRPM URL: http://unibackup.rule.lv/FedoraRPM/perl-Data-Validate-IP-0.14-1.fc16.src.rpm Description: This module collects ip validation routines to make input validation, and untainting easier and more readable.
All functions return an untainted value if the test passes, and undef if it fails. This means that you should always check for a defined status explicitly. Don't assume the return will be true. (e.g. is_username('0'))
The value to test is always the first (and often only) argument.
Fedora Account System Username: normunds
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904330
Normunds long@rule.lv changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841 (FE-NEEDSPONSOR)
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904330
--- Comment #1 from Normunds long@rule.lv --- All packages mentioned below were tested with rpmlint, mock (for i386 arch) and koji (16, 17, 18, 19, rawhide). These are my first packages for Fedora, so if you find something to improve in one of them, don't bother, I'll check other packages for reported problems.
Need sponsor.
bug 903824 perl-Convert-Age.spec bug 903826 perl-Net-Domain-TLD.spec bug 903829 perl-Time-Interval.spec bug 904328 perl-Config-ApacheFormat.spec bug 904329 perl-Data-Validate-Domain.spec bug 904330 perl-Data-Validate-IP.spec bug 904331 perl-Shell.spec
Thanks.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904330
Petr Šabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |psabata@redhat.com Blocks|177841 (FE-NEEDSPONSOR) |
--- Comment #2 from Petr Šabata psabata@redhat.com --- Removing FE-NEEDSPONSOR.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904330
--- Comment #3 from Normunds fedorapkg@rule.lv --- Specfiles and packages updated according to lessons learned from the following reviewed bugs:
Bug 903824 bug 903829 bug 904328
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904330
Petr Šabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |psabata@redhat.com Flags| |fedora-review?
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904330
--- Comment #4 from Petr Šabata psabata@redhat.com --- Ok, here are some notes from me :)
23 %description 24 This module collects ip validation routines to make input validation, and 25 untainting easier and more readable. 26 27 All functions return an untainted value if the test passes, and undef if it 28 fails. This means that you should always check for a defined status explicitly. 29 Don't assume the return will be true. (e.g. is_username('0')) 30 31 The value to test is always the first (and often only) argument.
I'd keep only the first sentence (lines 24-25), the rest is too technical for a description. Also, substitute "ip" with "IP address".
36 find lib -name "*.pm" -exec chmod -c a-x {} +
Not needed here. Could be removed.
2 Version: 0.14
A new version, 0.18, came out yesterday. Please, update the package.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904330
--- Comment #5 from Normunds fedorapkg@rule.lv --- Thank you for your review :)
* Description fixed * Unneeded chmod a-x removed. * Updated to version 0.18, ran tests. * Added perl(NetAddr::IP) build dependency as it is required in new module.
Best regards
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904330
--- Comment #6 from Petr Šabata psabata@redhat.com --- (In reply to comment #5)
Thank you for your review :)
- Description fixed
Ack.
- Unneeded chmod a-x removed.
Ack.
- Updated to version 0.18, ran tests.
Ack.
- Added perl(NetAddr::IP) build dependency as it is required in new module.
Ack, but you'll also need those two:
perl(lib) perl(Scalar::Util)
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904330
--- Comment #7 from Normunds fedorapkg@rule.lv --- Ugh! How did I miss that?
* Added build dependencies lib, Scalar::Util * Changed Download URI as it was changed.
Thanks :)
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904330
Petr Šabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+
--- Comment #8 from Petr Šabata psabata@redhat.com --- Awesome, approving :)
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904330
Normunds fedorapkg@rule.lv changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #9 from Normunds fedorapkg@rule.lv --- Thank you. Requesting CVS.
New Package SCM Request ======================= Package Name: perl-Data-Validate-IP Short Description: Perl IP address validation routines Owners: normunds psabata Branches: f17 f18 InitialCC: perl-sig
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904330
--- Comment #10 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904330
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904330
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- perl-Data-Validate-IP-0.18-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/perl-Data-Validate-IP-0.18-1.fc17
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904330
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- perl-Data-Validate-IP-0.18-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/perl-Data-Validate-IP-0.18-1.fc18
https://bugzilla.redhat.com/show_bug.cgi?id=904330
Petr Šabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Fixed In Version| |perl-Data-Validate-IP-0.18- | |1.fc18 Resolution|--- |CURRENTRELEASE Last Closed| |2014-04-03 12:29:11
package-review@lists.fedoraproject.org