[Bug 904330] New: Review Request: perl-Data-Validate-IP - Ipv4 and ipv6 validation methods - package-review

List overview All Threads
Download

newer

[Bug 904330] New: Review Request: perl-Data-Validate-IP - Ipv4 and ipv6 validation methods

older

[Bug 901617] New: Review Request:...

[Bug 904328] New: Review Request:...

Red Hat Bugzilla

26 Jan 2013 26 Jan '13

10:05 a.m.

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904330

Bug ID: 904330 Summary: Review Request: perl-Data-Validate-IP - Ipv4 and ipv6 validation methods Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: unspecified Reporter: long@rule.lv

Spec URL: http://unibackup.rule.lv/FedoraRPM/perl-Data-Validate-IP.spec SRPM URL: http://unibackup.rule.lv/FedoraRPM/perl-Data-Validate-IP-0.14-1.fc16.src.rpm Description: This module collects ip validation routines to make input validation, and untainting easier and more readable.

All functions return an untainted value if the test passes, and undef if it fails. This means that you should always check for a defined status explicitly. Don't assume the return will be true. (e.g. is_username('0'))

The value to test is always the first (and often only) argument.

Fedora Account System Username: normunds

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2Nez5A81ka&a=cc_unsubscribe

Show replies by date

Red Hat Bugzilla

26 Jan 26 Jan

10:10 a.m.

New subject: [Bug 904330] Review Request: perl-Data-Validate-IP - Ipv4 and ipv6 validation methods

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904330

Normunds long@rule.lv changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841 (FE-NEEDSPONSOR)

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=n82EwOHR0t&a=cc_unsubscribe

Red Hat Bugzilla

10:18 a.m.

New subject: [Bug 904330] Review Request: perl-Data-Validate-IP - Ipv4 and ipv6 validation methods

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904330

--- Comment #1 from Normunds long@rule.lv --- All packages mentioned below were tested with rpmlint, mock (for i386 arch) and koji (16, 17, 18, 19, rawhide). These are my first packages for Fedora, so if you find something to improve in one of them, don't bother, I'll check other packages for reported problems.

Need sponsor.

bug 903824 perl-Convert-Age.spec bug 903826 perl-Net-Domain-TLD.spec bug 903829 perl-Time-Interval.spec bug 904328 perl-Config-ApacheFormat.spec bug 904329 perl-Data-Validate-Domain.spec bug 904330 perl-Data-Validate-IP.spec bug 904331 perl-Shell.spec

Thanks.

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Bkqtc3BW27&a=cc_unsubscribe

Red Hat Bugzilla

29 Jan 29 Jan

2:47 p.m.

New subject: [Bug 904330] Review Request: perl-Data-Validate-IP - Ipv4 and ipv6 validation methods

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904330

Petr Šabata psabata@redhat.com changed:

--- Comment #2 from Petr Šabata psabata@redhat.com --- Removing FE-NEEDSPONSOR.

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=RNOQXLCeX7&a=cc_unsubscribe

Red Hat Bugzilla

4 Feb 4 Feb

5:45 p.m.

New subject: [Bug 904330] Review Request: perl-Data-Validate-IP - Ipv4 and ipv6 validation methods

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904330

--- Comment #3 from Normunds fedorapkg@rule.lv --- Specfiles and packages updated according to lessons learned from the following reviewed bugs:

Bug 903824 bug 903829 bug 904328

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=useRyVV3I3&a=cc_unsubscribe

Red Hat Bugzilla

20 Feb 20 Feb

2:57 p.m.

New subject: [Bug 904330] Review Request: perl-Data-Validate-IP - Ipv4 and ipv6 validation methods

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904330

Petr Šabata psabata@redhat.com changed:

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9kMWCIYf4i&a=cc_unsubscribe

Red Hat Bugzilla

3:15 p.m.

New subject: [Bug 904330] Review Request: perl-Data-Validate-IP - Ipv4 and ipv6 validation methods

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904330

--- Comment #4 from Petr Šabata psabata@redhat.com --- Ok, here are some notes from me :)

...

23 %description 24 This module collects ip validation routines to make input validation, and 25 untainting easier and more readable. 26 27 All functions return an untainted value if the test passes, and undef if it 28 fails. This means that you should always check for a defined status explicitly. 29 Don't assume the return will be true. (e.g. is_username('0')) 30 31 The value to test is always the first (and often only) argument.

I'd keep only the first sentence (lines 24-25), the rest is too technical for a description. Also, substitute "ip" with "IP address".

...

36 find lib -name "*.pm" -exec chmod -c a-x {} +

Not needed here. Could be removed.

...

2 Version: 0.14

A new version, 0.18, came out yesterday. Please, update the package.

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tzU1Fkpv13&a=cc_unsubscribe

Red Hat Bugzilla

21 Feb 21 Feb

11:55 a.m.

New subject: [Bug 904330] Review Request: perl-Data-Validate-IP - Ipv4 and ipv6 validation methods

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904330

--- Comment #5 from Normunds fedorapkg@rule.lv --- Thank you for your review :)

* Description fixed * Unneeded chmod a-x removed. * Updated to version 0.18, ran tests. * Added perl(NetAddr::IP) build dependency as it is required in new module.

Best regards

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SawaCnuUOR&a=cc_unsubscribe

Red Hat Bugzilla

12:13 p.m.

New subject: [Bug 904330] Review Request: perl-Data-Validate-IP - Ipv4 and ipv6 validation methods

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904330

--- Comment #6 from Petr Šabata psabata@redhat.com --- (In reply to comment #5)

...

Thank you for your review :)

Description fixed

Ack.

...

Unneeded chmod a-x removed.

Ack.

...

Updated to version 0.18, ran tests.

Ack.

...

Added perl(NetAddr::IP) build dependency as it is required in new module.

Ack, but you'll also need those two:

perl(lib) perl(Scalar::Util)

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hkycpTHR91&a=cc_unsubscribe

Red Hat Bugzilla

12:49 p.m.

New subject: [Bug 904330] Review Request: perl-Data-Validate-IP - Ipv4 and ipv6 validation methods

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904330

--- Comment #7 from Normunds fedorapkg@rule.lv --- Ugh! How did I miss that?

* Added build dependencies lib, Scalar::Util * Changed Download URI as it was changed.

Thanks :)

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZBBx3WmLmc&a=cc_unsubscribe

Red Hat Bugzilla

12:53 p.m.

New subject: [Bug 904330] Review Request: perl-Data-Validate-IP - Ipv4 and ipv6 validation methods

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904330

Petr Šabata psabata@redhat.com changed:

--- Comment #8 from Petr Šabata psabata@redhat.com --- Awesome, approving :)

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=B0hCPILrr2&a=cc_unsubscribe

Red Hat Bugzilla

1:08 p.m.

New subject: [Bug 904330] Review Request: perl-Data-Validate-IP - Ipv4 and ipv6 validation methods

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904330

Normunds fedorapkg@rule.lv changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?

--- Comment #9 from Normunds fedorapkg@rule.lv --- Thank you. Requesting CVS.

New Package SCM Request ======================= Package Name: perl-Data-Validate-IP Short Description: Perl IP address validation routines Owners: normunds psabata Branches: f17 f18 InitialCC: perl-sig

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1zVCSHLZ6e&a=cc_unsubscribe

Red Hat Bugzilla

1:25 p.m.

New subject: [Bug 904330] Review Request: perl-Data-Validate-IP - Ipv4 and ipv6 validation methods

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904330

--- Comment #10 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1jhMQsGu3r&a=cc_unsubscribe

Red Hat Bugzilla

3:02 p.m.

New subject: [Bug 904330] Review Request: perl-Data-Validate-IP - Ipv4 and ipv6 validation methods

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904330

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vWRhGc9Z8V&a=cc_unsubscribe

Red Hat Bugzilla

3:02 p.m.

New subject: [Bug 904330] Review Request: perl-Data-Validate-IP - Ipv4 and ipv6 validation methods

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904330

--- Comment #11 from Fedora Update System updates@fedoraproject.org --- perl-Data-Validate-IP-0.18-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/perl-Data-Validate-IP-0.18-1.fc17

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zqEaIh2meu&a=cc_unsubscribe

Red Hat Bugzilla

3:18 p.m.

New subject: [Bug 904330] Review Request: perl-Data-Validate-IP - Ipv4 and ipv6 validation methods

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904330

--- Comment #12 from Fedora Update System updates@fedoraproject.org --- perl-Data-Validate-IP-0.18-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/perl-Data-Validate-IP-0.18-1.fc18

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=42CFFX2vnM&a=cc_unsubscribe

Red Hat Bugzilla

3 Apr 3 Apr

4:29 p.m.

New subject: [Bug 904330] Review Request: perl-Data-Validate-IP - Ipv4 and ipv6 validation methods

https://bugzilla.redhat.com/show_bug.cgi?id=904330

Petr Šabata psabata@redhat.com changed:

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

4128

Age (days ago)

4560

Last active (days ago)

package-review@lists.fedoraproject.org

16 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla