[Bug 2261953] New: Review Request: python-python-ulid - Universally unique lexicographically sortable identifier

https://bugzilla.redhat.com/show_bug.cgi?id=2261953

Bug ID: 2261953
           Summary: Review Request: python-python-ulid - Universally
                    unique lexicographically sortable identifier
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
            Blocks: 2261943
  Target Milestone: ---
    Classification: Fedora

Spec URL:
https://download.copr.fedorainfracloud.org/results/music/pydantic/fedora-raw...
SRPM URL:
https://download.copr.fedorainfracloud.org/results/music/pydantic/fedora-raw...

Description:

A ULID is a universally unique lexicographically sortable identifier. It is

• 128-bit compatible with UUID
  • 1.21e+24 unique ULIDs per millisecond
  • Lexicographically sortable!
  • Canonically encoded as a 26 character string, as opposed to the 36
    character UUID
  • Uses Crockford’s base32 for better efficiency and readability (5 bits per
    character)
  • Case insensitive
  • No special characters (URL safe)

For more information have a look at the original specification,
https://github.com/alizain/ulid#specification.

Fedora Account System Username: music

This is a dependency for python-pydantic-extra-types, beginning with version
2.2.0.

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2261943
[Bug 2261943] python-pydantic-extra-types-2.5.0 is available

[Bug 2261953] Review Request: python-python-ulid - Universally unique lexicographically sortable identifier

https://bugzilla.redhat.com/show_bug.cgi?id=2261953

Fedora Review Service  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |AutomationTriaged

--- Comment #1 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6973682
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2261953] Review Request: python-python-ulid - Universally unique lexicographically sortable identifier

https://bugzilla.redhat.com/show_bug.cgi?id=2261953

Ben Beasley  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends On|                            |2253574

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2253574
[Bug 2253574] python-pycountry-23.12.11 is available

[Bug 2261953] Review Request: python-python-ulid - Universally unique lexicographically sortable identifier

https://bugzilla.redhat.com/show_bug.cgi?id=2261953

Maxwell G  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
              Flags|                            |fedora-review?
             Status|NEW                         |ASSIGNED
           Assignee|[e-mail]    |[e-mail]
           Doc Type|---                         |If docs needed, set a value

--- Comment #2 from Maxwell G  ---
Hmm, this naming situation is a bit of mess, but you did handle it as best as
possible and in compliance with the guidelines.

Maxwell's Python Package Review Template
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

- [x] The License tag reflects the package contents and uses the correct
identifiers.
- [x] The license text is included and marked with %license.
- [x] The package builds successfully in mock.
- [x] The package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors.
- [x] The package runs tests in %check.
- [x] The latest version is packaged or packaging an earlier version is
justified.
- [x] The packager considers avoiding confusing `%foo_name` macros. (Not a
blocker)
- [x] Libraries: The package name has a `python3-` prefix and uses the
canonical project name
- [x] The pyproject macros are used.
- [x] There are no bundled libraries.
- [x] The package complies with the Python and general Packaging Guidelines.

Other problems:

- The URL is wrong. It should be https://github.com/mdomke/python-ulid as far
as I can tell.
- There are unicode quotes in the comment at the top of the specfile and
unicode bullet points in the common_description. I noticed because the Copr
specfile page apparently does not handle unicode encoding properly. I would
personally use standard ASCII quotes and * or - for bullet points, but that's
up to you.
- I would keep the ulid binary and add `Conflicts: golang-github-oklog-ulid` or
maybe rename it to /usr/bin/python-ulid. (I prefer the first solution but would
accept either.) I don't think removing it completely is the right solution.

Thanks!

[Bug 2261953] Review Request: python-python-ulid - Universally unique lexicographically sortable identifier

https://bugzilla.redhat.com/show_bug.cgi?id=2261953

Maxwell G  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends On|2253574                     |

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2253574
[Bug 2253574] python-pycountry-23.12.11 is available

[Bug 2261953] Review Request: python-python-ulid - Universally unique lexicographically sortable identifier

https://bugzilla.redhat.com/show_bug.cgi?id=2261953

--- Comment #3 from Ben Beasley  ---
(In reply to Maxwell G from comment #2)
> The URL is wrong. It should be https://github.com/mdomke/python-ulid as
>
> far as I can tell.

You’re right. I got sloppy editing the spec file I based this on. Thanks for
noticing. I’ll fix it.
> There are unicode quotes in the comment at the top of the specfile and
>
> unicode bullet points in the common_description. I noticed because the Copr
> specfile page apparently does not handle unicode encoding properly. I would
> personally use standard ASCII quotes and * or - for bullet points, but
> that's up to you.

I like nice Unicode glyphs, and I think we’re far enough into the 21st century
that we shouldn’t have to stick with ASCII, but I don’t feel really strongly
about it in this particular case. Since I plan to ask you to co-maintain this
package, I don’t mind hewing to your preference here.
> I would keep the ulid binary and add `Conflicts: golang-github-oklog-ulid`
>
> or maybe rename it to /usr/bin/python-ulid. (I prefer the first solution but
> would accept either.) I don't think removing it completely is the right
> solution.

The packaging guidelines are kind of bureaucratic here: they would like me to
first approach both upstreams about renaming[1], then once I have convinced
them both to respond and neither wants to change, either go try to build
consensus with all the other distros[1] or add the Conflicts, which I *have to
do in both packages*[2]. Obviously, I don’t want to block this review and the
python-pydantic-extra-types update on an extended discussion process. I’ll
start by filing the issues and seeing if there is a prompt response while I
consider what to do.

If I go ahead and add the Conflicts, I need to send a PR to
https://src.fedoraproject.org/rpms/golang-github-oklog-ulid to add it there,
too. I also need to consider whether the conflicting binary should be split
into its own subpackage separate from the library in order to reduce the scope
of the conflict, and if so, what I should call it? python-ulid-tool? I
shouldn’t use python-ulid for the subpackage name, because that is the same as
the base package name for a hypothetical future package of
https://pypi.org/project/ulid/, should it somehow spring back to life…

If I go ahead and rename the binary, things are a lot tidier, but I also feel
like I am straying farther from the guidelines by not trying to build a
cross-distro consensus first – but is this even practical when nobody else has
this problem right now? Here’s a quick survey of a few other distros:

- Arch has only the Python package, and it provides /usr/bin/ulid:
https://archlinux.org/packages/extra/any/python-ulid/
- openSUSE has neither package
- Debian and Ubuntu have only the golang package, and it includes only the
library, not /usr/bin/ulid:
https://packages.ubuntu.com/noble/all/golang-github-oklog-ulid-dev/filelist
- Gentoo has neither package

At the moment, I’m leaning toward the Conflicts, golang-github-oklog-ulid PR,
and tool subpackage approach.

[1]
https://docs.fedoraproject.org/en-US/packaging-guidelines/Conflicts/#_approa...
[2]
https://docs.fedoraproject.org/en-US/packaging-guidelines/Conflicts/#_incomp...

[Bug 2261953] Review Request: python-python-ulid - Universally unique lexicographically sortable identifier

https://bugzilla.redhat.com/show_bug.cgi?id=2261953

Ben Beasley  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Link ID|                            |Github
                   |                            |oklog/ulid/issues/111
                   |                            |Github
                   |                            |mdomke/python-ulid/issues/1
                   |                            |4

--- Comment #4 from Ben Beasley  ---
(In reply to Ben Beasley from comment #3)
> At the moment, I’m leaning toward the Conflicts, golang-github-oklog-ulid
> PR, and tool subpackage approach.

I’m still open to changes to the approach, and it’s possible that upstream will
step up quickly, but that approach could look like this:

New Spec URL:
https://download.copr.fedorainfracloud.org/results/music/pydantic/fedora-raw...
New SRPM URL:
https://download.copr.fedorainfracloud.org/results/music/pydantic/fedora-raw...

(Sometimes I hand-write man pages for binaries where help2man isn’t very
fruitful and the interface doesn’t change rapidly, and I would consider doing
that here, but I don’t really want to do it until I know if upstream will do
anything with the issues I filed.)

[Bug 2261953] Review Request: python-python-ulid - Universally unique lexicographically sortable identifier

https://bugzilla.redhat.com/show_bug.cgi?id=2261953

--- Comment #5 from Fedora Review Service  ---
Created attachment 2014199
  --> https://bugzilla.redhat.com/attachment.cgi?id=2014199&action=edit
The .spec file difference from Copr build 6973682 to 6976028

[Bug 2261953] Review Request: python-python-ulid - Universally unique lexicographically sortable identifier

https://bugzilla.redhat.com/show_bug.cgi?id=2261953

--- Comment #6 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6976028
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2261953] Review Request: python-python-ulid - Universally unique lexicographically sortable identifier

https://bugzilla.redhat.com/show_bug.cgi?id=2261953

--- Comment #7 from Ben Beasley  ---
In https://github.com/oklog/ulid/issues/111, upstream noted that the names of
go binaries aren’t fully under upstream control, suggested we build that
package’s binary as ulid-go instead. I’ve proposed this in
https://src.fedoraproject.org/rpms/golang-github-oklog-ulid/pull-request/1.
Please feel free to give feedback on that PR.

[Bug 2261953] Review Request: python-python-ulid - Universally unique lexicographically sortable identifier

https://bugzilla.redhat.com/show_bug.cgi?id=2261953

--- Comment #8 from Ben Beasley  ---
The conflict is resolved in F40+ by renaming the existing /usr/bin/ulid to
/usr/bin/ulid-go, so I moved the /usr/bin/ulid binary back into
python3-python-ulid and added man pages.

New Spec URL: https://music.fedorapeople.org/python-python-ulid.spec
New SRPM URL:
https://music.fedorapeople.org/python-python-ulid-2.2.0-1.fc39.src.rpm

[Bug 2261953] Review Request: python-python-ulid - Universally unique lexicographically sortable identifier

https://bugzilla.redhat.com/show_bug.cgi?id=2261953

--- Comment #9 from Fedora Review Service  ---
Created attachment 2014448
  --> https://bugzilla.redhat.com/attachment.cgi?id=2014448&action=edit
The .spec file difference from Copr build 6976028 to 6980420

[Bug 2261953] Review Request: python-python-ulid - Universally unique lexicographically sortable identifier

https://bugzilla.redhat.com/show_bug.cgi?id=2261953

--- Comment #10 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6980420
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2261953] Review Request: python-python-ulid - Universally unique lexicographically sortable identifier

https://bugzilla.redhat.com/show_bug.cgi?id=2261953

Maxwell G  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|fedora-review?              |fedora-review+

--- Comment #11 from Maxwell G  ---
This looks good to me, although do note that the Conflicts is in the wrong
place; it needs to be under the python3-python-ulid subpackage definition.
Please fix that on import. Other than that, package approved! On import, don't
forget to add the package to release-monitoring.org. You can give
@python-packagers-sig `commit` if you wish. I am also happy to co-maintain.

Thanks!

[Bug 2261953] Review Request: python-python-ulid - Universally unique lexicographically sortable identifier

https://bugzilla.redhat.com/show_bug.cgi?id=2261953

--- Comment #12 from Ben Beasley  ---
(In reply to Maxwell G from comment #11)
> This looks good to me,

Thanks!
> although do note that the Conflicts is in the wrong
> place; it needs to be under the python3-python-ulid subpackage definition.

Sigh… a classic mistake. Thanks for spotting it.
> Please fix that on import.

Will do.
> Other than that, package approved! On import,
> don't forget to add the package to release-monitoring.org. You can give
> @python-packagers-sig `commit` if you wish. I am also happy to co-maintain.
>
> Thanks!

Ok!

[Bug 2261953] Review Request: python-python-ulid - Universally unique lexicographically sortable identifier

https://bugzilla.redhat.com/show_bug.cgi?id=2261953

--- Comment #13 from Fedora Admin user for bugzilla script actions  ---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-python-ulid

[Bug 2261953] Review Request: python-python-ulid - Universally unique lexicographically sortable identifier

https://bugzilla.redhat.com/show_bug.cgi?id=2261953

--- Comment #14 from Ben Beasley  ---
https://release-monitoring.org/project/98094/

[Bug 2261953] Review Request: python-python-ulid - Universally unique lexicographically sortable identifier

https://bugzilla.redhat.com/show_bug.cgi?id=2261953

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |MODIFIED

--- Comment #15 from Fedora Update System  ---
FEDORA-2024-43dea391a0 has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-43dea391a0

[Bug 2261953] Review Request: python-python-ulid - Universally unique lexicographically sortable identifier

https://bugzilla.redhat.com/show_bug.cgi?id=2261953

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |CLOSED
         Resolution|---                         |ERRATA
        Last Closed|                            |2024-02-05 16:15:24

--- Comment #16 from Fedora Update System  ---
FEDORA-2024-43dea391a0 has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.