[Bug 2227039] New: Review Request: rust-listenfd - Simple library to work with listenfds passed from the outside
https://bugzilla.redhat.com/show_bug.cgi?id=2227039
Bug ID: 2227039 Summary: Review Request: rust-listenfd - Simple library to work with listenfds passed from the outside Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: decathorpe@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://decathorpe.fedorapeople.org/rust-listenfd.spec SRPM URL: https://decathorpe.fedorapeople.org/rust-listenfd-1.0.1-1.fc38.src.rpm
Description: A simple library to work with listenfds passed from the outside (systemd/catflap socket activation).
Fedora Account System Username: decathorpe
https://bugzilla.redhat.com/show_bug.cgi?id=2227039
--- Comment #1 from Fabio Valentini decathorpe@gmail.com --- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=104012426
https://bugzilla.redhat.com/show_bug.cgi?id=2227039
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://crates.io/crates/li | |stenfd
--- Comment #3 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6217411 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2227039
Kalev Lember klember@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ CC| |klember@redhat.com Assignee|nobody@fedoraproject.org |klember@redhat.com Status|NEW |POST
--- Comment #4 from Kalev Lember klember@redhat.com --- Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (Apache-2.0) and is acceptable for Fedora - license files are included with %license in %files - package complies with Rust Packaging Guidelines
Looks nice and clean and the only changes to the package that was in Fedora before the retirement is the version bump from 1.0.0 to 1.0.1 and re-generating the spec file with newer rust2rpm.
Package APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=2227039
--- Comment #5 from Fabio Valentini decathorpe@gmail.com --- Thanks for the review! https://pagure.io/releng/issue/11650
https://bugzilla.redhat.com/show_bug.cgi?id=2227039
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE Last Closed| |2023-09-01 19:52:11
--- Comment #6 from Fabio Valentini decathorpe@gmail.com --- Unretired, updated, built, and built warp with re-enabled test suite. Thanks! https://bodhi.fedoraproject.org/updates/FEDORA-2023-a21d5cfbe6
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com