Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: infiniband-diags - various InfiniBand fabric test utilities
https://bugzilla.redhat.com/show_bug.cgi?id=772288
Summary: Review Request: infiniband-diags - various InfiniBand fabric test utilities Product: Fedora Version: rawhide Platform: Unspecified URL: http://people.redhat.com/dledford/Package%20Review/ OS/Version: Unspecified Status: NEW Severity: unspecified Priority: unspecified Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: dledford@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: ---
The infiniband-diags package provides a number of utilities for querying the state of an InfiniBand fabric. It can get the detailed information on any given port on the fabric for diagnostic purposes.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=772288
Albert Strasheim fullung@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fullung@gmail.com
--- Comment #1 from Albert Strasheim fullung@gmail.com 2012-01-09 07:52:44 EST --- I suggest that a devel and devel-static are added for this package:
%description devel Header files for the infiniband-diags library.
%package devel-static Summary: Static development files for the infiniband-diags library Group: System Environment/Libraries Requires: %{name}-devel = %{version}-%{release}
%description devel-static Static libraries for the infiniband-diags library.
%files devel %defattr(-,root,root,-) %{_libdir}/lib*.so %{_includedir}/infiniband/* %{_mandir}/man3/*
%files devel-static %defattr(-,root,root,-) %{_libdir}/*.a
The ibnetdisc library that is part of this package is very useful when writing custom admin tools.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=772288
--- Comment #2 from Albert Strasheim fullung@gmail.com 2012-01-09 07:57:09 EST --- $ rpmlint infiniband-diags.spec infiniband-diags.spec:12: W: unversioned-explicit-provides perl(IBswcountlimits) 0 packages and 1 specfiles checked; 0 errors, 1 warnings.
$ rpmlint infiniband-diags-1.5.12-1.fc15.x86_64.rpm infiniband-diags.x86_64: W: spelling-error %description -l en_US subnet -> subset, sublet, sub net infiniband-diags.x86_64: W: obsolete-not-provided openib-diags infiniband-diags.x86_64: W: non-conffile-in-etc /etc/infiniband-diags/error_thresholds infiniband-diags.x86_64: W: no-manual-page-for-binary check_lft_balance.pl infiniband-diags.x86_64: W: no-manual-page-for-binary ibdiscover.pl infiniband-diags.x86_64: W: no-manual-page-for-binary dump_mfts.sh infiniband-diags.x86_64: W: no-manual-page-for-binary ibqueryerrors.pl infiniband-diags.x86_64: W: no-manual-page-for-binary dump_lfts.sh infiniband-diags.x86_64: W: no-manual-page-for-binary ibswportwatch.pl infiniband-diags.x86_64: W: no-manual-page-for-binary ibfindnodesusing.pl infiniband-diags.x86_64: W: no-manual-page-for-binary ibprintca.pl infiniband-diags.x86_64: W: no-manual-page-for-binary ibprintswitch.pl infiniband-diags.x86_64: W: no-manual-page-for-binary iblinkinfo.pl infiniband-diags.x86_64: W: no-manual-page-for-binary set_nodedesc.sh infiniband-diags.x86_64: W: no-manual-page-for-binary ibidsverify.pl infiniband-diags.x86_64: W: no-manual-page-for-binary ibprintrt.pl 1 packages and 0 specfiles checked; 0 errors, 16 warnings.
Looks like the file in sysconfdir needs a %config(noreplace).
I noticed on the linux-rdma mailing list that these scripts aren't supported anymore:
http://www.spinics.net/lists/linux-rdma/msg10669.html
Do we want to package them?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=772288
--- Comment #3 from Doug Ledford dledford@redhat.com 2012-01-09 14:16:51 EST --- New files (although with the same n-v-r) uploaded to my package page listed in the URL above that address the comments.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=772288
--- Comment #4 from Albert Strasheim fullung@gmail.com 2012-01-10 07:12:42 EST --- Package looks good. Thanks. Does anything else need to be done to finish the review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=772288
--- Comment #5 from Doug Ledford dledford@redhat.com 2012-01-10 08:03:02 EST --- The reviewer needs to set the fedora-cvs flag I think, and then the rel-eng people will create a cvs (git now, but the flag name hasn't changed) module and create the appropriate branches and then possibly import the srpm into the git repo, or something like that. I'm a bit fuzzy on the process myself as I don't do it all that often.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=772288
--- Comment #6 from Doug Ledford dledford@redhat.com 2012-01-10 12:21:35 EST --- My mistake, now that you've approved it, it's up to me to do the request.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=772288
--- Comment #7 from Doug Ledford dledford@redhat.com 2012-01-10 12:23:25 EST --- Except that the way you are supposed to signify that it has passed your review is setting the fedora-review flag to +, then I can proceed with making the request for package addition.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=772288
Albert Strasheim fullung@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=772288
Albert Strasheim fullung@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |
--- Comment #8 from Albert Strasheim fullung@gmail.com 2012-01-10 15:06:00 EST --- It seems I can't set fedora-review flag to +... my only option is ?. I guess I need to get sponsored, which is quite hard, given that I haven't contributed a package.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=772288
--- Comment #9 from Doug Ledford dledford@redhat.com 2012-01-10 15:54:20 EST --- Yep, that would be a problem ;-) I've asked one of my co workers to take a look.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=772288
Jay Fenlason fenlason@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fenlason@redhat.com Flag| |fedora-review+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=772288
Doug Ledford dledford@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |fullung@gmail.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=772288
Doug Ledford dledford@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #10 from Doug Ledford dledford@redhat.com 2012-01-10 16:30:44 EST --- New Package SCM Request ======================= Package Name: infiniband-diags Short Description: Tools to query and diagnose InfiniBand physical networks Owners: dledford Branches: f15 f16 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=772288
--- Comment #11 from Jon Ciesla limburgher@gmail.com 2012-01-10 19:58:24 EST --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=772288
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=772288
--- Comment #12 from Fedora Update System updates@fedoraproject.org 2012-01-11 14:07:56 EST --- infiniband-diags-1.5.12-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/infiniband-diags-1.5.12-1.fc16
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=772288
--- Comment #13 from Fedora Update System updates@fedoraproject.org 2012-01-11 14:08:04 EST --- infiniband-diags-1.5.12-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/infiniband-diags-1.5.12-1.fc15
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=772288
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #14 from Fedora Update System updates@fedoraproject.org 2012-01-15 15:08:27 EST --- infiniband-diags-1.5.12-1.fc15 has been pushed to the Fedora 15 testing repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=772288
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |infiniband-diags-1.5.12-1.f | |c16 Resolution| |ERRATA Last Closed| |2012-02-01 14:23:52
--- Comment #15 from Fedora Update System updates@fedoraproject.org 2012-02-01 14:23:52 EST --- infiniband-diags-1.5.12-1.fc16 has been pushed to the Fedora 16 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=772288
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|infiniband-diags-1.5.12-1.f |infiniband-diags-1.5.12-1.f |c16 |c15
--- Comment #16 from Fedora Update System updates@fedoraproject.org 2012-02-01 14:25:25 EST --- infiniband-diags-1.5.12-1.fc15 has been pushed to the Fedora 15 stable repository.
package-review@lists.fedoraproject.org