[Bug 254135] New: Review Request: libpanelappletmm - C++ interface for Gnome panel applets
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=254135
Summary: Review Request: libpanelappletmm - C++ interface for Gnome panel applets Product: Fedora Version: devel Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: denis@poolshark.org QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com
Spec URL: http://www.poolshark.org/src/libpanelappletmm.spec SRPM URL: http://www.poolshark.org/src/libpanelappletmm-2.6.0-1.src.rpm
Description:
libpanelappletmm is part of the gnomemm project and provides a C++ interface for developing Gnome panel applets.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libpanelappletmm - C++ interface for Gnome panel applets
https://bugzilla.redhat.com/show_bug.cgi?id=254135
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |mtasaka@ioa.s.u-tokyo.ac.jp Status|NEW |ASSIGNED Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libpanelappletmm - C++ interface for Gnome panel applets
https://bugzilla.redhat.com/show_bug.cgi?id=254135
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-08-27 14:18 EST ------- For 2.6.0-1:
* Possibly missing BuildRequires - From build.log: ----------------------------------------------------- Generating code for file enums.h... Generatsh: dot: command not found Problems running dot: exit code=127, command='dot', arguments='"classGtk_1_1EventBox__inherit__graph.dot" -Tpng -o "classGtk_1_1EventBox__inherit__graph.png"' sh: dot: command not found ------------------------------------------------------ (and similar lines follow) Perhaps graphviz is missing from BuildRequires (also graphviz-gd or so MAY be needed for BuildRequries).
* %install ------------------------------------------------------ %install make install DESTDIR=$RPM_BUILD_ROOT find $RPM_BUILD_ROOT -type f -name "*.la" -exec rm -f {} ';'
mkdir -p $RPM_BUILD_ROOT%{_datadir}/ ------------------------------------------------------ - What is the last line for?
* Timestamps - This file installs some text files (such as header files) and keeping timestamps on them is preferable. For recent Makefile, the following method usually works (and also for this package) ------------------------------------------------------ make install DESTDIR=foo INSTALL="%{_install} -p" ------------------------------------------------------
? %_dist tag - Just a question, however do you dislike to use %_dist tag?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libpanelappletmm - C++ interface for Gnome panel applets
https://bugzilla.redhat.com/show_bug.cgi?id=254135
------- Additional Comments From denis@poolshark.org 2007-08-27 18:07 EST ------- - Yup, I missed the graphviz dependency (and only graphviz) - Stray mkdir line removed (leftover from previous version) - Used the timestamp-preserving INSTALL line - Added the dist tag. I always use them.
http://www.poolshark.org/src/libpanelappletmm.spec http://www.poolshark.org/src/libpanelappletmm-2.6.0-2.fc8.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libpanelappletmm - C++ interface for Gnome panel applets
https://bugzilla.redhat.com/show_bug.cgi?id=254135
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-08-28 02:41 EST ------- Okay.
------------------------------------------------------ This package (libpanelappletmm) is APPROVED by me ------------------------------------------------------
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libpanelappletmm - C++ interface for Gnome panel applets
https://bugzilla.redhat.com/show_bug.cgi?id=254135
denis@poolshark.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
------- Additional Comments From denis@poolshark.org 2007-08-28 03:05 EST ------- Thanks for the review :-)
New Package CVS Request ======================= Package Name: libpanelappletmm Short Description: C++ interface for Gnome panel applets Owners: denis Branches: FC-6 F-7 devel InitialCC: Cvsextras Commits: yes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libpanelappletmm - C++ interface for Gnome panel applets
https://bugzilla.redhat.com/show_bug.cgi?id=254135
wtogami@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libpanelappletmm - C++ interface for Gnome panel applets
https://bugzilla.redhat.com/show_bug.cgi?id=254135
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-09-01 10:56 EST ------- Please close this bug as NEXTRELEASE when rebuild is done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libpanelappletmm - C++ interface for Gnome panel applets
https://bugzilla.redhat.com/show_bug.cgi?id=254135
denis@poolshark.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla