https://bugzilla.redhat.com/show_bug.cgi?id=1115665
Bug ID: 1115665 Summary: Review Request: nodejs-csscomb - CSS coding style formatter Product: Fedora Version: rawhide Component: Package Review Assignee: nobody@fedoraproject.org Reporter: rbean@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://ralph.fedorapeople.org//nodejs-csscomb.spec SRPM URL: http://ralph.fedorapeople.org//nodejs-csscomb-3.0.0-0.1.5.fc20.src.rpm
Description: CSScomb is a coding style formatter for CSS. You can easily write your own configuration to make your style sheets beautiful and consistent.
https://bugzilla.redhat.com/show_bug.cgi?id=1115665
Ralph Bean rbean@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1115659
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1115659 [Bug 1115659] Review Request: bootstrap - A front-end framework for developing projects on the web
https://bugzilla.redhat.com/show_bug.cgi?id=1115665
Ralph Bean rbean@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1115667, 1115706, 1115708
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1115667 [Bug 1115667] Review Request: nodejs-gonzales-pe - Gonzales Preprocessor Edition (fast CSS parser) https://bugzilla.redhat.com/show_bug.cgi?id=1115706 [Bug 1115706] Review Request: nodejs-vow-fs - File I/O by Vow https://bugzilla.redhat.com/show_bug.cgi?id=1115708 [Bug 1115708] Review Request: nodejs-vow - Promises/A+ proposal compatible promises library
https://bugzilla.redhat.com/show_bug.cgi?id=1115665
Ralph Bean rbean@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1115675
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1115675 [Bug 1115675] Review Request: nodejs-grunt-csscomb - The grunt plugin for sorting CSS properties in specific order
https://bugzilla.redhat.com/show_bug.cgi?id=1115665
T.C. Hollingsworth tchollingsworth@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |956806 (nodejs-reviews)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=956806 [Bug 956806] Node.js Review Tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1115665 Bug 1115665 depends on bug 1115667, which changed state.
Bug 1115667 Summary: Review Request: nodejs-gonzales-pe - Gonzales Preprocessor Edition (fast CSS parser) https://bugzilla.redhat.com/show_bug.cgi?id=1115667
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1115665 Bug 1115665 depends on bug 1115708, which changed state.
Bug 1115708 Summary: Review Request: nodejs-vow - Promises/A+ proposal compatible promises library https://bugzilla.redhat.com/show_bug.cgi?id=1115708
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1115665 Bug 1115665 depends on bug 1115706, which changed state.
Bug 1115706 Summary: Review Request: nodejs-vow-fs - File I/O by Vow https://bugzilla.redhat.com/show_bug.cgi?id=1115706
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1115665
Tom Hughes tom@compton.nu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |tom@compton.nu Assignee|nobody@fedoraproject.org |tom@compton.nu Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1115665
--- Comment #1 from Tom Hughes tom@compton.nu --- Some preliminary comments:
- I think there's a proper 3.0.0 release now? - This should be a noarch package - I don't think .jshint-groups.js needs to be installed - You should probably install bin/csscomb, and link it from /usr/bin
https://bugzilla.redhat.com/show_bug.cgi?id=1115665
--- Comment #2 from Ralph Bean rbean@redhat.com --- Thanks Tom. This new release should address your comments:
Spec URL: http://threebean.org/rpm/SPECS/nodejs-csscomb.spec SRPM URL: http://threebean.org/rpm/SRPMS/nodejs-csscomb-3.0.1-1.fc20.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1115665
--- Comment #3 from Tom Hughes tom@compton.nu --- This seems to have a dependency on csscomb-core now, which isn't packaged yet.
https://bugzilla.redhat.com/show_bug.cgi?id=1115665
Ralph Bean rbean@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1131978
--- Comment #4 from Ralph Bean rbean@redhat.com --- (In reply to Tom Hughes from comment #3)
This seems to have a dependency on csscomb-core now, which isn't packaged yet.
Ah, so it does.
Spec URL: http://threebean.org/rpm/SPECS/nodejs-csscomb.spec SRPM URL: http://threebean.org/rpm/SRPMS/nodejs-csscomb-3.0.1-2.fc20.src.rpm
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1131978 [Bug 1131978] Review Request: nodejs-csscomb-core - Framework for writing postprocessors
https://bugzilla.redhat.com/show_bug.cgi?id=1115665 Bug 1115665 depends on bug 1131978, which changed state.
Bug 1131978 Summary: Review Request: nodejs-csscomb-core - Framework for writing postprocessors https://bugzilla.redhat.com/show_bug.cgi?id=1131978
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1115665
--- Comment #5 from Ralph Bean rbean@redhat.com --- csscomb-core is in the repos now.
https://bugzilla.redhat.com/show_bug.cgi?id=1115665
Piotr Popieluch piotr1212@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |piotr1212@gmail.com
--- Comment #6 from Piotr Popieluch piotr1212@gmail.com --- Ralph, this will need to be updated to the latest 3.1.8 version. I'm willing to do the review once it is updated.
https://bugzilla.redhat.com/show_bug.cgi?id=1115665
Ralph Bean rbean@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |WONTFIX Last Closed| |2016-04-04 12:07:41
--- Comment #7 from Ralph Bean rbean@redhat.com --- I'm no longer pursuing this one. Thanks to everyone for the assistance here.
package-review@lists.fedoraproject.org