[Bug 1350700] New: Review Request: nodejs-emojione - Emoji One is a complete set of emojis designed for the web
https://bugzilla.redhat.com/show_bug.cgi?id=1350700
Bug ID: 1350700 Summary: Review Request: nodejs-emojione - Emoji One is a complete set of emojis designed for the web Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: tfujiwar@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://fujiwara.fedorapeople.org/nodejs-emojione/nodejs-emojione.spec SRPM URL: https://fujiwara.fedorapeople.org/nodejs-emojione/nodejs-emojione-2.2.4-1.fc... Description: Emoji One is a complete set of emojis designed for the web. It includes libraries to easily convert unicode characters to shortnames (:smile:) and shortnames to our custom emoji images. PNG and SVG formats provided for the emoji images. Fedora Account System Username: fujiwara
https://bugzilla.redhat.com/show_bug.cgi?id=1350700
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@gmail.com Assignee|nobody@fedoraproject.org |panemade@gmail.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1350700
--- Comment #1 from Parag AN(पराग) panemade@gmail.com --- 1) I think instead of creating -devel subpackage, good to create packaging like this nodejs-emojione nodejs-emojione-android nodejs-emojione-awesome nodejs-emojione-ios nodejs-emojione-meteor nodejs-emojione-php nodejs-emojione-python
2)Correct the license as # Artwork included is in CC-BY-SA license # Non-Artwork files are under MIT license License: MIT and CC-BY-SA
https://bugzilla.redhat.com/show_bug.cgi?id=1350700
--- Comment #2 from Mike FABIAN mfabian@redhat.com --- Should the fonts be packaged somewhere to /usr/share/fonts/... instead of:
/usr/lib/node_modules/emojione/assets/fonts/emojione-android.ttf /usr/lib/node_modules/emojione/assets/fonts/emojione-apple.ttf
?
The fonts don’t seem to work though, at least not when using "xfd":
$ fc-list "Emoji One" /home/mfabian/.fonts/emojione-android.ttf: Emoji One:style=Regular $ fc-list "Apple Color Emoji" /home/mfabian/.fonts/emojione-apple.ttf: Apple カラー絵文字,Apple 彩色表情符號,Apple farve-emoji,Apple Farben-Emoji,Applen väri-emoji,Apple Emoji couleur,Colore Emoji Apple,Apple 컬러 이모티콘,Apple Kleur-Emoji,Apple farge-emoji,Apple Emoji em Cores,Цветные эмодзи Apple,Apple färg-emoji,Apple 彩色表情符号,Apple Emoji الملونة,Apple Emoji color,Apple Color Emoji:style=レギュラー,標準體,Ordinær,Normal,Regular,Normaali,Regolare,일반체,Regulier,Обычный,常规体,عادي
$ xfd -fa "Apple Color Emoji" X Error of failed request: BadLength (poly request too large or internal Xlib length error) Major opcode of failed request: 138 (RENDER) Minor opcode of failed request: 20 (RenderAddGlyphs) Serial number of failed request: 326 Current serial number in output stream: 514 $ xfd -fa "Emoji One" X Error of failed request: BadLength (poly request too large or internal Xlib length error) Major opcode of failed request: 138 (RENDER) Minor opcode of failed request: 20 (RenderAddGlyphs) Serial number of failed request: 192 Current serial number in output stream: 657
https://bugzilla.redhat.com/show_bug.cgi?id=1350700
--- Comment #3 from Mike FABIAN mfabian@redhat.com --- Created attachment 1176850 --> https://bugzilla.redhat.com/attachment.cgi?id=1176850&action=edit emojione-android.ttf-versus-emojione-apple.ttf.png
When trying to view the fonts with:
ftview 20 /usr/lib/node_modules/emojione/assets/fonts/emojione-android.ttf ftview 20 /usr/lib/node_modules/emojione/assets/fonts/emojione-apple.ttf
the mojione-apple.ttf works, even in colour, but emojione-android.ttf does not seem to work, ftview shows "Invalid pixel size" (See attached screen shot).
https://bugzilla.redhat.com/show_bug.cgi?id=1350700
--- Comment #4 from Parag AN(पराग) panemade@gmail.com --- I invested some time today on this package and comeup with this partial changes https://pnemade.fedorapeople.org/nodejs-emojione.spec
We still need to work on this spec and as pointed above on fonts. If working fonts are provided by other packages, we can just pull those packages and link them to emojione/assets/fonts/. directory.
https://bugzilla.redhat.com/show_bug.cgi?id=1350700
--- Comment #5 from fujiwara tfujiwar@redhat.com --- (In reply to Mike FABIAN from comment #2)
The fonts don’t seem to work though, at least not when using "xfd":
Thank you for the evaluation. I filed your issues: https://github.com/Ranks/emojione/issues/295
(In reply to Mike FABIAN from comment #2)
Should the fonts be packaged somewhere to /usr/share/fonts/... instead of:
/usr/lib/node_modules/emojione/assets/fonts/emojione-android.ttf /usr/lib/node_modules/emojione/assets/fonts/emojione-apple.ttf
?
Probably can the location be considered when the bug is fixed?
https://bugzilla.redhat.com/show_bug.cgi?id=1350700
--- Comment #6 from fujiwara tfujiwar@redhat.com --- (In reply to Parag AN(पराग) from comment #4)
I invested some time today on this package and comeup with this partial changes https://pnemade.fedorapeople.org/nodejs-emojione.spec
We still need to work on this spec and as pointed above on fonts. If working fonts are provided by other packages, we can just pull those packages and link them to emojione/assets/fonts/. directory.
Updated the spec file. https://fujiwara.fedorapeople.org/nodejs-emojione/nodejs-emojione.spec https://fujiwara.fedorapeople.org/nodejs-emojione/nodejs-emojione-2.2.5-1.fc...
https://bugzilla.redhat.com/show_bug.cgi?id=1350700
--- Comment #7 from Mike FABIAN mfabian@redhat.com --- (In reply to fujiwara from comment #5)
Probably can the location be considered when the bug is fixed?
Yes.
https://bugzilla.redhat.com/show_bug.cgi?id=1350700
--- Comment #10 from Parag AN(पराग) panemade@gmail.com --- I think we can move forward here by removing font files from this package. Can you remove them and submit new update?
Looks like font from upstream is not a hard requirement and we have few options to use Emoji
google-noto-emoji-fonts.noarch : Google Noto Emoji Fonts google-android-emoji-fonts.noarch : Android Emoji font released by Google gdouros-symbola-fonts.noarch : A symbol font
https://bugzilla.redhat.com/show_bug.cgi?id=1350700
--- Comment #11 from fujiwara tfujiwar@redhat.com --- Updated. https://fujiwara.fedorapeople.org/nodejs-emojione/nodejs-emojione.spec https://fujiwara.fedorapeople.org/nodejs-emojione/nodejs-emojione-2.2.5-2.fc...
https://bugzilla.redhat.com/show_bug.cgi?id=1350700
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #12 from Parag AN(पराग) panemade@gmail.com --- 1) You need to write license information same as I wrote in comment1
# Artwork included is in CC-BY-SA license # Non-Artwork files are under MIT license License: MIT and CC-BY-SA
You forgot to add those 2 comment lines
2) You also need to add comment at top of spec file like this # tests are disabled due to missing packages in Fedora
otherwise APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=1350700
--- Comment #13 from fujiwara tfujiwar@redhat.com --- Updated. https://fujiwara.fedorapeople.org/nodejs-emojione/nodejs-emojione.spec https://fujiwara.fedorapeople.org/nodejs-emojione/nodejs-emojione-2.2.5-3.fc...
https://bugzilla.redhat.com/show_bug.cgi?id=1350700
--- Comment #14 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/nodejs-emojione
https://bugzilla.redhat.com/show_bug.cgi?id=1350700
--- Comment #15 from Jens Petersen petersen@redhat.com --- Can emoji.json be subpackaged so other packages can use it?
https://bugzilla.redhat.com/show_bug.cgi?id=1350700
--- Comment #16 from fujiwara tfujiwar@redhat.com --- (In reply to Jens Petersen from comment #15)
Can emoji.json be subpackaged so other packages can use it?
Why? Even though emoji.json is separated, the directory dependency cannot be avoided.
https://bugzilla.redhat.com/show_bug.cgi?id=1350700
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- nodejs-emojione-2.2.6-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-afde6e2f05
https://bugzilla.redhat.com/show_bug.cgi?id=1350700
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1350700
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- nodejs-emojione-2.2.6-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-38e4c90532
https://bugzilla.redhat.com/show_bug.cgi?id=1350700
--- Comment #19 from Fedora Update System updates@fedoraproject.org --- nodejs-emojione-2.2.6-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-afde6e2f05
https://bugzilla.redhat.com/show_bug.cgi?id=1350700
--- Comment #20 from fujiwara tfujiwar@redhat.com --- (In reply to fujiwara from comment #16)
(In reply to Jens Petersen from comment #15)
Can emoji.json be subpackaged so other packages can use it?
Why? Even though emoji.json is separated, the directory dependency cannot be avoided.
I will create -json subpackage likes -lib subpackage.
https://bugzilla.redhat.com/show_bug.cgi?id=1350700
--- Comment #21 from Fedora Update System updates@fedoraproject.org --- nodejs-emojione-2.2.6-3.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-afde6e2f05
https://bugzilla.redhat.com/show_bug.cgi?id=1350700
--- Comment #22 from Fedora Update System updates@fedoraproject.org --- nodejs-emojione-2.2.6-3.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-38e4c90532
https://bugzilla.redhat.com/show_bug.cgi?id=1350700
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #23 from Fedora Update System updates@fedoraproject.org --- nodejs-emojione-2.2.6-3.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-afde6e2f05
https://bugzilla.redhat.com/show_bug.cgi?id=1350700
--- Comment #24 from Fedora Update System updates@fedoraproject.org --- nodejs-emojione-2.2.6-3.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-38e4c90532
https://bugzilla.redhat.com/show_bug.cgi?id=1350700
--- Comment #25 from Fedora Update System updates@fedoraproject.org --- nodejs-emojione-2.2.6-3.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1350700
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2016-08-01 12:27:29
https://bugzilla.redhat.com/show_bug.cgi?id=1350700
--- Comment #26 from Fedora Update System updates@fedoraproject.org --- nodejs-emojione-2.2.6-3.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla