https://bugzilla.redhat.com/show_bug.cgi?id=2356834
Bug ID: 2356834 Summary: Review Request: rust-qapi-qga - QEMU Guest Agent protocol types Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: marcandre.lureau@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://raw.githubusercontent.com/elmarco/ironrdp-fedora/refs/heads/master/r... SRPM URL: https://download.copr.fedorainfracloud.org/results/elmarco/qemu-rdp/srpm-bui... Description: QEMU Guest Agent protocol types Fedora Account System Username: elmarco
https://bugzilla.redhat.com/show_bug.cgi?id=2356834
Marc-Andre Lureau marcandre.lureau@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |rust-qapi-qga
https://bugzilla.redhat.com/show_bug.cgi?id=2356834
Marc-Andre Lureau marcandre.lureau@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2356830 | |(rust-qapi-codegen), | |2356820 (rust-qapi-spec)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2356820 [Bug 2356820] Review Request: rust-qapi-spec - QEMU QAPI common types https://bugzilla.redhat.com/show_bug.cgi?id=2356830 [Bug 2356830] Review Request: rust-qapi-codegen - QEMU QAPI codegen helper
https://bugzilla.redhat.com/show_bug.cgi?id=2356834
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://crates.io/crates/qa | |pi-qga
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8848107 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2356834
Marc-Andre Lureau marcandre.lureau@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2356839 (rust-qapi)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2356839 [Bug 2356839] Review Request: rust-qapi - QEMU QMP and Guest Agent API
https://bugzilla.redhat.com/show_bug.cgi?id=2356834 Bug 2356834 depends on bug 2356820, which changed state.
Bug 2356820 Summary: Review Request: rust-qapi-spec - QEMU QAPI common types https://bugzilla.redhat.com/show_bug.cgi?id=2356820
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2356834 Bug 2356834 depends on bug 2356830, which changed state.
Bug 2356830 Summary: Review Request: rust-qapi-codegen - QEMU QAPI codegen helper https://bugzilla.redhat.com/show_bug.cgi?id=2356830
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2356834
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? CC| |decathorpe@gmail.com Assignee|nobody@fedoraproject.org |decathorpe@gmail.com Status|NEW |ASSIGNED
--- Comment #2 from Fabio Valentini decathorpe@gmail.com --- One small issue: The Source1 URL is 404, it's missing the git ref part of the URL.
https://bugzilla.redhat.com/show_bug.cgi?id=2356834
--- Comment #3 from Marc-Andre Lureau marcandre.lureau@redhat.com --- Spec URL: https://raw.githubusercontent.com/elmarco/ironrdp-fedora/refs/heads/master/r... SRPM URL: https://download.copr.fedorainfracloud.org/results/elmarco/qemu-rdp/srpm-bui... Description: QEMU Guest Agent protocol types Fedora Account System Username: elmarco
https://bugzilla.redhat.com/show_bug.cgi?id=2356834
--- Comment #4 from Fabio Valentini decathorpe@gmail.com --- Why did you include the GPLv2 license text here too? There are no GPLv2 licensed files in this crate.
https://bugzilla.redhat.com/show_bug.cgi?id=2356834
--- Comment #5 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2084082 --> https://bugzilla.redhat.com/attachment.cgi?id=2084082&action=edit The .spec file difference from Copr build 8848107 to 8881512
https://bugzilla.redhat.com/show_bug.cgi?id=2356834
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |AutomationTriaged
--- Comment #6 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8881512 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2356834
--- Comment #7 from Marc-Andre Lureau marcandre.lureau@redhat.com --- (In reply to Fabio Valentini from comment #4)
Why did you include the GPLv2 license text here too? There are no GPLv2 licensed files in this crate.
./schema/qga/qapi-schema.json is also from QEMU
https://bugzilla.redhat.com/show_bug.cgi?id=2356834
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #8 from Fabio Valentini decathorpe@gmail.com --- Ok, please document this in the spec file then. This file (in constrast to the other ones where I noticed this) doesn't have a license header with an SPDX identifier.
===
Package was generated with rust2rpm, simplifying the review.
✅ package contains only permissible content ✅ package builds and installs without errors on rawhide 🫤 test suite is run and all unit tests pass (there are no tests) ✅ latest version of the crate is packaged 🫤 license matches upstream specification and is acceptable for Fedora (adapted for GPLv2-licensed contents of the package) 🫤 license files are included with %license in %files (MIT: manually included from upstream; GPLv2: manually included canonical text) ✅ package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- set bugzilla assignee overrides to @rust-sig (optional)
https://bugzilla.redhat.com/show_bug.cgi?id=2356834
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |RELEASE_PENDING
--- Comment #9 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-qapi-qga
https://bugzilla.redhat.com/show_bug.cgi?id=2356834
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RELEASE_PENDING |MODIFIED
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-76fe360c68 (rust-qapi-qga-0.13.0-2.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-76fe360c68
https://bugzilla.redhat.com/show_bug.cgi?id=2356834
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA Last Closed| |2025-04-11 11:09:56
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-76fe360c68 (rust-qapi-qga-0.13.0-2.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com