[Bug 226664] New: Merge Review: ypserv

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226664

Summary: Merge Review: ypserv
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: normal
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail]

Fedora Merge Review: ypserv

http://cvs.fedora.redhat.com/viewcvs/devel/ypserv/
Initial Owner: [e-mail]

[Bug 226664] Merge Review: ypserv

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=226664

Nikola Pajkovsky  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
         AssignedTo|[e-mail]    |[e-mail]

[Bug 226664] Merge Review: ypserv

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=226664

Nikola Pajkovsky  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |MODIFIED

--- Comment #1 from Nikola Pajkovsky   2010-01-04 06:38:20 EDT ---
++ source files match upstream
++ package meets naming and versioning guidelines
++ specfile is properly named, is cleanly written and uses macros consistently
++ dist tag is present
++ build root is correct
++ license field matches the actual license
++ license is open source-compatible
++ latest version is being packaged
++ BuildRequires are proper
-- compiler flags are appropriate
    erase --enable-yppasswd(it's not an option in configure)
++ %clean is present
++ package builds in mock
++ debuginfo package looks complete
++ final provides and requires look sane
-- %check is present and all tests pass
  upstream don't provide any testcases
++ no shared libraries are added to the regular linker search paths
??(not sure) owns the directories it creates
++ doesn't own any directories it shouldn't
++ no duplicates in %files
++ file permissions are appropriate
++ no scriptlets present
-- %docs are not necessary for the proper functioning of the package
  config files is taken from documentation
++ documentation is small, so no -docs subpackage is necessary
++ no headers
++ no pkgconfig files
++ no libtool .la droppings
++ not a GUI app

$ rpmlint i386/*
ypserv.i386: W: obsolete-not-provided yppasswd
ypserv.i386: W: conffile-without-noreplace-flag /etc/rc.d/init.d/yppasswdd
ypserv.i386: W: conffile-without-noreplace-flag /etc/rc.d/init.d/ypxfrd
ypserv.i386: W: conffile-without-noreplace-flag /etc/rc.d/init.d/ypserv
ypserv.i386: E: executable-marked-as-config-file /etc/rc.d/init.d/yppasswdd
ypserv.i386: E: executable-marked-as-config-file /etc/rc.d/init.d/ypxfrd
ypserv.i386: E: executable-marked-as-config-file /etc/rc.d/init.d/ypserv
2 packages and 0 specfiles checked; 3 errors, 4 warnings.

[Bug 226664] Merge Review: ypserv

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=226664

--- Comment #2 from Karel Klíč   2010-01-05 05:59:42 EDT ---
> -- compiler flags are appropriate
>     erase --enable-yppasswd(it's not an option in configure)

Fixed.
> -- %docs are not necessary for the proper functioning of the package
>   config files is taken from documentation

I think this is ok. The package copies configuration files from upstream to
documentation by marking them as %doc. These files are not used by ypserv.
> ypserv.i386: W: obsolete-not-provided yppasswd
> ypserv.i386: W: conffile-without-noreplace-flag /etc/rc.d/init.d/yppasswdd
> ypserv.i386: W: conffile-without-noreplace-flag /etc/rc.d/init.d/ypxfrd
> ypserv.i386: W: conffile-without-noreplace-flag /etc/rc.d/init.d/ypserv
> ypserv.i386: E: executable-marked-as-config-file /etc/rc.d/init.d/yppasswdd
> ypserv.i386: E: executable-marked-as-config-file /etc/rc.d/init.d/ypxfrd
> ypserv.i386: E: executable-marked-as-config-file /etc/rc.d/init.d/ypserv

I think these warnings and errors may be omitted.

[Bug 226664] Merge Review: ypserv

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=226664

Nikola Pajkovsky  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+

[Bug 226664] Merge Review: ypserv

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=226664

Karel Klíč  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |CLOSED
         Resolution|                            |RAWHIDE