[Bug 228294] New: Review Request: gkrellm-sun - Sun clock plugin for GKrellM

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228294

Summary: Review Request: gkrellm-sun - Sun clock plugin for
                    GKrellM
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: normal
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]

Spec URL: http://ftp.es6.freshrpms.net/tmp/extras/gkrellm-sun/
SRPM URL: http://ftp.es6.freshrpms.net/tmp/extras/gkrellm-sun/
Description:
A sun clock plugin for GKrellM which can display the sun's setting time, rising
time, path and current location and so on.

This is a pretty trivial package. Notes :
- The name "gkrellsun" has been changed to be in the "gkrellm-*" namespace.
- No configure, so the Makefile's FLAGS have been (ab)used to pass our optflags.
- Explicit "gkrellm" requirement set because of the version it needs.
- The very similar "gkrellm-moon" package will also be submitted by itself.

[Bug 228294] Review Request: gkrellm-sun - Sun clock plugin for GKrellM

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gkrellm-sun - Sun clock plugin for GKrellM

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228294

------- Additional Comments From [e-mail]  2007-02-12 10:51 EST -------
The gkrellm-moon package is bug #228293 in case someone wants to review both
packages at once and save testing time.

[Bug 228294] Review Request: gkrellm-sun - Sun clock plugin for GKrellM

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gkrellm-sun - Sun clock plugin for GKrellM

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228294

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail]    |[e-mail]
OtherBugsDependingO|163776                      |163778
              nThis|                            |

------- Additional Comments From [e-mail]  2007-02-13 23:14 EST -------
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
fbbf5c23a3966b2e16a2bab19a0885b7  gkrellsun-1.0.0.tar.gz
fbbf5c23a3966b2e16a2bab19a0885b7  gkrellsun-1.0.0.tar.gz.1
OK - BuildRequires correct
See below - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.

OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - No rpmlint output.
OK - final provides and requires are sane:

SHOULD Items:

OK - Should build in mock.
OK - Should build on all supported archs
OK - Should function as described. 
OK - Should have dist tag
OK - Should package latest version

Issues:

1. Default perms are
%defattr(-, root, root, 0755)

Can that be changed to:

%defattr(-, root, root, -)

2. Please use the one true build root(tm):

%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

[Bug 228294] Review Request: gkrellm-sun - Sun clock plugin for GKrellM

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gkrellm-sun - Sun clock plugin for GKrellM

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228294

------- Additional Comments From [e-mail]  2007-02-14 05:22 EST -------
1. OK, it's changed to %defattr(-,root,root,-)
2. It's a matter of personal taste and a dislike of sticky futile exec()s :-)

gkrellm-sun-1.0.0-2.fc6.src.rpm and an updated spec file are available from the
same location.

[Bug 228294] Review Request: gkrellm-sun - Sun clock plugin for GKrellM

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gkrellm-sun - Sun clock plugin for GKrellM

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228294

------- Additional Comments From [e-mail]  2007-02-14 11:19 EST -------
1. good. ok.

2. Well, it was recently decided that the current preferred buildroot should be
made mandatory.

See:

http://www.fedoraproject.org/wiki/Extras/SteeringCommittee/Meeting-20070208

The longer term plan is to have rpmbuild setup some sane buildroot and not need
to specify it in the spec file at all.

So, could you pretty please change it, and then I can approve this (and
gkrellm-moon). ;)

[Bug 228294] Review Request: gkrellm-sun - Sun clock plugin for GKrellM

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gkrellm-sun - Sun clock plugin for GKrellM

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228294

------- Additional Comments From [e-mail]  2007-02-14 12:00 EST -------
Argh. A useless stupid change is guidelines. The "id" execution to build up the
buildroot has been known to make my mach rebuilds fail, which is the main
technical reason why I have always avoided it. I've asked on the extras-list
what the rationale behind this change is...

[Bug 228294] Review Request: gkrellm-sun - Sun clock plugin for GKrellM

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gkrellm-sun - Sun clock plugin for GKrellM

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228294

------- Additional Comments From [e-mail]  2007-02-15 15:58 EST -------
In reply to comment #5:

Unfortunately, nothing useful seems to have come out of the discussion on 
extras-list. ;(

Would you be willing to change the buildroot here (and in gkrellm-moon/any other
blocked submissions) to get them approved for now, and then work with the 
package committee to get some more acceptable buildroot solution ratified down
the road?

[Bug 228294] Review Request: gkrellm-sun - Sun clock plugin for GKrellM

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gkrellm-sun - Sun clock plugin for GKrellM

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228294

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |
              nThis|                            |
               Flag|                            |fedora-review+

------- Additional Comments From [e-mail]  2007-03-01 14:24 EST -------
ok. Today FESCO ratified the buildroot proposal at: 
http://fedoraproject.org/wiki/PackagingDrafts/BuildRoot

The buildroot here meets those guidelines, so this package is APPROVED.

Don't forget to close this once it's been imported and built.

[Bug 228294] Review Request: gkrellm-sun - Sun clock plugin for GKrellM

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gkrellm-sun - Sun clock plugin for GKrellM

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228294

------- Additional Comments From [e-mail]  2007-03-02 13:33 EST -------
New Package CVS Request
=======================
Package Name: gkrellm-sun
Short Description: Sun clock plugin for GKrellM
Owners: [e-mail]
Branches: FC-5 FC-6 devel EL-4 EL-5
InitialCC:

(I still don't have rights to set the fedora-cvs flag...)

[Bug 228294] Review Request: gkrellm-sun - Sun clock plugin for GKrellM

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gkrellm-sun - Sun clock plugin for GKrellM

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228294

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

[Bug 228294] Review Request: gkrellm-sun - Sun clock plugin for GKrellM

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gkrellm-sun - Sun clock plugin for GKrellM

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228294

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

[Bug 228294] Review Request: gkrellm-sun - Sun clock plugin for GKrellM

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gkrellm-sun - Sun clock plugin for GKrellM

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228294

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |CURRENTRELEASE
   Fixed In Version|                            |1.0.0-2