Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: gnome-icon-theme-extras - Additional GNOME icons
https://bugzilla.redhat.com/show_bug.cgi?id=576153
Summary: Review Request: gnome-icon-theme-extras - Additional GNOME icons Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: bnocera@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: ---
Spec URL: http://people.fedoraproject.org/~hadess/gnome-icon-theme-extras/gnome-icon-t... SRPM URL: http://people.fedoraproject.org/~hadess/gnome-icon-theme-extras/gnome-icon-t... Description: This package contains extra device and mime-type icons for use by the GNOME desktop.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=576153
--- Comment #1 from Bastien Nocera bnocera@redhat.com 2010-03-23 08:28:56 EDT --- Note that the tarball isn't upstream yet, but we'll be using a real release tarball as soon as it comes out, and before uploading this package to Fedora.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=576153
--- Comment #2 from Bastien Nocera bnocera@redhat.com 2010-03-23 10:03:38 EDT --- Updated SRPM and spec: http://people.fedoraproject.org/~hadess/gnome-icon-theme-extras/gnome-icon-t... http://people.fedoraproject.org/~hadess/gnome-icon-theme-extras/gnome-icon-t...
With some scriptlets fixes.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=576153
--- Comment #3 from Bastien Nocera bnocera@redhat.com 2010-03-25 10:12:27 EDT --- And with the proper release tarball: http://people.fedoraproject.org/~hadess/gnome-icon-theme-extras/gnome-icon-t... http://people.fedoraproject.org/~hadess/gnome-icon-theme-extras/gnome-icon-t...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=576153
Benjamin Otte otte@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |otte@redhat.com AssignedTo|nobody@fedoraproject.org |otte@redhat.com Flag| |fedora-review?
--- Comment #4 from Benjamin Otte otte@redhat.com 2010-03-26 12:02:33 EDT --- I'm taking this review.
$ rpmlint gnome-icon-theme-extras.spec gnome-icon-theme-extras.spec: W: no-buildroot-tag 0 packages and 1 specfiles checked; 0 errors, 1 warnings. That warning can be ignored due to the new rules. => OK
Koji builds it fine: http://koji.fedoraproject.org/koji/taskinfo?taskID=2077560 => OK
Looking at the ReviewGuidelines, everything looks fine, apart from MUST: The License field in the package spec file must match the actual license spec file says GPL, actual license is CC-BY-SA-3.0 => NOT OK
So with the lixense fixed, the package looks fine.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=576153
--- Comment #5 from Bastien Nocera bnocera@redhat.com 2010-04-01 10:02:22 EDT --- License tag fixed in: http://people.fedoraproject.org/~hadess/gnome-icon-theme-extras/gnome-icon-t... http://people.fedoraproject.org/~hadess/gnome-icon-theme-extras/gnome-icon-t...
Note that the short name doesn't include the version: https://fedoraproject.org/wiki/Licensing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=576153
Benjamin Otte otte@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #6 from Benjamin Otte otte@redhat.com 2010-04-01 10:18:23 EDT --- Yeah, I noticed already that CC licenses don't have a version in Fedora. Weird thing that.
WIth that fixed, the package is accepted.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=576153
Bastien Nocera bnocera@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #7 from Bastien Nocera bnocera@redhat.com 2010-04-01 10:23:48 EDT --- New Package CVS Request ======================= Package Name: gnome-icon-theme-extras Short Description: Additional GNOME icons Owners: hadess Branches: F-12 F-13 devel InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=576153
--- Comment #8 from Kevin Fenzi kevin@tummy.com 2010-04-03 13:41:05 EDT --- CVS done (by process-cvs-requests.py).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=576153
--- Comment #9 from Fedora Update System updates@fedoraproject.org 2010-04-06 12:52:43 EDT --- gnome-icon-theme-extras-2.29.0-4.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/gnome-icon-theme-extras-2.29.0-4.fc13
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=576153
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2010-04-09 00:03:33 EDT --- gnome-icon-theme-extras-2.29.0-4.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=576153
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Fixed In Version| |gnome-icon-theme-extras-2.2 | |9.0-4.fc13 Resolution| |ERRATA
package-review@lists.fedoraproject.org