[Bug 1491216] New: Review Request: 5minute - Give me an instance of mine image on OpenStack
https://bugzilla.redhat.com/show_bug.cgi?id=1491216
Bug ID: 1491216 Summary: Review Request: 5minute - Give me an instance of mine image on OpenStack Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: pmoravco@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://people.redhat.com/pmoravec/5minute/5minute.spec SRPM URL: https://people.redhat.com/pmoravec/5minute/5minute-0.2.18-1.x86_64.rpm Description: Give me an instance of mine image on OpenStack. Hurry! Fedora Account System Username: pmoravco
https://bugzilla.redhat.com/show_bug.cgi?id=1491216
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ngompa13@gmail.com Assignee|nobody@fedoraproject.org |ngompa13@gmail.com Flags| |fedora-review?
--- Comment #1 from Neal Gompa ngompa13@gmail.com --- Taking this review.
https://bugzilla.redhat.com/show_bug.cgi?id=1491216
Iwicki Artur fedora@svgames.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@svgames.pl
--- Comment #2 from Iwicki Artur fedora@svgames.pl ---
License: GNU General Public License v2.0
"The License: field must be filled with the appropriate license Short License identifier(s) from the "Good License" tables on the Fedora Licensing page." In your case, that'll be "GPLv2". https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Valid_License_S...
Source0: %{name}-%{version}.tar.gz
This should be a downloadable URL. Since you've put a GitHub link as the project URL, you can request a tarball from GitHub and use that as Source0. The following wiki page describes this quite well: https://fedoraproject.org/wiki/Packaging:SourceURL#Git_Hosting_Services
https://bugzilla.redhat.com/show_bug.cgi?id=1491216
--- Comment #3 from Neal Gompa ngompa13@gmail.com ---
Release: 1
This should be "Release: 1%{?dist}". See: https://fedoraproject.org/wiki/Packaging:DistTag
%global debug_package %{nil}
Remove this, and add "BuildArch: noarch" right above "%description"
The Python modules that you require, you need to BuildRequires them as well, so that %py3_build will function correctly. They also need to be the Python 3 variants, so use "python3-X" instead of "python-X".
You're also missing a BuildRequires on "python3-devel" and "python3-setuptools".
Summary: Give me an instance of mine image on OpenStack. Hurry!
This does not summarize what the tool does.
%description %{summary}
Please put a proper description in here.
/usr/bin/5minute
Use %{_bindir}/5minute
https://bugzilla.redhat.com/show_bug.cgi?id=1491216
--- Comment #4 from Pavlina Moravcova Varekova pmoravco@redhat.com --- All comments in review corrected except the second comment from Iwicki Artur. Should I correct it too? Spec URL: https://people.redhat.com/pmoravec/5minute/5minute.spec SRPM URL: https://people.redhat.com/pmoravec/5minute/5minute-0.2.18-1.fc26.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1491216
--- Comment #5 from Neal Gompa ngompa13@gmail.com --- The description needs to be wrapped at 79 columns.
The Source URL should be a valid URL for people to be able to get the sources using "spectool -g". See for reference: https://fedoraproject.org/wiki/Packaging:SourceURL#Git_Hosting_Services
https://bugzilla.redhat.com/show_bug.cgi?id=1491216
--- Comment #6 from Neal Gompa ngompa13@gmail.com --- Ah, yeah, Iwiki did already point out the Source URL thing, and he's correct.
https://bugzilla.redhat.com/show_bug.cgi?id=1491216
--- Comment #7 from Pavlina Moravcova Varekova pmoravco@redhat.com --- Thank you very much. Files are corrected Spec URL: https://people.redhat.com/pmoravec/5minute/5minute.spec SRPM URL: https://people.redhat.com/pmoravec/5minute/5minute-0.2.18-1.fc26.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1491216
--- Comment #8 from Neal Gompa ngompa13@gmail.com --- @Pavlina:
There's one last thing:
Source0: https://github.com/SatelliteQE/%%7Bname%7D/archive/%%7Bversion%7D.tar.gz
Can this please be adjusted to the following:
Source0: https://github.com/SatelliteQE/%%7Bname%7D/archive/%%7Bversion%7D/%%7Bname%7...
https://bugzilla.redhat.com/show_bug.cgi?id=1491216
--- Comment #9 from Pavlina Moravcova Varekova pmoravco@redhat.com ---
Can it be adjusted to:
Source0: https://github.com/SatelliteQE/%%7Bname%7D/archive/%%7Bname%7D-%%7Bversion%7...
https://bugzilla.redhat.com/show_bug.cgi?id=1491216
--- Comment #10 from Neal Gompa ngompa13@gmail.com --- I guess so, as that's a valid tag, but then the `%autosetup` invocation needs to change.
It would need to be:
%autosetup -n %{name}-%{name}-%{version}
https://bugzilla.redhat.com/show_bug.cgi?id=1491216
--- Comment #11 from Pavlina Moravcova Varekova pmoravco@redhat.com --- Thanks for your advice. Files are changed Spec URL: https://people.redhat.com/pmoravec/5minute/5minute.spec SRPM URL: https://people.redhat.com/pmoravec/5minute/5minute-0.2.18-1.fc26.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1491216
--- Comment #12 from Neal Gompa ngompa13@gmail.com ---
%autosetup -n %{name}-%{version}
This needs to be the following:
%autosetup -n %{name}-%{name}-%{version}
GitHub prefixes the project name to the folder inside the tarball already. It does <project-name>-<tag>. Since the tag already has the project name, it has to be repeated twice.
https://bugzilla.redhat.com/show_bug.cgi?id=1491216
--- Comment #13 from Pavlina Moravcova Varekova pmoravco@redhat.com --- When I tried to use:
%autosetup -n %{name}-%{name}-%{version}
inside the spec file command
rpmbuild -ba 5minute.spec
returned an error:
....
- STATUS=0
- '[' 0 -ne 0 ']'
- cd 5minute-5minute-0.2.18
/var/tmp/rpm-tmp.DTVZAm: line 38: cd: 5minute-5minute-0.2.18: No such file or directory
RPM build errors: Bad exit status from /var/tmp/rpm-tmp.uIHOOw (%prep)
With
%autosetup -n %{name}-%{version}
command
rpmbuild -ba 5minute.spec
worked correctly:
....
- STATUS=0
- '[' 0 -ne 0 ']'
- cd 5minute-0.2.18
- /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w .
- exit 0
....
(I find the construction "-n %{name}-%{version}" in some existing spec files e.g. vrms-rpm.spec, libvmi.spec, osmium-tool.spec)
https://bugzilla.redhat.com/show_bug.cgi?id=1491216
--- Comment #14 from Igor Gnatenko ignatenko@redhat.com --- Does upstream use tito? Do you use tito to prepare tarball / srpm? This might be hint where to look.
https://bugzilla.redhat.com/show_bug.cgi?id=1491216
--- Comment #15 from Neal Gompa ngompa13@gmail.com --- Igor,
Upstream is not using tito, but they seem to be preparing tarballs by hand. The tarball I get from GitHub doesn't match the SRPM tarball.
https://bugzilla.redhat.com/show_bug.cgi?id=1491216
--- Comment #16 from Pavlina Moravcova Varekova pmoravco@redhat.com --- Thanks. Files are changed Spec URL: https://people.redhat.com/pmoravec/5minute/5minute.spec SRPM URL: https://people.redhat.com/pmoravec/5minute/5minute-0.2.18-1.fc26.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1491216
--- Comment #17 from Neal Gompa ngompa13@gmail.com --- There were some rpmlint errors raised by fedora-review:
5minute.noarch: E: wrong-script-interpreter /usr/lib/python3.6/site-packages/vminute/__init__.py /usr/bin/env python 5minute.noarch: E: non-executable-script /usr/lib/python3.6/site-packages/vminute/__init__.py 644 /usr/bin/env python 5minute.noarch: E: wrong-script-interpreter /usr/lib/python3.6/site-packages/vminute/vminute.py /usr/bin/env python 5minute.noarch: E: non-executable-script /usr/lib/python3.6/site-packages/vminute/vminute.py 644 /usr/bin/env python
https://bugzilla.redhat.com/show_bug.cgi?id=1491216
--- Comment #18 from Pavlina Moravcova Varekova pmoravco@redhat.com --- Thank you very much. Files are corrected: Spec URL: https://people.redhat.com/pmoravec/5minute/5minute.spec SRPM URL: https://people.redhat.com/pmoravec/5minute/5minute-0.2.26-1.fc27.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1491216
--- Comment #19 from Neal Gompa ngompa13@gmail.com ---
Source0: https://github.com/SatelliteQE/%%7Bname%7D/archive/%%7Bversion%7D.tar.gz
Could you change this to:
Source0: https://github.com/SatelliteQE/%%7Bname%7D/archive/%%7Bversion%7D/%%7Bname%7...
This reflects the recommended form per the guidelines: https://fedoraproject.org/wiki/Packaging:SourceURL#Git_Tags
%autosetup -n %{name}-%{version}
This can just be "%autosetup"
https://bugzilla.redhat.com/show_bug.cgi?id=1491216
--- Comment #20 from Pavlina Moravcova Varekova pmoravco@redhat.com --- Thank you very much. I asked the upstream and they edit the package name. Now
Source0: https://github.com/SatelliteQE/%%7Bname%7D/archive/%%7Bversion%7D.tar.gz
is changed to:
Source0: https://github.com/SatelliteQE/%%7Bname%7D/archive/%%7Bname%7D-%%7Bversion%7...
%autosetup is changed according to that.
Files: Spec URL: https://people.redhat.com/pmoravec/5minute/5minute.spec SRPM URL: https://people.redhat.com/pmoravec/5minute/5minute-0.2.26-1.fc27.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1491216
--- Comment #21 from Neal Gompa ngompa13@gmail.com --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 15 files have unknown license. Detailed output of licensecheck in /home/makerpm/1491216-5minute/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: 5minute-0.2.26-1.fc28.noarch.rpm 5minute-0.2.26-1.fc28.src.rpm 5minute.noarch: W: spelling-error %description -l en_US pre -> per, ore, pee 5minute.noarch: W: no-manual-page-for-binary 5minute 5minute.src: W: spelling-error %description -l en_US pre -> per, ore, pee 2 packages and 0 specfiles checked; 0 errors, 3 warnings.
Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory 5minute.noarch: W: spelling-error %description -l en_US pre -> per, ore, pee 5minute.noarch: W: no-manual-page-for-binary 5minute 1 packages and 0 specfiles checked; 0 errors, 2 warnings.
Requires -------- 5minute (rpmlib, GLIBC filtered): /usr/bin/python3 python(abi) python3-cinderclient python3-heatclient python3-keystoneclient python3-neutronclient python3-novaclient python3-prettytable python3-xmltodict
Provides -------- 5minute: 5minute python3.6dist(vminute) python3dist(vminute)
Source checksums ---------------- https://github.com/SatelliteQE/5minute/archive/5minute-0.2.26.tar.gz : CHECKSUM(SHA256) this package : ed9a45bf25fb7fdb01559fd89433dc5c38dcc9cb037d036fbc79fc40cc6dbbd4 CHECKSUM(SHA256) upstream package : ed9a45bf25fb7fdb01559fd89433dc5c38dcc9cb037d036fbc79fc40cc6dbbd4
Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/bin/fedora-review -b 1491216 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
https://bugzilla.redhat.com/show_bug.cgi?id=1491216
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #22 from Neal Gompa ngompa13@gmail.com --- Looks good to me.
PACKAGE APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=1491216
--- Comment #23 from Gwyn Ciesla limburgher@gmail.com --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/5minute
https://bugzilla.redhat.com/show_bug.cgi?id=1491216
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |CURRENTRELEASE Last Closed| |2018-09-08 10:47:23
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com